From 0d594345a31dbacdc2f200d5edf7852fb5d8d751 Mon Sep 17 00:00:00 2001 From: DarkSky <25152247+darkskygit@users.noreply.github.com> Date: Tue, 17 Nov 2026 13:41:13 +0800 Subject: [PATCH] fix(core): sync indicator style (#15863) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #### PR Dependency Tree * **PR #15863** 👈 This tree was auto-generated by [Charcoal](https://github.com/danerwilliams/charcoal) ## Summary by CodeRabbit * **Bug Fixes** * The notification menu item no longer displays an active state solely because the notification list is open; opening and closing the list works as before. * **Style** * Refined the layout of the workspace sync-status button while preserving its existing label and appearance details. The status content now has more consistent spacing and alignment within the workspace card. --- .github/workflows/release.yml | 14 ++++++++++---- .../root-app-sidebar/notification-button.tsx | 1 - .../workspace-selector/workspace-card/index.tsx | 2 ++ .../workspace-card/styles.css.ts | 10 +++++++--- 4 files changed, 19 insertions(+), 8 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index fec187b1f3..9289f29750 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -55,10 +55,16 @@ jobs: const fs = require('node:fs'); const releases = await github.paginate(github.rest.repos.listReleases, {...context.repo, per_page: 100}); for (const release of releases) { - const asset = release.assets.find(asset => asset.name === 'affine-release-completed.json'); - if (!asset) continue; - const response = await github.rest.repos.getReleaseAsset({...context.repo, asset_id: asset.id, headers: {accept:'application/octet-stream'}}); - const previous = JSON.parse(Buffer.from(response.data).toString('utf8')); + const embedded = release.body?.match(//); + let previous; + if (embedded) { + previous = JSON.parse(embedded[1]); + } else { + const asset = release.assets.find(asset => asset.name === 'affine-release-completed.json'); + if (!asset) continue; + const response = await github.rest.repos.getReleaseAsset({...context.repo, asset_id: asset.id, headers: {accept:'application/octet-stream'}}); + previous = JSON.parse(Buffer.from(response.data).toString('utf8')); + } if (previous.request.channel !== 'canary') continue; fs.writeFileSync('release-previous.json', JSON.stringify(previous)); break; diff --git a/packages/frontend/core/src/components/root-app-sidebar/notification-button.tsx b/packages/frontend/core/src/components/root-app-sidebar/notification-button.tsx index 0d0082c72d..ee51d85047 100644 --- a/packages/frontend/core/src/components/root-app-sidebar/notification-button.tsx +++ b/packages/frontend/core/src/components/root-app-sidebar/notification-button.tsx @@ -56,7 +56,6 @@ export const NotificationButton = () => { } postfix={} - active={notificationListOpen} postfixDisplay="always" > diff --git a/packages/frontend/core/src/components/workspace-selector/workspace-card/index.tsx b/packages/frontend/core/src/components/workspace-selector/workspace-card/index.tsx index 8e7d9b78f9..0fb6e2848c 100644 --- a/packages/frontend/core/src/components/workspace-selector/workspace-card/index.tsx +++ b/packages/frontend/core/src/components/workspace-selector/workspace-card/index.tsx @@ -337,8 +337,10 @@ const WorkspaceSyncInfo = ({ >