From 102bb9926e87fdddb2edba3a0863adc8b62b13e9 Mon Sep 17 00:00:00 2001 From: ShareVB Date: Thu, 28 May 2026 09:33:36 +0200 Subject: [PATCH] fix(Data Storage Units Converter): fix b/iB/B conversion Fix #398 --- .../data-storage-unit-converter.service.test.ts | 7 +++++++ .../data-storage-unit-converter.service.ts | 8 ++++---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/tools/data-storage-unit-converter/data-storage-unit-converter.service.test.ts b/src/tools/data-storage-unit-converter/data-storage-unit-converter.service.test.ts index b26aedba..e2fc182d 100644 --- a/src/tools/data-storage-unit-converter/data-storage-unit-converter.service.test.ts +++ b/src/tools/data-storage-unit-converter/data-storage-unit-converter.service.test.ts @@ -29,6 +29,13 @@ describe('data-storage-unit-converter', () => { expect(convertStorageAndRateUnitsDisplay({ value: 1, fromUnit: 'Mb', toUnit: 'KB', precision: 0 })).toBe('125'); expect(convertStorageAndRateUnitsDisplay({ value: 125, fromUnit: 'KB', toUnit: 'Mb', precision: 0 })).toBe('1'); + expect(convertStorageAndRateUnitsDisplay({ value: 8, fromUnit: 'b', toUnit: 'B' })).toBe('1.000'); + expect(convertStorageAndRateUnitsDisplay({ value: 1, fromUnit: 'B', toUnit: 'b' })).toBe('8.000'); + expect(convertStorageAndRateUnitsDisplay({ value: 8000, fromUnit: 'b', toUnit: 'KB' })).toBe('1.000'); + expect(convertStorageAndRateUnitsDisplay({ value: 1000, fromUnit: 'iB', toUnit: 'b' })).toBe('8000.000'); + expect(convertStorageAndRateUnitsDisplay({ value: 1, fromUnit: 'KiB', toUnit: 'b' })).toBe('8192.000'); + expect(convertStorageAndRateUnitsDisplay({ value: 1, fromUnit: 'KB', toUnit: 'iB' })).toBe('1000.000'); + expect(convertStorageAndRateUnitsDisplay({ value: 1, fromUnit: 'MiB', toUnit: 'Kb' })).toBe('8388.608'); expect(convertStorageAndRateUnitsDisplay({ value: 8388.608, fromUnit: 'Kb', toUnit: 'MiB', precision: 0 })).toBe('1'); }); diff --git a/src/tools/data-storage-unit-converter/data-storage-unit-converter.service.ts b/src/tools/data-storage-unit-converter/data-storage-unit-converter.service.ts index 3b5d4c85..3e2373c4 100644 --- a/src/tools/data-storage-unit-converter/data-storage-unit-converter.service.ts +++ b/src/tools/data-storage-unit-converter/data-storage-unit-converter.service.ts @@ -32,11 +32,11 @@ export function convertStorageAndRateUnits( ]; const fromIndex = units.indexOf(fromUnit); - const fromFactor = fromIndex / 9 > 1 ? 1000 : 1024; - const fromDivisor = fromIndex / 9 > 2 ? 8 : 1; + const fromFactor = fromIndex / 9 >= 1 ? 1000 : 1024; + const fromDivisor = fromIndex / 9 >= 2 ? 8 : 1; const toIndex = units.indexOf(toUnit); - const toFactor = toIndex / 9 > 1 ? 1000 : 1024; - const toDivisor = toIndex / 9 > 2 ? 8 : 1; + const toFactor = toIndex / 9 >= 1 ? 1000 : 1024; + const toDivisor = toIndex / 9 >= 2 ? 8 : 1; const fromBase = (fromFactor ** (fromIndex % 9)) / fromDivisor; const toBase = (toFactor ** (toIndex % 9)) / toDivisor;