diff --git a/locales/en.yml b/locales/en.yml index abb411d2..08a64929 100644 --- a/locales/en.yml +++ b/locales/en.yml @@ -8151,6 +8151,8 @@ tools: tag-replication-client: REPLICATION CLIENT tag-replication-slave: REPLICATION SLAVE tag-generate-sql-instructions: Generate SQL Instructions + error-oracle-password-double-quote: Oracle passwords cannot contain double quotes (") + error-oracle-account-double-quote: Oracle account names cannot contain double quotes (") database-table-generator: title: Database Table Generator description: Generate SQL CREATE TABLE for common databases diff --git a/src/tools/database-builder/database-builder.vue b/src/tools/database-builder/database-builder.vue index fba004a8..f7a0bfef 100644 --- a/src/tools/database-builder/database-builder.vue +++ b/src/tools/database-builder/database-builder.vue @@ -14,12 +14,41 @@ const password = ref(''); const permissions = ref([]); const sqlOutput = ref(''); +// Oracle quoted identifiers and passwords cannot contain `"`, and there is no way to escape it +const accountError = computed(() => + dbType.value === 'oracle' && account.value.includes('"') + ? t('tools.database-builder.texts.error-oracle-account-double-quote') + : undefined, +); +const passwordError = computed(() => + dbType.value === 'oracle' && password.value.includes('"') + ? t('tools.database-builder.texts.error-oracle-password-double-quote') + : undefined, +); + function generateRandomPassword(length = 12) { const chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789!@#$%^&*'; return multiRandFromArray([...chars], length).join(''); } +// Quote user input so a quote, backtick or bracket cannot end the literal or identifier early +const sqlString = (value: string) => `'${value.replace(/'/g, "''")}'`; +// E'' treats backslashes as escapes whatever standard_conforming_strings is set to +const pgString = (value: string) => + value.includes('\\') ? `E'${value.replace(/\\/g, '\\\\').replace(/'/g, "''")}'` : sqlString(value); +const mysqlString = (value: string) => `'${value.replace(/\\/g, '\\\\').replace(/'/g, "''")}'`; +const mysqlIdentifier = (value: string) => `\`${value.replace(/`/g, '``')}\``; +const pgIdentifier = (value: string) => `"${value.replace(/"/g, '""')}"`; +const sqlServerIdentifier = (value: string) => `[${value.replace(/]/g, ']]')}]`; +// Quoting makes Oracle names case-sensitive, so plain names stay unquoted (names with `"` are rejected by accountError) +const oracleIdentifier = (value: string) => (/^[A-Za-z][\w$#]*$/.test(value) ? value : `"${value}"`); +const sqlComment = (value: string) => value.replace(/[\r\n]+/g, ' '); + function generateSQL() { + if (accountError.value || passwordError.value) { + sqlOutput.value = ''; + return; + } const pwd = password.value || generateRandomPassword(); const perms = permissions.value.length > 0 ? permissions.value.join(', ') : 'ALL PRIVILEGES'; @@ -28,44 +57,44 @@ function generateSQL() { switch (dbType.value) { case 'mysql': sql = ` -CREATE DATABASE IF NOT EXISTS \`${dbName.value}\`; -CREATE USER IF NOT EXISTS '${account.value}'@'${serverAddress.value || '%'}' IDENTIFIED BY '${pwd}'; -GRANT ${perms} ON \`${dbName.value}\`.* TO '${account.value}'@'${serverAddress.value || '%'}'; +CREATE DATABASE IF NOT EXISTS ${mysqlIdentifier(dbName.value)}; +CREATE USER IF NOT EXISTS ${mysqlString(account.value)}@${mysqlString(serverAddress.value || '%')} IDENTIFIED BY ${mysqlString(pwd)}; +GRANT ${perms} ON ${mysqlIdentifier(dbName.value)}.* TO ${mysqlString(account.value)}@${mysqlString(serverAddress.value || '%')}; FLUSH PRIVILEGES; `.trim(); break; case 'postgresql': sql = ` -CREATE DATABASE "${dbName.value}"; -CREATE ROLE "${account.value}" LOGIN PASSWORD '${pwd}'; -GRANT ${perms} ON DATABASE "${dbName.value}" TO "${account.value}"; +CREATE DATABASE ${pgIdentifier(dbName.value)}; +CREATE ROLE ${pgIdentifier(account.value)} LOGIN PASSWORD ${pgString(pwd)}; +GRANT ${perms} ON DATABASE ${pgIdentifier(dbName.value)} TO ${pgIdentifier(account.value)}; `.trim(); break; case 'sqlserver': sql = ` -CREATE DATABASE [${dbName.value}]; -CREATE LOGIN [${account.value}] WITH PASSWORD = '${pwd}'; -USE [${dbName.value}]; -CREATE USER [${account.value}] FOR LOGIN [${account.value}]; -GRANT ${perms} TO [${account.value}]; +CREATE DATABASE ${sqlServerIdentifier(dbName.value)}; +CREATE LOGIN ${sqlServerIdentifier(account.value)} WITH PASSWORD = ${sqlString(pwd)}; +USE ${sqlServerIdentifier(dbName.value)}; +CREATE USER ${sqlServerIdentifier(account.value)} FOR LOGIN ${sqlServerIdentifier(account.value)}; +GRANT ${perms} TO ${sqlServerIdentifier(account.value)}; `.trim(); break; case 'oracle': sql = ` -CREATE USER ${account.value} IDENTIFIED BY "${pwd}"; -GRANT ${perms} TO ${account.value}; +CREATE USER ${oracleIdentifier(account.value)} IDENTIFIED BY "${pwd}"; +GRANT ${perms} TO ${oracleIdentifier(account.value)}; -- Oracle typically uses schemas; adjust database creation as needed --- for quota, you may want: ALTER USER ${account.value} QUOTA UNLIMITED ON USERS; +-- for quota, you may want: ALTER USER ${sqlComment(oracleIdentifier(account.value))} QUOTA UNLIMITED ON USERS; `.trim(); break; case 'sqlite': sql = ` -- SQLite does not support user management or GRANT statements. --- Database is created as a file: ${dbName.value}.db +-- Database is created as a file: ${sqlComment(dbName.value)}.db -- Permissions are handled at the OS/file system level. `.trim(); break; @@ -99,11 +128,20 @@ GRANT ${perms} TO ${account.value}; - + - +