fix(Cron Generator): better cron validation

Double check with cron-parser and cronstrue for cron expresson validity
Fix #26
This commit is contained in:
ShareVB committed 2025-02-23 10:48:29 +01:00
1 parent 0a0ebddb5d
commit 22f2ce661e
2 files changed
+3

No files matched your search

@@ -33,6 +33,7 @@ describe('crontab-generator', () => {
it('should return false for all invalid formats', () => { it('should return false for all invalid formats', () => {
expect(isCronValid('aert')).toBe(false); expect(isCronValid('aert')).toBe(false);
expect(isCronValid('40 *')).toBe(false); expect(isCronValid('40 *')).toBe(false);
expect(isCronValid('* * * *')).toBe(false);
}); });
}); });
@@ -1,4 +1,5 @@
import { parseExpression } from 'cron-parser'; import { parseExpression } from 'cron-parser';
import cronstrue from 'cronstrue';
import EventCronParser from 'event-cron-parser'; import EventCronParser from 'event-cron-parser';
export type CronType = 'standard' | 'aws'; export type CronType = 'standard' | 'aws';
@@ -32,6 +33,7 @@ export function isCronValid(cronExpression: string, cronType: CronType | 'any' =
export function getCronType(cronExpression: string) { export function getCronType(cronExpression: string) {
try { try {
parseExpression(cronExpression); parseExpression(cronExpression);
cronstrue.toString(cronExpression, { throwExceptionOnParseError: true });
return 'standard'; return 'standard';
} }
catch (_) { catch (_) {