From f39a6cbc2d4c4cdee23336dc3bd91694dff1614b Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Mon, 16 Nov 2026 15:08:32 -0800 Subject: [PATCH] [Fix] `nvm_write_nvmrc`: don't let a symlink swapped in after the check be written through The symlink check and the `tee` were two steps, so anyone who can write `$PWD` could rename a symlink over `.nvmrc` in between, and `nvm use --save`/`nvm install --save` would truncate any file the user can write. Write the version in a private `mktemp -d` dir instead, and rename it into `$PWD/`: a rename replaces a symlink rather than following it, and moving into the directory (not onto `.nvmrc`) avoids landing inside a symlinked directory. An existing `.nvmrc` must be a writable regular file, since a rename would also replace a read-only one. `.nvmrc` is now a new file whose mode comes from the umask. Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-EXZRTATX. --- nvm.sh | 17 +++- ...laces .nvmrc instead of writing through it | 86 +++++++++++++++++++ 2 files changed, 101 insertions(+), 2 deletions(-) create mode 100755 test/fast/Unit tests/nvm_write_nvmrc replaces .nvmrc instead of writing through it diff --git a/nvm.sh b/nvm.sh index 18c4d774..36f6358f 100755 --- a/nvm.sh +++ b/nvm.sh @@ -4643,12 +4643,25 @@ nvm_write_nvmrc() { fi return 3 fi - echo "${VERSION_STRING}" | tee "$PWD"/.nvmrc > /dev/null || { + # a symlink can be swapped in after that check, so never open "$PWD"/.nvmrc: rename a private file into "$PWD"/, + # which replaces a symlink instead of following it. A rename would also replace a read-only .nvmrc, hence that check. + local NVMRC_TMPDIR + NVMRC_TMPDIR='' + if { [ ! -e "$PWD"/.nvmrc ] || { [ -f "$PWD"/.nvmrc ] && [ -w "$PWD"/.nvmrc ]; }; } \ + && NVMRC_TMPDIR="$(command mktemp -d "${NVM_DIR}/.nvmrc.XXXXXX" 2>/dev/null || command mktemp -d "${TMPDIR:-/tmp}/nvm-nvmrc.XXXXXX" 2>/dev/null)" \ + && nvm_echo "${VERSION_STRING}" > "${NVMRC_TMPDIR}/.nvmrc" \ + && command mv -f "${NVMRC_TMPDIR}/.nvmrc" "$PWD"/ 2>/dev/null; then + command rmdir "${NVMRC_TMPDIR}" + else + if [ -n "${NVMRC_TMPDIR}" ]; then + command rm -f "${NVMRC_TMPDIR}/.nvmrc" + command rmdir "${NVMRC_TMPDIR}" + fi if [ "${NVM_SILENT:-0}" -ne 1 ]; then nvm_err "Warning: Unable to write version number ($VERSION_STRING) to .nvmrc" fi return 3 - } + fi if [ "${NVM_SILENT:-0}" -ne 1 ]; then nvm_echo "Wrote version number ($VERSION_STRING) to .nvmrc" fi diff --git a/test/fast/Unit tests/nvm_write_nvmrc replaces .nvmrc instead of writing through it b/test/fast/Unit tests/nvm_write_nvmrc replaces .nvmrc instead of writing through it new file mode 100755 index 00000000..de35c903 --- /dev/null +++ b/test/fast/Unit tests/nvm_write_nvmrc replaces .nvmrc instead of writing through it @@ -0,0 +1,86 @@ +#!/bin/sh + +die () { echo "$@" ; cleanup ; exit 1; } + +cleanup() { + cd "${ORIG_PWD}" || : + PATH="${REAL_PATH:-${PATH}}" + nvm deactivate > /dev/null 2>&1 + rm -rf "${TEST_DIR-}" "${NVM_DIR}/${TEST_VERSION}" + unset TEST_DIR TEST_VERSION ORIG_PWD REAL_PATH SWAP_TARGET +} + +: nvm.sh +\. ../../../nvm.sh + +\. ../../common.sh + +ORIG_PWD="${PWD}" +TEST_VERSION='v0.2.4' +make_fake_node "${TEST_VERSION}" || die 'failed to create a fake node' + +TEST_DIR="${PWD}/nvm_write_nvmrc_replace_tmp" +mkdir -p "${TEST_DIR}/project" "${TEST_DIR}/bin" "${TEST_DIR}/dir" || die 'failed to create test dirs' + +# stand-ins for `tee` and `mv` that turn .nvmrc into a symlink just before the real command runs, +# as another user who can write the directory could +for CMD in tee mv; do + printf '%s\n' '#!/bin/sh' \ + 'rm -rf "${PWD}/.nvmrc" && ln -s "${SWAP_TARGET}" "${PWD}/.nvmrc" || exit 99' \ + 'PATH="${REAL_PATH}"' \ + "exec ${CMD} \"\$@\"" > "${TEST_DIR}/bin/${CMD}" + chmod +x "${TEST_DIR}/bin/${CMD}" +done + +cd "${TEST_DIR}/project" || die 'failed to enter the project dir' +export REAL_PATH="${PATH}" + +# 1. a symlink to a file, swapped in after the check, does not get written through +echo 'KEEPME' > "${TEST_DIR}/target" +export SWAP_TARGET="${TEST_DIR}/target" +echo 'v0.0.1' > .nvmrc +PATH="${TEST_DIR}/bin:${REAL_PATH}" nvm_write_nvmrc "${TEST_VERSION}" > /dev/null 2>&1 +PATH="${REAL_PATH}" +[ "$(cat "${TEST_DIR}/target")" = 'KEEPME' ] || die "expected a symlink swapped in after the check to not be written through; target is now \`$(cat "${TEST_DIR}/target")\`" + +# 2. nor does a symlink to a directory get the file moved into it +rm -rf .nvmrc +export SWAP_TARGET="${TEST_DIR}/dir" +echo 'v0.0.1' > .nvmrc +PATH="${TEST_DIR}/bin:${REAL_PATH}" nvm_write_nvmrc "${TEST_VERSION}" > /dev/null 2>&1 +PATH="${REAL_PATH}" +[ -z "$(ls -A "${TEST_DIR}/dir")" ] || die "expected nothing to be written into a symlinked directory; found \`$(ls -A "${TEST_DIR}/dir")\`" +[ "$(cat "${TEST_DIR}/target")" = 'KEEPME' ] || die 'expected the target to still be unchanged' + +# 3. a hard link to .nvmrc keeps its content +rm -rf .nvmrc +echo 'KEEPME' > "${TEST_DIR}/hardlinked" +ln "${TEST_DIR}/hardlinked" .nvmrc || die 'failed to create the hard link' +try_err nvm_write_nvmrc "${TEST_VERSION}" +[ "${CAPTURED_EXIT_CODE}" = 0 ] || die "expected exit code 0; got ${CAPTURED_EXIT_CODE}: ${CAPTURED_STDERR}" +[ "$(cat .nvmrc)" = "${TEST_VERSION}" ] || die "expected .nvmrc to contain ${TEST_VERSION}; got \`$(cat .nvmrc)\`" +[ "$(cat "${TEST_DIR}/hardlinked")" = 'KEEPME' ] || die "expected a hard link to .nvmrc to be left alone; got \`$(cat "${TEST_DIR}/hardlinked")\`" + +# 4. a new .nvmrc gets its mode from the umask +rm -f .nvmrc +( + umask 027 + nvm_write_nvmrc "${TEST_VERSION}" > /dev/null 2>&1 +) || die 'expected writing a new .nvmrc to succeed' +MODE="$(ls -l .nvmrc | cut -c1-10)" +[ "${MODE}" = '-rw-r-----' ] || die "expected .nvmrc to have mode -rw-r----- under umask 027; got ${MODE}" + +# 5. a directory named .nvmrc is an error, and nothing is moved into it +rm -f .nvmrc +mkdir .nvmrc +try_err nvm_write_nvmrc "${TEST_VERSION}" +[ "${CAPTURED_EXIT_CODE}" = 3 ] || die "expected exit code 3 for a directory .nvmrc; got ${CAPTURED_EXIT_CODE}" +[ "${CAPTURED_STDERR}" = "Warning: Unable to write version number (${TEST_VERSION}) to .nvmrc" ] || die "expected the unable-to-write warning; got \`${CAPTURED_STDERR}\`" +[ -z "$(ls -A .nvmrc)" ] || die "expected nothing to be moved into a directory .nvmrc; found \`$(ls -A .nvmrc)\`" +rmdir .nvmrc + +# 6. no temporary directories are left behind +LEFTOVER="$(ls -A "${NVM_DIR}" | grep '^\.nvmrc\.')" +[ -z "${LEFTOVER}" ] || die "expected no temporary directories left in \$NVM_DIR; found \`${LEFTOVER}\`" + +cleanup