From 2569dddb3353f673bb5d35afca09c1cd36a3fffe Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Mon, 17 Aug 2026 08:37:58 -0400 Subject: [PATCH] fix: Use the generic access row for another user's personal document The owner's name is not sent to other members, so interpolating it risked rendering an empty label. Only the owner sees the personal row now. Co-Authored-By: Claude Opus 5 (1M context) --- .../Sharing/Document/AccessControlList.tsx | 18 +++--------------- app/models/Document.ts | 3 --- shared/i18n/locales/en_US/translation.json | 2 -- 3 files changed, 3 insertions(+), 20 deletions(-) diff --git a/app/components/Sharing/Document/AccessControlList.tsx b/app/components/Sharing/Document/AccessControlList.tsx index bd76fdd21a..45bd603bef 100644 --- a/app/components/Sharing/Document/AccessControlList.tsx +++ b/app/components/Sharing/Document/AccessControlList.tsx @@ -173,27 +173,15 @@ export const AccessControlList = observer( invitedInSession={invitedInSession} /> )} - {document.isPersonal ? ( + {document.isPersonalToMe ? ( } - title={ - document.isPersonalToMe - ? t("Personal") - : t("Personal to {{ name }}", { - name: document.personalOwner?.name, - }) - } - subtitle={ - document.isPersonalToMe - ? t("Only people you invite have access") - : t("Only people {{ name }} invites have access", { - name: document.personalOwner?.name, - }) - } + title={t("Personal")} + subtitle={t("Only people you invite have access")} /> ) : ( User) - personalOwner: User | undefined; - /** * The collection that this document belongs to. */ diff --git a/shared/i18n/locales/en_US/translation.json b/shared/i18n/locales/en_US/translation.json index 54c84904d2..28ec445f73 100644 --- a/shared/i18n/locales/en_US/translation.json +++ b/shared/i18n/locales/en_US/translation.json @@ -583,9 +583,7 @@ "Can view": "Can view", "Everyone in the collection": "Everyone in the collection", "You have full access": "You have full access", - "Personal to {{ name }}": "Personal to {{ name }}", "Only people you invite have access": "Only people you invite have access", - "Only people {{ name }} invites have access": "Only people {{ name }} invites have access", "Other people": "Other people", "Other workspace members may have access": "Other workspace members may have access", "This document may be shared with more workspace members through a parent document or collection you do not have access to": "This document may be shared with more workspace members through a parent document or collection you do not have access to",