From 5ebbfc6e103ac37293268ffd4506fdbff44df05a Mon Sep 17 00:00:00 2001 From: Apoorv Mishra Date: Thu, 7 Sep 2023 17:59:14 +0530 Subject: [PATCH] fix: self review --- server/storage/files/LocalStorage.ts | 6 ++++++ server/storage/files/S3Storage.ts | 5 ----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/server/storage/files/LocalStorage.ts b/server/storage/files/LocalStorage.ts index a7e0ae5fb3..7d00f33321 100644 --- a/server/storage/files/LocalStorage.ts +++ b/server/storage/files/LocalStorage.ts @@ -10,6 +10,7 @@ import { import { mkdir, unlink } from "fs/promises"; import path from "path"; import { Readable } from "stream"; +import invariant from "invariant"; import JWT from "jsonwebtoken"; import env from "@server/env"; import Logger from "@server/logging/Logger"; @@ -97,6 +98,11 @@ export default class LocalStorage extends BaseStorage { }; public getFileStream(key: string) { + invariant( + env.FILE_STORAGE_LOCAL_ROOT_DIR, + "FILE_STORAGE_LOCAL_ROOT_DIR is required" + ); + const filePath = path.join(env.FILE_STORAGE_LOCAL_ROOT_DIR, key); return createReadStream(filePath); } diff --git a/server/storage/files/S3Storage.ts b/server/storage/files/S3Storage.ts index 9639527d64..41c42d94cd 100644 --- a/server/storage/files/S3Storage.ts +++ b/server/storage/files/S3Storage.ts @@ -175,11 +175,6 @@ export default class S3Storage extends BaseStorage { } public async getFileBuffer(key: string) { - invariant( - env.AWS_S3_UPLOAD_BUCKET_NAME, - "AWS_S3_UPLOAD_BUCKET_NAME is required" - ); - const stream = this.getFileStream(key); return new Promise((resolve, reject) => { const chunks: Buffer[] = [];