From e032bb5ab8ace06329d131ce301af5d847d4f5ff Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Sun, 15 Sep 2024 21:27:07 -0400 Subject: [PATCH] Check document access before creating @mention notification --- .../tasks/RevisionCreatedNotificationsTask.ts | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/server/queues/tasks/RevisionCreatedNotificationsTask.ts b/server/queues/tasks/RevisionCreatedNotificationsTask.ts index 5ea3603215..b7ae1755c8 100644 --- a/server/queues/tasks/RevisionCreatedNotificationsTask.ts +++ b/server/queues/tasks/RevisionCreatedNotificationsTask.ts @@ -8,6 +8,7 @@ import Logger from "@server/logging/Logger"; import { Document, Revision, Notification, User, View } from "@server/models"; import { DocumentHelper } from "@server/models/helpers/DocumentHelper"; import NotificationHelper from "@server/models/helpers/NotificationHelper"; +import { authorize } from "@server/policies"; import { RevisionEvent } from "@server/types"; import BaseTask, { TaskPriority } from "./BaseTask"; @@ -52,7 +53,8 @@ export default class RevisionCreatedNotificationsTask extends BaseTask { + try { + const document = await Document.findByPk(model.id, { + userId: user.id, + }); + authorize(user, "read", document); + return true; + } catch (err) { + return false; + } + }; + public get options() { return { priority: TaskPriority.Background,