* Initial plan
* Split group notifications into separate background task
- Created GroupMentionedInCommentNotificationsTask for handling group mention notifications
- Updated CommentCreatedNotificationsTask to delegate group notifications
- Updated CommentUpdatedNotificationsTask to delegate group notifications
- Added comprehensive tests for the new task
- Improved scalability with batch processing (10 members per batch)
- Enhanced resilience by isolating group notification failures
Co-authored-by: tommoor <380914+tommoor@users.noreply.github.com>
* Optimize database queries in GroupMentionedInCommentNotificationsTask
- Batch fetch users instead of individual queries for better performance
- Add defensive comment explaining duplicate mentions check
- Create user map for O(1) lookups within batch
Co-authored-by: tommoor <380914+tommoor@users.noreply.github.com>
* Add comment explaining concurrency control in batch processing
Co-authored-by: tommoor <380914+tommoor@users.noreply.github.com>
* Remove unnecessary document loading - use event properties directly
- Removed Document import and document loading query
- Use event.documentId and event.teamId directly
- Reduces database queries and improves performance
- canUserAccessDocument loads document internally when needed
Co-authored-by: tommoor <380914+tommoor@users.noreply.github.com>
* Fix TypeScript errors and test failures
- Fixed test: buildComment requires documentId parameter
- Fixed type error: use nullish coalescing for group.actorId ?? event.actorId
- Fixed type definition: use Omit<CommentEvent, "data"> to avoid type conflicts
- All TypeScript errors resolved
Co-authored-by: tommoor <380914+tommoor@users.noreply.github.com>
* test
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tommoor <380914+tommoor@users.noreply.github.com>
Co-authored-by: Tom Moor <tom@getoutline.com>
* wip
* Implementation complete
* tidying
* test
* Address feedback
* Remove duplicative retry logic from UpdateDocumentsPopularityScoreTask.
Now that we're split across many runs this is not neccessary
* Refactor to subclass, config to instance
* Refactor BaseTask to named export
* fix: Missing partition
* tsc
* Feedback
* Add disableMentions option for groups
- Add database migration to add disableMentions column to groups table
- Update server-side Group model with new field
- Add disableMentions to group create/update API schemas and endpoints
- Update client-side Group model with new field
- Add checkbox to EditGroupDialog for disabling mentions
- Filter out groups with disableMentions=true from mention suggestions
- Prevent notifications for groups with disabled mentions
* Fix TypeScript error in GroupDialogs checkbox handler
- Add properly typed handleDisableMentionsChange callback
- Replace inline onChange handler with typed callback
- Fixes TS2339 error: Property 'checked' does not exist on type 'EventTarget'
* UI tweaks
* Add groups to suggestions endpoint
* Remove mentionableData
---------
Co-authored-by: codegen-sh[bot] <131295404+codegen-sh[bot]@users.noreply.github.com>
Co-authored-by: Tom Moor <tom@getoutline.com>
* add group mentions
* group mention functionality
* add notification test
* fix: Group icon in mention menu
* language
* toast message
* fix: Group icon in mention menu light mode color
---------
Co-authored-by: Tom Moor <tom@getoutline.com>
* fix: probably copy-pasted function description
* fix: userIdsMentioned was always empty
* add: NotificationEventType.ResolveComment
* move: split handler for "mentioned" vs. "resolved"
The recipients for "resolved" will include more people (creator, repliers, mentioned), so it's easier to just split the handler than trying to augment it.
* implement: handleResolvedComment
* clone: CommentMentionedEmail as CommentResolvedEmail
Changes coming up in next commit...
* implement: CommentResolvedEmail
* Fix "New Comment↓" incorrectly showing in Resolved
## Repro 1 (with production code)
1. In a list of long resolved comments, scroll up and select the first one.
2. From another account, resolve another comment. The hint appears.
## Repro 2 (with production code)
1. Select Most-Recent, then Resolved.
2. F5. It's scrolled all the way to the bottom.
## Repro 3 (after this PR)
1. Click on the notification when someone resolved a comment. The screen jumps to "Resolved" + showing hint unnecessarily.
## Fix
The scrolling and hint was meant for Most Recent only, but missed out this case since "Resolve" is not part of the enum.
* Better sentences
* Refactor "mentions + author" calculation
* Remove unnecessary check
The resolver is already added to `userIdsNotified` from the start, so no point checking it again here.