* fix: Sanitize the embed toolbar link and anchor embed url matchers
The "Open" link in an embed's bottom bar wrote the node's href attribute
into the DOM without passing it through sanitizeUrl, so a javascript: url
in that attribute ran on click.
Two embed matchers, and the regex built from a team's embed integration
settings, were not anchored, so a javascript: url that contained a
supported url further along still matched an embed and reached that link.
* fix: Only emit a list style the editor renders
The listStyle attribute is written into a list-style-type declaration.
Its validator returned a boolean rather than throwing, which Prosemirror
ignores, so any string reached the style attribute and a crafted value
appended further CSS declarations to the element.
* fix: Sanitize the image urls carried in a mention's unfurl attribute
The unfurl attribute holds a cached copy of the unfurl response on the
node, and is used whenever the store has no live entry for the url. Its
favicon and avatar urls were written to an img src unchanged, so a
crafted mention made every reader's browser request a chosen host.
* fix: Render a heading level and highlight color that cannot be used
Both attributes are used unchecked when the node is rendered. rgba()
throws for a color it cannot parse, and a level outside of 1-6 produces
an invalid tag name, so either one stopped the whole document rendering
in the browser and on the server. The heading level also reached a
repeat() in the Markdown serializer, unbounded.
Fall back when rendering rather than when reading, so that a value
written through collaborative editing, which does not run the attribute
validators, is covered too.
* fix: Table cell background pasted as text highlight
A background color styled on a table cell by an external application was
dropped, while the matching background on the span inside the cell became a
highlight on the text – rendered yellow, as the color did not match a preset.
Cell backgrounds are now read from pasted HTML onto the cell, and only a
background that matches a highlight preset creates a highlight mark.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* fix: Skip unpainted ancestors when comparing backgrounds
An ancestor with a transparent or unparseable background ended the search, so
shading painted higher up – such as on a table cell – was missed.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
* feat: Add onNotice callback to decouple shared editor from toast library
Shared editor code called sonner's toast directly. Introduce an onNotice
callback (defaulting to a toast) so the shared editor stays agnostic of the
host app's notification library.
* Add lint rule to prevent regression
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* Reduce server memory usage and add container memory best practices
Profiling a full-service boot showed ~300MB RSS per service process, much
of it client-only dependencies pulled into the server module graph, and no
heap limits applied in containers:
- Import date-fns locales individually rather than via the locale index,
which loaded all ~90 locales into every process
- Load @sentry/react dynamically in insertFiles so the browser Sentry SDK
stays out of the server-side editor graph
- Replace class-validator isHexColor with the existing validateColorHex
in the Highlight mark
- Extract icon names into a standalone IconNames module so server-side
schema validation no longer imports Font Awesome icon packs, with a
test to keep it in sync with IconLibrary
- Require S3Storage lazily so the AWS SDK and native CRT binding are only
loaded when S3 file storage is configured
- Default each forked service process to a V8 heap limit derived from the
cgroup memory constraint, preventing several processes from together
committing more memory than the container allows
- Cap glibc malloc arenas in the Docker image to reduce resident memory
fragmentation in multi-threaded processes
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa
* Require both file storage backends lazily for consistency
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa
* Load AWS SDK via dynamic imports compatible with test environment
Requiring the storage TypeScript modules lazily broke under Vitest, which
cannot resolve require() of source files and does not apply vi.mock to
bare requires. Move the laziness into S3Storage instead: the module is
imported statically, and the AWS SDK packages are loaded with dynamic
imports on first use, including deferred creation of the S3 client.
Also address review feedback: handle rejection of the dynamic Sentry
import, and warn when the minimum per-process heap limit exceeds the
memory budget of the container.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa
* Consolidate S3 SDK loading into a single lazy accessor
The commands are loaded together with the client in getS3() rather than
as separate dynamic imports per method. The global S3Client test mock is
now a class, as a mock function is not constructable when reached through
a dynamic import.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa
---------
Co-authored-by: Claude <noreply@anthropic.com>
* chore(deps-dev): bump oxlint-tsgolint from 0.14.2 to 0.22.1
Bumps [oxlint-tsgolint](https://github.com/oxc-project/tsgolint) from 0.14.2 to 0.22.1.
- [Release notes](https://github.com/oxc-project/tsgolint/releases)
- [Commits](https://github.com/oxc-project/tsgolint/compare/v0.14.2...v0.22.1)
---
updated-dependencies:
- dependency-name: oxlint-tsgolint
dependency-version: 0.22.1
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* chore: Switch tsconfig to bundler resolution for tsgolint 0.22.1
oxlint-tsgolint 0.22.1 removed support for moduleResolution=node10
(the alias for "node"). Switch to "bundler" with resolvePackageJsonExports
disabled so packages whose exports field omits a types condition still
resolve. Update markdown-it type imports to sub-paths since the package's
.d.mts entry only re-exports a subset of named types.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix: Resolve type-aware lint errors caught by tsgolint 0.22.1
oxlint-tsgolint 0.22.1 catches several await-thenable, no-floating-promises,
and no-meaningless-void-operator cases the prior 0.14.2 missed:
- Drop redundant inner `await` from Promise.all([await x, await y]) call sites
so the array entries are real Promises rather than already-resolved values.
- Replace Promise.all wrappers around synchronous presenters (presentEvent,
presentTemplate, presentPublicTeam) with plain map / direct calls.
- Wrap non-promise branches of ternaries inside Promise.all with
Promise.resolve so the array remains thenable across both arms.
- Add `void` to the unawaited provider.connect() in the auth-failed retry
chain, and remove `void` from the disconnect() call which returns void.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Moor <tom@getoutline.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Plumbed `dictionary` props through editor components, menus, extensions,
and nodes. Replaces with `useTranslation()` in React contexts and direct
`t` imports from i18next elsewhere.
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
* chore: Update editor generics
* fix: Address PR review on editor generics
- Restore null-guard on Link click handler so anchors aren't inert when no onClickLink is provided
- Mark onClickLink optional in LinkOptions and openLink command to match runtime
- Remove dead `collapsed` option from HeadingOptions
- Make ToggleBlock dictionary optional and restore optional-chained access for server-side schema instantiation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
* feat: table cell bgcolor
* fix: review
* fix: cleanup
* fix: new color picker
* fix: transparentize bg preset colors
* fix: show selected color in color list
* fix: pass active color to picker
* fix: make color picker command agnostic
* fix: tsc
* fix: table row and col background menu
* getColorSetForSelectedCells
* toggleCellBackground to toggleCellSelectionBackground
* cellHasBackground to cellSelectionHasBackground
* useless spread
* presetColors
* get rid of hasMultipleColors
* get rid of customColor
* be explicit in passing color
* alpha controls
* remove new highligh command
* DRY DottedCircleIcon
* restore ff fix
* merge createCellBackground into updateCelllBackground
* default color
* Merge
---------
Co-authored-by: Tom Moor <tom@getoutline.com>
* fix: port link related commands to work for image selection
* fix: selection
* fix: click img to open link
* fix: hover preview for image with link
* cleanup: hasLink not needed
* fix: we've img wrapped in an `a` tag now, so this is no more required
* fix: cover all edge cases
* fix: cleanup
* fix: zoom in action button in edit mode
* fix: separator div instead of gap
* fix: toolbar refactor
* fix: back button press
* fix: import
* fix: revert
* fix: enum
* fix: onClick on item
* fix: selection at end after link
* fix: show linkbar if link present
* fix: ReturnIcon
* fix: onClickBack
* fix: TOOLBAR -> Toolbar
* fix: show zoom in icon even when selected
* fix: isInlineMarkActive
* fix: jsdoc
* yarn.lock
* Revert "yarn.lock"
This reverts commit 5f44e5e017.
* fix: yarn.lock
* fix: link editor closes upon zoom in click action
* Update shared/editor/queries/isMarkActive.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update shared/editor/queries/getMarkRange.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update shared/editor/components/Image.tsx
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update app/editor/components/LinkEditor.tsx
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* fix: prevent toolbar state reset
* fix: tooltip
* fix: copilot
* fix: i18n, misuse of attrs
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Tom Moor <tom@getoutline.com>
* fix: quick refactor
* fix: `state.selection.to` is equivalent to mark's end pos in this case
* fix: get rid of paste handler
* fix: inline actions
* fix: remove and inline enum
* feat: enable commenting on image nodes
* chore: make anchorPlugin a top level plugin
* fix: className
* fix: review
* fix: tsc
* fix: checks
* Tweak menu order to match
---------
Co-authored-by: Tom Moor <tom@getoutline.com>
* Fix autolink when text is within inline code marks
- Use isInCode with inclusive: true option to properly detect when cursor is within inline code marks
- Prevents autolink from converting URLs to links when typing within backticks
- Fixes issue #10321
Co-authored-by: Tom Moor <tom@getoutline.com>
* Update Link.tsx
---------
Co-authored-by: codegen-sh[bot] <131295404+codegen-sh[bot]@users.noreply.github.com>
Co-authored-by: Tom Moor <tom@getoutline.com>
* Upgrade @typescript-eslint dependencies from v6.21.0 to v8.33.0
- Updated @typescript-eslint/eslint-plugin from ^6.21.0 to ^8.33.0
- Updated @typescript-eslint/parser from ^6.21.0 to ^8.33.0
- Tested linting functionality to ensure compatibility
- This brings the latest TypeScript ESLint features and bug fixes
* lint
* tsc
---------
Co-authored-by: codegen-sh[bot] <131295404+codegen-sh[bot]@users.noreply.github.com>
Co-authored-by: Tom Moor <tom@getoutline.com>