414 Commits
Author SHA1 Message Date
Tom Moor ee3c88bc14 fix: Standardize media resizing, add aspect ratio lock control (#14677)
* fix: Allow PDF embed width and height to change independently

Adds an aspect ratio lock toggle to the media dimension toolbar for PDF
embeds, renders PDFs at their stored aspect ratio, and keeps that ratio
when drag resizing.

* feat: Add corner resize handles to PDF embeds and persist aspect ratio lock

Stores the lock as an optional attachment attribute, where unset means
locked, so side handles change only the width of unlocked PDFs.

* feat: Consistent resize handles for images, videos, PDFs and embeds

All media get side, bottom and corner handles driven by one lock rule.
Images and videos stay locked. PDFs and embeds can be unlocked to resize
each axis independently.

* feat: Show width, height and lock in the embed toolbar

* feat: Start embeds unlocked and step media dimensions with arrow keys

Embeds start with an unlocked aspect ratio so full-width embeds can still
be made taller, while PDFs start locked. Up and down arrows step the
dimension inputs by 1, or 10 with shift.

* fix: Align the aspect ratio padlock with the dimension digits

* fix: Move the aspect ratio lock closer to the dimension inputs

* fix: Show the aspect ratio lock state in its tooltip
2026-11-21 11:33:02 -05:00
Tom Moor a46968c3f4 feat: Hover menu to switch mentions between inline and card display (#14588)
* feat: Show a display menu on hover for mentions that can be cards

Mentions that can display as a card show an overflow button on hover,
inside the end of the pill or in the top corner of the card. The button
opens a menu to switch between the mention and card display, which
replaces the selection toolbar for these mentions.

* fix: Resolve the mention position on click and hide the button on scroll

The menu looks up the mention position when an item is chosen, as edits
by collaborators can move it while the menu is open. The button follows
the mention when content above it changes and hides when a table is
scrolled.

* feat: Show the mention display button for a selected mention

The button shows for the selected mention as well as the hovered one, so
keyboard users can reach it. Touch devices show it for the selected mention
only. Only the button takes the pointer, so the fade does not block clicks
on short mentions.
2026-11-19 18:05:06 -05:00
Tom Moor 49aee74190 feat: Add filtering to tables in the editor (#14625)
* feat: Add filtering to tables in the editor

* Show the column filter button on header hover in edit mode

* Keep the filter button shown while its menu is open

* Move focusEditor to its own module

* Anchor the filter menu to the filter button

* Address review feedback on table filtering

* Show the filter button background while its menu is open

* Always show the filter button background with its icon

* Remove value counts and hide Clear when there is no filter

* Translations

* placeholder
2026-11-18 22:37:15 -05:00
Tom Moor aa454033ec fix: Keep callouts and rules nested when serialized to Markdown (#14528)
* fix: Keep notices and rules nested in lists and quotes when serialized to Markdown

* fix: Keep the blank line above notices and rules, written per line
2026-11-11 08:09:35 -05:00
Tom MoorandClaude f680d5dec9 feat: Display links, documents and collections as preview cards (#14511)
* feat: Display links as preview cards

Adds a display attribute to mentions so a link can render either inline
or as a card with image, title and description from its unfurl. Pasting
a URL offers a "Card" option, and selecting a link mention shows a
toolbar to switch between the two displays.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016MJXFgeTUqKhSTriUHfG3z

* feat: Arrow key selection, full width and Return for link cards

Cards fill the document width, hide the blank line below them, are selected
by the up and down arrow keys like images, and Return on a selected card
adds a paragraph below it.

* feat: Display document and collection mentions as cards

Document and collection mentions can be switched to a card from the
selection toolbar. Document cards show the summary, collection and the
first image larger than 100x100. Collection cards show the first line of
the description. On public shares the preview image is signed, as the
share page already signs the attachments of that document. Card images
are hidden until they load and removed if they fail.

* feat: Keep mention cards through Markdown

The card display is written as the link title, so URLs are not changed.
Document and collection cards are written as @ links to their id and
parsed back into mentions.

* refactor: Move mention cards to their own file

Document cards show the collection after the title instead of below it.

* fix: Address review feedback on mention cards

- Include the share id in the document card unfurl URL for root shares.
- Return on a card in a heading adds a paragraph.
- URL cards keep their URL in Markdown, and the server does not narrow
  their type.
- Unfurl results apply to the current node, not the node at first render.
- Collection card descriptions stop at the first line break.

* refactor: Reuse existing helpers for mention cards

- Sign the preview image with TextHelper.attachmentsToSignedUrls.
- Check document and collection ids with isUUID.
- Return lines from getFirstText without changing an input array.

* fix: Preserve JSON output for inline mentions

* refactor: Centralize mention selection classes

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-08 08:11:31 -05:00
Tom Moor 33a388f268 fix: Backspace and Delete do not remove emoji on Android (#14452) 2026-11-02 18:00:59 -05:00
Tom Moor a9428805c1 feat: Show code block toolbar on hover in read-only editors (#14432)
* feat: Show code block toolbar on hover in read-only editors

* fix: Keep hover toolbar while focused, use tap path on touch-only devices
2026-10-31 14:55:04 -04:00
Tom Moor a374ce9b46 fix: Viewers attributed as editors when their editor repairs remote changes (#14424)
* fix: Viewers attributed as editors when their editor repairs remote changes

* fix: Rescan after remote changes and assign block ids when parsing markdown

* chore: Import uuid as generateUuid in ToggleBlock

* refactor: Add RepairPlugin to repair only on local changes, checking remote changes for pending repairs

* fix: Assign block ids on the server so patches keep existing ids, keep unchanged mention ids

* fix: Store API edits in the editor's trailing node form
2026-10-30 22:27:31 -04:00
Tom Moor 04cafebea5 fix: Sticky table headers lag behind the scroll position (#14426)
Move the header row with a CSS scroll-driven animation so the browser updates it in the same frame as the scroll. Browsers without support keep the scroll listener.
2026-10-30 08:29:42 -04:00
Tom Moor 77c7521d3b fix: Arrow keys move the cursor into code block line numbers (#14388)
* fix: Arrow keys move the cursor into code block line numbers

* fix: ArrowLeft at the start of a code line hides the caret
2026-10-29 18:49:24 -04:00
Tom Moor 4eca029b05 feat: Keep code block collapse button visible at the bottom of the viewport (#14328) 2026-10-24 20:28:32 -04:00
Tom Moor 316a873d49 fix: Backspace and Delete do not remove line breaks in code blocks (#14319) 2026-10-24 18:17:33 -04:00
Tom Moor 33296fb974 chore: Add lint rule to require sanitizeUrl for href/src in toDOM (#14309)
* chore: Add lint rule to require sanitizeUrl for href/src in toDOM

* fix: Resolve sanitizer by binding and only match literal setAttribute names
2026-10-24 11:16:12 -04:00
Tom Moor 0fc91c3da8 fix: Skip pasted images without a src (#14287) 2026-10-24 10:02:48 -04:00
Tom Moor 695e973e6b feat: Allow tables inside notices (#14175)
* feat: Allow tables inside notices

Blend table, rule and code colors onto the notice background, keep table
scroll shadows inside the notice, hide full width for tables in notices,
and fit new table columns to the available width.

* fix: Leave room for table row controls in notices

* fix: Blend table grips onto the notice background

* fix: Derive notice content colors from the softer notice styles
2026-10-20 19:05:10 -04:00
Tom Moor 0853354daf feat: Show code block line numbers alongside line wrapping (#14170)
* feat: Show code block line numbers alongside line wrapping

Render line numbers as a widget at the start of each line so they align
with wrapped lines and stay fixed during horizontal scroll.

* fix: Keep line number gutter size inside table cells
2026-10-20 19:02:27 -04:00
Tom Moor 97cc147726 feat: Render Mermaid diagrams with Pele (#14126)
* feat: Render Mermaid diagrams with Pele

* fix: Translate empty diagram label

* fix: Prevent diagram flash when editors swap on load
2026-10-18 08:11:41 -04:00
Tom Moor bd49f85819 fix: Arrow up/down selects images like block nodes (#14119)
* fix: Arrow up/down selects images as block nodes, animate empty caption

* fix: Address review feedback on image arrow navigation and caption

- Check rendered display and visibility instead of attributes
- Keep navigation inside table cells
- Hide collapsed captions and remove min-height jump

* fix: Empty caption clipped in table cells

* Remove empty caption animation
2026-10-17 16:51:16 -04:00
Tom Moor 178e923cb7 feat: Add selection toolbar for video nodes (#14118)
* feat: Add selection toolbar for video nodes

* fix: Keep video caption on replace, download video as a file

* fix: Drop removed upload progress prop from video replace
2026-10-17 12:21:46 -04:00
Tom Moor 128c240405 Render uploads with the same component as the uploaded node (#14117)
* feat: Render uploading images and videos with their node component

* fix: Insert uploaded block nodes next to the paragraph instead of inside it

* fix: Insert dropped block nodes on the nearest side of the paragraph

* feat: Fade in uploaded images and videos from their placeholder

* feat: Preview the new image while it replaces an existing one

* fix: Keep the placeholder size and preload pasted images after upload

* fix: Move the selection off an image while an upload replaces it

* feat: Play uploaded videos from the local file in the uploading editor

* feat: Display uploaded images from the local file in the uploading editor

* feat: Soften image and video corners, round them fully when selected

* feat: Render uploading attachments with the attachment component

* feat: Show the file size of an attachment while it uploads

* feat: Show upload progress on the placeholder instead of a toast

* fix: Fade the content of an uploading file but not its progress bar

* fix: Keep the local file of an upload when its placeholder is mapped away

* chore: Simplify upload placeholder state and remove unused progress callback

* Remove test

* fix: Address review feedback on upload placeholders

Expose upload progress to assistive technology outside the inert placeholder, free local files when the editor state is replaced, reuse the fadeIn animation and move the video wrapper class to EditorStyleHelper.

* chore: Move image and PDF wrapper class names to EditorStyleHelper

* feat: Scale in an upload placeholder when it appears

* chore: Make the upload placeholder scale-in more subtle
2026-10-17 12:12:25 -04:00
Tom Moor f4c4018872 fix: Unfold toggle blocks when jumping to a comment (#14100)
* fix: Unfold toggle blocks when jumping to a comment

* fix: Reveal pending draft comment anchors in folded toggles
2026-10-15 21:40:53 -04:00
Tom MoorandClaude Opus 5.5 9e2565184e chore: Prune stale comments, TODOs, and type suppressions (#14092)
* chore: Remove unused lint disable directives

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Replace TODO type suppressions with typed code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Remove obsolete workaround comments in tests and MediaDimension

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Remove Tippy compatibility props from Tooltip

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Decouple DropdownMenu props from Tooltip and clarify sharing styles

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Remove stale retention TODOs from cleanup tasks

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Register relations synchronously and clarify workaround comments

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Replace Notion import TODOs with descriptive comments

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-10-15 08:54:37 -04:00
Tom Moor 19d0b337b9 fix: Backspace does not delete RTL text in table cells (#14054)
Table grip and insert widgets at the start of a cell made ProseMirror treat the
grip as the first block of the cell, so RTL deletion was always blocked. The
add row and column controls now also show above the grips while hovered.
2026-10-12 09:40:34 -04:00
Tom Moor e571208871 fix: Spelling, grammar, punctuation, and translation string errors (#14017)
* fix: Spelling, grammar, punctuation, and translation string errors

* fix: Remove duplicate period and comma splice from review feedback
2026-10-11 09:07:07 -04:00
Tom MoorandClaude Opus 4.7 c10a214075 Expanding drag handle to all root level block nodes (#12167)
* Expanding drag handle to all root level block nodes

* wip

* looking good

* wip

* fix, drag video nodes

* fix mermaid

* Hide drag handle when printing, adjust heading actions for handle gutter

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* rtl

* Passive scroll listener, avoid dispatch on teardown

* Guard drag handle from re-showing mid-drag, use semantic button

* Align drag handle to first line, hide on layout images, tidy heading controls

* Fix stale drag handle target and drag data, rebuild Mermaid in moved containers, remove unused styles

* Extract drag handle target resolution into DragTarget class

* Move drag handle styles from inline to global CSS

* Use EditorStyleHelper class names and named constants in drag handle, translate its label

* Hide drag handle on a table that holds the selection

* Remove opacity transition from drag handle

* Move heading anchor into drag handle slot when read-only

* Move drop cursor class name to EditorStyleHelper

* Add empty line above comments, document the rule in AGENTS.md

* drag handle

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-10-10 08:19:31 -04:00
Tom Moor 3503a1087f fix: Do not store viewer-specific document unfurls on URL mentions (#14004) 2026-10-09 17:48:52 -04:00
Tom Moor 6e6eaf6b69 fix: Guard node view positions after the view is destroyed (#13983)
* fix: Guard node view positions after the view is destroyed

ProseMirror returns undefined from getPos once a node view is destroyed,
but ComponentProps typed it as always returning a number. Async handlers,
such as the mention unfurl, could then call setNodeMarkup with an undefined
position and throw a RangeError.

Fixes OUTLINE-CLOUD-D9N

* Remove excessive test
2026-10-07 09:09:16 -04:00
Tom Moor 179d7dd7be fix: Improve table controls around merged cells (#13897)
* wip

* fix: Position grips in merged cells from the rendered layout

* fix: Only merge row and column selections that cover whole rows or columns

* perf: Find merged cell spans without scanning the table map

* refactor: Extract helpers for cells starting in a row or column
2026-09-27 13:10:43 -04:00
Tom Moor 4ed1665728 Do not auto-collapse a code block that is most of the document (#13815)
* Do not auto-collapse a code block that is most of the document

* Address review: keep collapseKey private, clarify comment
2026-09-20 13:46:58 -04:00
Tom Moor 143da3ff87 fix: Address review follow-ups for mapped editor decorations (#13762)
Treat checkbox list attribute changes as structural for id repair, keep
remote transactions on the rebuild path for table decorations, and map
column grip decorations through local inline edits.
2026-09-16 21:45:20 -04:00
Tom Moor 07aab19000 perf: Map editor decorations through inline edits instead of rebuilding (#13759)
* perf: Map editor decorations through inline edits instead of rebuilding

* fix: Repair missing block ids on first edit and keep remote edits on the rebuild path

* test: Add isInlineTransaction query tests
2026-09-16 20:44:03 -04:00
Tom Moor 11abb1c752 perf: Filter placeholder candidates before evaluating conditions (#13760) 2026-09-16 20:38:26 -04:00
Tom Moor c2c7200151 fix: Show notice type for list selections (#13721) 2026-09-13 15:42:34 -04:00
Tom MoorandClaude Fable 5.1 2507471f7c fix: Crash when image caption blurs during node view teardown (#13731)
* fix: Crash when image caption blurs during node view teardown

The caption blur handler ran setNodeMarkup using a position from a node
view that had already been destroyed, so the position was undefined and
ProseMirror threw a RangeError walking the document. Guard that the
position still resolves to the same node type before dispatching, for
both image and video captions.

Fixes OUTLINE-CLOUD-D6D

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hggmor4gWv2Ei4pMNeeMh4

* chore: Remove caption blur tests
2026-09-12 23:23:50 -04:00
Tom Moor 37e790a00d fix: Editor node drags show the sidebar document ghost (#13723)
Native drags (ProseMirror nodes leaving the editor, text, files) are
tracked by react-dnd as native item types. The sidebar drag placeholder
rendered a document row for any active drag, so dragging an editor node
past the editor edge showed an "Untitled" document ghost.

Also makes notice blocks non-draggable.
2026-09-10 22:06:13 -04:00
Tom MoorandClaude Fable 5.1 d3c8be2dbc feat: Alt/Mod-click toggle disclosure folds nested or all toggle blocks (#13678)
* feat: Alt-click toggle disclosure folds or unfolds all toggle blocks

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Alt toggles nested blocks, Mod toggles all blocks

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-06 00:45:30 -04:00
Tom Moor 2f78b54f30 fix: allow manual sizing of embedded PDFs (#13645) 2026-09-04 09:00:33 -04:00
964e709817 fix(editor): preserve toggle fold state across remote and local document edits (#13425)
* fix(editor): preserve toggle fold state across remote and local document edits

Fold state was re-derived from localStorage on every remote collaborative
transaction (and partially on local doc-changing ones), so a silently
failed Storage.set (quota exceeded, blocked storage) left a stale
{fold:true} and the next edit re-folded blocks the user had expanded —
the plugin seed from previous state was ineffective because
toggleFoldPluginKey.getState(newState) is always undefined during the
plugin's own apply.

Track a knownIds set alongside foldedIds and reconcile from the previous
plugin state (the second apply argument, which is reliable): existing
fold decisions are preserved verbatim and storage is only consulted for
toggle blocks seen for the first time.

Fixes #13424

* fix(editor): bound and harden toggle fold state persistence

Fold state was stored under a localStorage key per toggle block id with
no bound on how many keys accumulate, and a write that failed silently
(quota exceeded, storage unavailable) left a stale value that the next
edit would re-fold from. Two complementary changes:

- Storage falls back to session storage when a write to the primary
  interface fails at runtime, so values at least survive the browsing
  session; reads prefer the fallback copy while it is the most recent
  successful write, and successful writes drop it again.
- Toggle fold state now lives in an LRUCache mirrored to local storage,
  capping the number of stored keys and evicting the least recently used
  fold states first. The persisted key format is unchanged so fold state
  continues to sync across tabs via storage events.

Follow-up to #13425, addressing the underlying feedback in #13424.

Co-Authored-By: Claude <noreply@anthropic.com>

* docs: add development workflow best practices to CLAUDE.md

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(editor): rename persistTo option to storage in LRUCache

Rename the `persistTo` cache option to `storage` with a union type of
`"memory" | "localStorage" | "sessionStorage"` per review feedback.
The option is now required instead of optional; callers that only need
an in-memory cache pass `storage: "memory"`.

The private Storage instance field is renamed from `storage` to `store`
to avoid colliding with the new option name, and the mapping from
user-facing values to Storage constructor arguments is handled in
`hydrate()`.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(editor): eliminate redundant findBlockNodes scan in reconcileFoldState

The hot path for every local document change previously called
findBlockNodes twice on the same document — once in reconcileFoldState
and again in createDecorations.  Now reconcileFoldState collects the
blocks once and passes them directly to the decoration builder.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(editor): fix createDecorations signature to accept optional blocks parameter

The init and ACTION branches pass a NodeWithPos[] as the second argument,
which previously landed in the foldedIds parameter — a type error missed
due to missing tsc validation.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(editor): correct createDecorations argument order and NodeWithPos import

The createDecorations signature is (doc, foldedIds, blocks?) but both the
init and ACTION branches passed arguments in the old order (doc, blocks,
foldedIds). Because the Set is always truthy, the ?? fallback never fired
and buildDecorationsFromBlocks iterated over strings, crashing on
block.node.attrs. NodeWithPos is also not exported from findChildren.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(editor): address review feedback and fix CI

- Document the default-folded fallback for evicted blocks in the
  fold-state cache comment.
- Cast the Storage test mock through unknown so the type check passes.
- Provide in-memory web storage for the shared jsdom test project so the
  persistence tests run instead of crashing on a missing implementation.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(editor): scope storage fallback writes and drop unrelated changes

- Track keys mirrored to the storage fallback and clear only those,
  rather than clearing all of session storage
- Restore CLAUDE.md as a symlink to AGENTS.md
- Remove the unrelated scrollToNonce changes
- Make the fallback interface private and probe with a namespaced key

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Tom Moor <tom@getoutline.com>
2026-09-04 08:33:10 -04:00
Tom Moor 1c3d1ed0a9 enhance: Keep editor find panel open (#13643) 2026-09-04 08:01:03 -04:00
Tom Moor 0a3851edb3 fix: Keep expanded code blocks open after undo (#13600)
* fix: Preserve expanded code blocks after undo

* refactor: Rename used editor state parameter
2026-09-01 03:14:41 -04:00
Tom MoorandClaude Opus 5 f49b047648 feat: Convert @ prefixed Markdown links to mentions on server writes (#13403)
* checkpoint

* feat: Convert @ prefixed links to mentions on server Markdown writes

A Markdown link preceded by "@" now becomes a mention when brought in
through the documents API, MCP, or an import, so an exported mention
survives a round trip instead of degrading to a plain link.

The editor rule creates a generic mention carrying the href, and the
type of resource it points at is resolved by the plugin that recognizes
the URL through a new MentionProvider hook. Mentions of external
resources also serialize to their real URL rather than a mention:// URI,
so the reference resolves outside of Outline.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix: Escape values interpolated into rendered mention HTML

markdown-it leaves markup in a link label intact when html is disabled,
so the label and attributes are escaped before being written into the
tag.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-27 17:42:28 -04:00
Tom MoorandClaude Fable 5 662bad7108 Add heading numbering display preference for documents (#13522)
* Add heading numbering display preference for documents

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Fix isRemoteTransaction call for new signature on main

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Fix inTable detection for headings after a nested table

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Move from deco to pseudoclass

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-22 09:44:42 -04:00
Tom Moor 5ee3f1a5d9 perf: Refactor y-prosemirror loading (#13521)
* wip

* perf: Refactor y-prosemirror loading
2026-08-21 20:49:29 -04:00
Tom MoorandClaude Opus 5 46e4702406 fix: Ctrl+Left jumping to the start of a heading (#13494)
The heading node bound its caret-sync handler to Mod-ArrowLeft, which
Prosemirror maps to Ctrl on Linux and Windows. The handler moved the
selection to the start of the heading, replacing the word-left movement
that Ctrl+Left performs everywhere else.

Bind Cmd rather than Mod, so the handler only runs for the shortcut it
was written for.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-19 16:56:11 -04:00
Tom Moor 2a9ac3b456 Tighten how editor node and mark attributes are rendered (#13486)
* fix: Sanitize the embed toolbar link and anchor embed url matchers

The "Open" link in an embed's bottom bar wrote the node's href attribute
into the DOM without passing it through sanitizeUrl, so a javascript: url
in that attribute ran on click.

Two embed matchers, and the regex built from a team's embed integration
settings, were not anchored, so a javascript: url that contained a
supported url further along still matched an embed and reached that link.

* fix: Only emit a list style the editor renders

The listStyle attribute is written into a list-style-type declaration.
Its validator returned a boolean rather than throwing, which Prosemirror
ignores, so any string reached the style attribute and a crafted value
appended further CSS declarations to the element.

* fix: Sanitize the image urls carried in a mention's unfurl attribute

The unfurl attribute holds a cached copy of the unfurl response on the
node, and is used whenever the store has no live entry for the url. Its
favicon and avatar urls were written to an img src unchanged, so a
crafted mention made every reader's browser request a chosen host.

* fix: Render a heading level and highlight color that cannot be used

Both attributes are used unchecked when the node is rendered. rgba()
throws for a color it cannot parse, and a level outside of 1-6 produces
an invalid tag name, so either one stopped the whole document rendering
in the browser and on the server. The heading level also reached a
repeat() in the Markdown serializer, unbounded.

Fall back when rendering rather than when reading, so that a value
written through collaborative editing, which does not run the attribute
validators, is covered too.
2026-08-19 08:06:48 -04:00
Tom Moor 85ae9c2e0d fix: Code block with a null language makes the document impossible to open (#13482)
Fixes OUTLINE-CLOUD-C80
2026-08-18 19:23:29 -04:00
Tom MoorandClaude Opus 5 cc84d81aa5 fix: Correct open depths when unwrapping a single table cell on copy (#13479)
* fix: Correct open depths when unwrapping a single table cell on copy

The transformCopied prop replaced the slice content with the cell's content
but kept the original open depths, which still counted the removed table,
row, and cell levels. The resulting slice claimed to be open deeper than its
content, so any drag of a selection made inside a table cell threw in
dropPoint as the drop cursor walked into it.

Fixes OUTLINE-CLOUD-99J

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix: Unwrap single header cells on copy too

Header cells use the header_cell table role, so they never matched the
single-cell check and kept the table wrapper on copy.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-18 23:14:29 +00:00
Tom MoorandClaude Opus 5 eaad1a71dc React SSR editor nodes (#13113)
* Render React node views in server-side HTML export

Passes nodeViews to the headless EditorView used for export so that nodes
with a React component render with it, matching the editor, and falling
back to toDOM when a component cannot render server-side.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Let nodes opt out of component rendering in static HTML

Replaces the hardcoded set of node names in the server nodeViews factory with
an allowComponentInStaticHTML getter on Extension, so a node declares the
behavior alongside its own definition rather than in a server file that does
not know about it.

Mention opts out: its component requires stores and a router, so it always
threw and fell back to toDOM, at the cost of a React render, an exception and
a log line per node. A document with 100 mentions now exports in ~12ms rather
than ~25ms and emits no warnings.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Yield one less macrotask turn when flushing React effects

Only two turns are needed: the first flushes passive effects, the second fires
Frame's own setTimeout(0) whose setState commits the iframe. The third turn
absorbed nothing that the components produce.

Each turn is roughly a millisecond of idle time held inside the render lock, on
every export — including plain documents, share page SSR and notification
emails — so dropping it takes a small export from ~6ms to ~4ms.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-16 16:36:13 -04:00
Tom Moor a59a01cffe fix: Serialize external mentions as links in exported markdown (#13459)
* fix: Serialize external mentions as links in exported markdown

GitHub issue, pull request and project mentions carry the real URL in
`href`, but always serialized to a mention:// reference that cannot be
resolved outside of Outline. Write a plain link instead when the
commonMark serializer option is set, and set that option on the paths
where markdown leaves the platform – document and revision export, zip
exports, and the public share markdown response.

* Sanitize external mention url before navigation
2026-08-16 14:14:20 -04:00
Tom Moor cdc10b4564 fix: Crash when a remote edit arrives during a column resize (#13452)
Every remote change is applied as a full document replacement, which
invalidates the column resize handle while the drag is still active.
Releasing the pointer then resolved position -1 and threw.

Cancel the drag when the handle no longer points at a cell.

Fixes OUTLINE-CLOUD-B3R
2026-08-15 20:25:51 -04:00