Commit Graph
3176 Commits
Author SHA1 Message Date
Tom Moor 53a1287671 fix: li nested li 2026-07-19 15:57:08 -04:00
Tom Moor 5386d689da perf: Refactor to run boot migration check as separate process (#13049)
* perf: Refactor to run boot migration check as separate process

* Apply suggestions from code review
2026-07-19 11:36:14 -04:00
Tom Moor 24b5a0a17c feat(mcp): Add available icon names as resource (#13048)
* feat(mcp): Add available icon names as resource

* tests
2026-07-19 08:15:32 -04:00
Tom Moor 2e22912477 feat(MCP): Return public share urls (#13043)
* feat(MCP): Return public share urls

* ordering
2026-07-18 19:04:48 -04:00
Tom MoorandClaude Fable 5 24f95cadc3 perf: Reduce server memory usage and add container memory best practices (#13042)
* Reduce server memory usage and add container memory best practices

Profiling a full-service boot showed ~300MB RSS per service process, much
of it client-only dependencies pulled into the server module graph, and no
heap limits applied in containers:

- Import date-fns locales individually rather than via the locale index,
  which loaded all ~90 locales into every process
- Load @sentry/react dynamically in insertFiles so the browser Sentry SDK
  stays out of the server-side editor graph
- Replace class-validator isHexColor with the existing validateColorHex
  in the Highlight mark
- Extract icon names into a standalone IconNames module so server-side
  schema validation no longer imports Font Awesome icon packs, with a
  test to keep it in sync with IconLibrary
- Require S3Storage lazily so the AWS SDK and native CRT binding are only
  loaded when S3 file storage is configured
- Default each forked service process to a V8 heap limit derived from the
  cgroup memory constraint, preventing several processes from together
  committing more memory than the container allows
- Cap glibc malloc arenas in the Docker image to reduce resident memory
  fragmentation in multi-threaded processes

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa

* Require both file storage backends lazily for consistency

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa

* Load AWS SDK via dynamic imports compatible with test environment

Requiring the storage TypeScript modules lazily broke under Vitest, which
cannot resolve require() of source files and does not apply vi.mock to
bare requires. Move the laziness into S3Storage instead: the module is
imported statically, and the AWS SDK packages are loaded with dynamic
imports on first use, including deferred creation of the S3 client.

Also address review feedback: handle rejection of the dynamic Sentry
import, and warn when the minimum per-process heap limit exceeds the
memory budget of the container.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa

* Consolidate S3 SDK loading into a single lazy accessor

The commands are loaded together with the client in getS3() rather than
as separate dynamic imports per method. The global S3Client test mock is
now a class, as a mock function is not constructable when reached through
a dynamic import.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-07-18 18:34:32 -04:00
Tom Moor aa7a2c16dc fix: Improve handling of files not found in remote bucket (#13039)
* fix: Improve handling of files not found in remote bucket

* feedback
2026-07-18 13:22:51 -04:00
Tom Moor d3182686ed Add search_queries cleanup job to match event log retention (#13035)
* Add search_query cleanup job to match event log retention

* fix: findAllInBatches to use key based pagination rather than offset
2026-07-18 12:39:55 -04:00
Tom Moor 215793bbc9 Inline small images into exported HTML (#13036) 2026-07-18 11:45:34 -04:00
Tom MoorandClaude Opus 4.8 533efdfcfe fix: OIDC 502 on sign-in from oversized id_token cookie (#12986) (#12995)
* fix: OIDC 502 on sign-in from oversized id_token cookie (#12986)

Storing the full OIDC id_token in the `oidcIdToken` cookie inflated the
sign-in response headers enough to exceed reverse proxy buffers, causing a
502 Bad Gateway. Store the id_token server-side in Redis keyed by a short
session identifier and keep only that identifier in the cookie, preserving
spec-compliant RP-initiated logout via `id_token_hint`.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix: Make OIDC logout token persistence best-effort

A Redis failure when storing or reading the logout id_token_hint should not
block sign-in or logout; fall back to omitting the hint instead.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* docs

* refactor: Extract portable LogoutTokenStore for provider logout hints

Move the cookie-referenced, Redis-backed logout token persistence out of the
OIDC router into a provider-agnostic `LogoutTokenStore`. Any auth provider that
supports provider-initiated logout can now persist and consume a logout hint via
`new LogoutTokenStore(providerId)` without duplicating the cookie/Redis/error
handling. The OIDC-specific end-session URL construction stays in the router.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-18 10:24:12 -04:00
Tom MoorandClaude Opus 4.8 a054809b51 Use full keyspace for email verification codes (#13031)
* Use full keyspace for email verification codes

Email verification codes were generated with randomInt(100000, 1000000),
which can never produce a value below 100000. That excluded every code
with a leading zero — shrinking the keyspace from 1,000,000 to 900,000
and letting an attacker assume the first digit is never zero. It also
made the existing padStart(6, "0") dead code.

Draw uniformly from the full 0–999999 range and rely on padStart to
render leading zeros, restoring the full six-digit keyspace. Add tests
covering the six-digit invariant across many samples and the presence of
leading-zero codes.

* Simplify verification code jsdoc and drop leading-zero test

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EWfLg5uQdYFuzj1UBEo1og

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-07-18 09:35:42 -04:00
Donghoon Yoo 5a8b81b25f fix: Allow deleting failed and expired exports (#13032) 2026-07-18 09:35:32 -04:00
Tom MoorandClaude Opus 4.8 863f09371c perf: Keep vendor-prosemirror out of the eager authenticated bundle (#13026)
* perf: Keep vendor-prosemirror out of the eager authenticated bundle

Split the data-only helpers `getEmpty` and `isEmpty` out of
`ProsemirrorHelper` into a new prosemirror-free `ProsemirrorDataHelper`
module, and point the sidebar, DocumentNew, and other lightweight
callers at it. This removes the static edge from the authenticated entry
graph to `prosemirror-model`, deferring the ~653 KB vendor-prosemirror
chunk until an editor surface is actually opened.

Fixes #13005

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Use non-optional collection.data in defined branch

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-17 07:12:28 -04:00
Tom Moor 03c7576b93 fix: MCP cannot upload files with local storage (#13023)
* fix: MCP cannot upload files with local storage

* refactor
2026-07-16 20:59:49 -04:00
Tom Moor 9cd0539701 perf: findAllChildDocumentIds (#13016)
* wip

* cleanup

* feedback
2026-07-16 20:17:48 -04:00
Tom MoorandClaude Opus 4.8 edd2395214 fix: Deflake DocumentInsight rollupPeriod no-activity test (#13022)
The test asserted the global rollupPeriod return value was 0 while passing
the full UUID range, so activity from other tests sharing the database
(especially near the UTC midnight boundary) leaked into the window. Scope
the partition to the test's own document id to make the count deterministic.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-16 20:17:24 -04:00
Tom MoorandClaude Opus 4.8 3ffd088624 fix: Consistent usage of configured proxy with auth providers (#13018)
* fix: Consistent usage of configured proxy with auth providers

* lint

* fix: Harden proxy agent helper against missing OAuth2 client

Degrade to a logged warning instead of crashing auth at boot if a
strategy's internal _oauth2 client is ever absent.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-16 19:58:32 -04:00
Tom Moor 8af56839d1 Record search queries from MCP (#13011) 2026-07-15 23:20:51 -04:00
Tom Moor 8cf997c5ce fix: Debounce search query persistence (#13004) 2026-07-14 08:18:55 -04:00
Tom Moor 38ff0d38af chore: Refactor getFileBuffer to use stream consumers (#12997) 2026-07-13 19:55:30 -04:00
Tom Moor 3083b34c2f fix: Add query parameter to templates.list endpoint (#12996) 2026-07-13 18:50:38 -04:00
Tom Moor 71446d631d fix: Service worker /static loading (#12978)
* fix: Service worker /static loading

* PR feedback
2026-07-12 17:50:47 -04:00
Tom MoorandClaude f5b45e3d88 feat: section-aware unfurl previews for heading links (#12857)
* feat: section-aware unfurl previews for heading links

When a link targets a specific heading (URL hash anchor), the hover
preview now shows the content of that section rather than the top of
the document.

Adds DocumentHelper.getAnchorContent which extracts the Markdown for the
section beginning at the heading matching a given anchor, spanning until
the next heading of the same or higher level. The urls.unfurl endpoint
passes the URL hash through to the document presenter for both internal
and public share links.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0185Tt87p63vsnAC8oGSLLRs

* fix: retain heading anchor in internal document unfurl url

The internal-document unfurl branch never passed a url to the presenter,
so the response fell back to document.url without the hash. Clicking the
hover preview then navigated to the top of the document rather than the
summarized section. Re-append the anchor in the presenter fallback so the
unfurl points at the same heading it previews.

Also supports the mention anchorId path: document mentions serialize their
anchorId into the href hash, which flows through this same path.

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-07-11 08:05:56 -04:00
石岳峰andsyf2211 8b5f9cd456 fix(mcp): return text content for empty list tool results (#12864)
* fix(mcp): return text content for empty list tool results

When MCP list tools return zero items, success([]) previously produced
an empty content array. Anthropic's MCP connector rejects that format.

Return a single JSON text block for empty arrays so clients can
distinguish no results from a broken tool response.

Fixes #12858

* test(mcp): handle empty list sentinel in integration tests

Add parseMcpListContent helper for the [] sentinel block and update
list tool tests that can receive zero results.

* test(mcp): fix list_collections type assertion in integration test

---------

Co-authored-by: syf2211 <syf2211@users.noreply.github.com>
2026-07-10 19:34:56 -04:00
6a14ac8ae6 feat: Slab importer (#12859)
* Add Slab importer backed by the Markdown import pipeline

Slab exports a zip of Markdown documents that is structurally identical to
the Outline Markdown export, with one difference: images are referenced as
remote signed URLs rather than files inside the archive.

Rather than build a parallel importer, this reuses the Markdown task and
processor and teaches the shared import pipeline to download remote images:

- Enable per-page attachment upload for the Markdown task. The base
  APIImportTask already downloads remote image/video/attachment URLs and
  rewrites them to internal redirect URLs; the Markdown task previously
  opted out because its attachments live in the zip.
- Make the base upload step skip URLs that are already internal, so local
  zip attachments (resolved to redirect URLs during rewriteMarkdown and
  uploaded from the archive in onAllTasksCompleted) pass through untouched
  while remote URLs are fetched and re-hosted. Also guards the URL rewrite
  against nodes not present in the download map.
- Introduce IntegrationService.Slab as a distinct, importable service that
  routes through the Markdown task/processor, so imports are tracked and
  labelled as "Slab" with no duplicated import logic.
- Wire the create API (schema + route), the import settings UI (Slab card
  and dialog), and a placeholder logo asset.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o

* Add shell SlabAPIImportTask as a Slab-specific seam

Slab imports previously ran through MarkdownAPIImportTask directly. Introduce
a thin SlabAPIImportTask subclass so Slab gets its own task name (for
scheduling, tracing, and retries) and a dedicated place to override
behavior as Slab exports diverge from the generic Markdown shape.

The subclass inherits all conversion/attachment/persistence logic and only
overrides scheduleNextTask to keep the whole import chain on the Slab class.
MarkdownImportsProcessor now selects the task implementation by the import's
service when scheduling the first task.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o

* Unwrap single root "slab" directory in Slab imports

Slab exports wrap the entire workspace in a single top-level directory named
"slab". Without handling this, the import produces one "slab" collection
containing everything, instead of mapping each workspace area to its own
collection.

Add a `resolveCollectionRootNodes` seam on the Markdown bootstrap phase
(default: pass entries through unchanged) and override it in SlabAPIImportTask
to descend into a lone, case-insensitive "slab" root directory so its child
directories become collections. Paths are left intact, so the attachment
manifest, completion re-walk, and internal-link resolution stay consistent.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o

* Use the filename, not the first heading, as the title for Slab imports

In Slab a document's leading heading is real content, not its title — the
filename is authoritative. Add an `extractTitle` option to
DocumentConverter.convert (default true, preserving existing callers) that,
when false, skips lifting a leading H1 into the title and leaves it in the
body. Expose it through a `shouldExtractTitleFromHeading` seam on the
Markdown task and override it in SlabAPIImportTask. With no extracted title,
the page falls back to the filename-derived title.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o

* Update logo

* Narrow MarkdownAPIImportTask generic back to Markdown

Slab imports now run through SlabAPIImportTask, so the base Markdown task no
longer handles the Slab service directly and its generic can return to
Markdown-only. SlabAPIImportTask keeps a Markdown | Slab union on its
scheduleNextTask override, which is required so the override stays a valid
(contravariant) override of the base's Markdown-typed parameter.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o

* Optimised images with calibre/image-actions

* reorder

* Move Slab importer into its own plugin

Restructure the Slab importer to live in plugins/slab, mirroring the Notion
plugin, instead of being threaded through the core Markdown importer.

- plugins/slab/server registers SlabImportsProcessor (Hook.Processor) and
  SlabAPIImportTask (Hook.Task). The processor extends MarkdownImportsProcessor
  to claim the Slab service and schedule the Slab task; the task keeps its
  Slab-specific overrides (remote image download, root "slab" dir unwrap,
  filename-as-title).
- plugins/slab/client registers the Slab import card (Hook.Imports) and owns
  the import dialog.
- Revert MarkdownImportsProcessor to Markdown-only and drop the hardcoded Slab
  card from the Import settings screen.

The Slab service enum, import schema, and create route remain in core, as the
Notion plugin's equivalents do.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o

* Generalize DropToImport to accept an importable service

DropToImport previously branched on `format` to map MarkdownZip/JSON/Slab
to specific imports.create calls, with a dead collections.import fallback.
Replace this with a single `service` prop and one generic imports.create
call. Core no longer hardcodes any service name (notably the Slab plugin
service), and the Markdown, JSON, and Slab dialogs each pass their service.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-07-10 19:05:08 -04:00
Tom MoorandClaude Opus 4.8 96372c97b6 fix: Hand desktop sign-in back to the app on self-hosted deployments (#12952)
* fix: Hand desktop sign-in back to the app on self-hosted deployments

The desktop `/desktop-redirect` handoff — which bounces the transfer token
back into the app via the `outline://` protocol — was nested inside the
`env.isCloudHosted && team.subdomain` branch of `signIn`. On a self-hosted
deployment that branch is never taken, so a desktop OIDC (or any) sign-in fell
through to the single-domain path, which set an `accessToken` cookie in the
browser and redirected to the app's home. The desktop app never received the
token and appeared to hang on the SSO screen.

Move the desktop handoff out of the cloud-hosted guard so it runs for every
deployment. The cloud sessions cookie is still written for cloud-hosted teams
(web and desktop alike), and the web / single-domain redirects are unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wv8LuN54DQoxofSoWmTPVK

* refactor: Encode transfer token in redirect URLs and clarify comment

Address PR review: URL-encode the transfer token before interpolating it into
the desktop-redirect and auth/redirect query strings so the value can't
truncate the query if the token format ever changes, and reword the comment
that inaccurately described a cookie being set in this branch.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wv8LuN54DQoxofSoWmTPVK

* docs: Trim desktop redirect comment

Remove the trailing explanation added earlier; the comment reads cleaner
without it.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wv8LuN54DQoxofSoWmTPVK

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-07-10 17:42:33 -04:00
Tom Moor 3539278653 chore: Flaky test (#12957) 2026-07-10 22:33:35 +02:00
Tom Moor 361c875d04 fix: Presigned POST with accelerate (#12946) 2026-07-09 05:27:38 -04:00
ZhuoYang Wu(阿离) 49952b971f feat: Add HTML input support to MCP create_document (#12943) 2026-07-09 03:51:36 -04:00
Tom MoorandClaude Fable 5 032379da93 feat: Add support for OIDC provider returning JWT from userinfo endpoint (#12879)
* feat: Add support for OIDC provider returning JWT from userinfo endpoint

closes #12878

* PR feedback

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 16:28:13 +02:00
Tom MoorandClaude Fable 5 d15fb6c6bc Change MCP _update tools to return error with no changes (#12890)
* fix: Reject document updates that contain no updatable fields

A documents.update request carrying a valid id but no recognized body
field (e.g. text omitted, or an unmapped key stripped by validation)
previously returned 200 OK while writing nothing, so API and MCP
callers could believe content was persisted when nothing changed.

documentUpdater now throws a ValidationError when none of the
updatable properties are provided, making the no-op fail loud with a
400 for both the REST route and the MCP update_document tool. Requests
that only signal an editing session (done) or publish a draft continue
to work.

Closes #12875

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QCYPC1guJ85BezXLNw8Zjo

* fix: Error on MCP document update with no fields provided

Scope the no-op guard to the MCP surface only, and derive it from the
provided input rather than a hardcoded list of properties: any key
other than id counts, since the tool schema already strips
unrecognized fields.

Closes #12875

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QCYPC1guJ85BezXLNw8Zjo

* fix: Base MCP no-op update detection on whether the document changed

Compare the document's revisionCount before and after documentUpdater
runs instead of inspecting the request input. Every save increments
revisionCount, so an unchanged count means nothing was persisted —
this catches both requests with no recognized fields and requests
whose values are identical to the current document.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QCYPC1guJ85BezXLNw8Zjo

* fix: Extend no-op update detection to all MCP update tools

Apply the same fail-loud behavior to update_collection and
update_comment: check model.changed() before saving and return an
error when the request would persist nothing. Mark all three update
tools as non-idempotent since retrying an already-applied update now
returns an error rather than a second success.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QCYPC1guJ85BezXLNw8Zjo

* chore: Fix punctuation in no-op update error messages

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QCYPC1guJ85BezXLNw8Zjo

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-07-08 08:31:35 -04:00
Tom MoorandClaude Fable 5 a1d0520c9f Add missing JSDoc to exported members in app and server utils (#12940)
* Add missing JSDoc to exported members in app and server utils

Documents all exported functions, classes, enums, and constants in
app/utils and server/utils that were missing JSDoc, per the project
documentation guidelines.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AsEQYA8zN813thxu7GjjzU

* Use @returns tag to match codebase convention

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AsEQYA8zN813thxu7GjjzU

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-07-08 08:30:11 -04:00
Tom MoorandClaude Fable 5 3fcef8d68e fix: validateUrlNotPrivate hardening (#12938)
* fix: Validate all DNS records in validateUrlNotPrivate SSRF check

A hostname with multiple A/AAAA records would pass validation as long as
the first record returned was public, even if another record pointed at a
private or link-local address the connection could actually use. Resolve
with { all: true } and reject if any record is private and not allowlisted.

Also wrap DNS resolution failures in InvalidRequestError so an unresolvable
hostname returns a clean 400 instead of an unhandled ENOTFOUND.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UotVRi1xphwNwAchiZZNi5

* chore: Add explicit type for resolved DNS addresses

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UotVRi1xphwNwAchiZZNi5

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-07-08 08:28:39 -04:00
Tom MoorandCopilot Autofix powered by AI d67e682594 fix: Math formulas not rendering correctly in HTML/PDF output (#12939)
* fix: Math formulas not rendering correctly in HTML/PDF output

* Fix version exactly.

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-07-08 08:50:57 +00:00
Tom MoorandClaude Fable 5 db1d93f9b5 perf: Use SCAN and batched UNLINK instead of KEYS in CacheHelper.clearData (#12934)
* perf: Use SCAN and batched UNLINK instead of KEYS in CacheHelper.clearData

The KEYS command blocks the Redis event loop while it walks the entire
keyspace, which stalls all other clients on large installations —
notably on startup where the whole unfurl cache prefix is cleared.
Replace it with incremental SCAN iteration and delete the matched keys
in batches with UNLINK, which reclaims memory asynchronously, so
neither discovery nor deletion blocks the server. Adds test coverage
for CacheHelper including multi-page prefix clears.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015K9AAwaGTLVQZnp7uv5Ebj

* fix: Address review comments on CacheHelper.clearData

Unlink each SCAN batch as the scan progresses instead of buffering all
matching keys in memory, repeating until a full pass matches nothing so
implementations with unstable scan cursors still clear every key. Wrap
the operation in try/catch with logging for consistency with the other
CacheHelper methods, and mark constants as readonly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015K9AAwaGTLVQZnp7uv5Ebj

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-07-08 04:42:02 -04:00
Tom MoorandClaude Opus 4.8 8ea04c3bd4 fix: Skip attachment work in exports when includeAttachments is false (#12933)
Gate the workspace attachment-size query behind includeAttachments so it
no longer runs when attachments are excluded, and thread includeAttachments
through the single-document export path (previously hardcoded to true).

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-08 10:20:18 +02:00
Tom Moor d3c085462d fix: Sensitive fields can leak into logging when non-primitive (#12910) 2026-07-06 22:57:43 +02:00
Tom Moor ec3b26241f chore: Reduce file scanning in PluginManager on startup (#12911) 2026-07-06 22:57:39 +02:00
Tom MoorandClaude Fable 5 2b6ee79778 fix: all _FILE suffix secrets in env are cemented at startup (#12889)
* fix: Resolve _FILE env secrets lazily to avoid clobbering third-party variables

The Docker-style secrets support added in #11906 eagerly copied every
*_FILE environment variable into its base variable at boot. This broke
AWS SDK credential refresh on EKS Pod Identity: the rotating token in
AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE was frozen into the static
AWS_CONTAINER_AUTHORIZATION_TOKEN variable, which the SDK prefers and
never re-reads, so S3 access failed once the boot-time token expired.
It similarly resolved the standard OpenSSL SSL_CERT_FILE CA bundle into
Outline's SSL_CERT setting, failing validation at startup.

File secrets are now resolved lazily through a proxy when a variable is
read off the environment export, which limits resolution to variables
declared on the Environment classes, and SSL_CERT_FILE is explicitly
reserved for OpenSSL.

Fixes #12885

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MqP3Gb29iG5bJmhYuEAAjF

* refactor: Generalize reserved file variable documentation

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MqP3Gb29iG5bJmhYuEAAjF

* refactor: Clear SSL_CERT_FILE in test environment instead of reserving it

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MqP3Gb29iG5bJmhYuEAAjF

* docs: Trim withFileSecrets JSDoc

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MqP3Gb29iG5bJmhYuEAAjF

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-07-06 16:14:03 -04:00
Tom Moor a60373118c fix: Handle transient errors in HealthMonitor (#12913) 2026-07-06 16:13:32 -04:00
Tom Moor 3e5d21fa11 fix: revisions.list response too large (#12822) 2026-06-30 13:35:30 -04:00
Tom Moor ec3200c7d2 chore: babel -> swc (#12821)
* chore: babel -> swc

* Add ls guard

* PR feedback
2026-06-29 17:11:02 -04:00
Tom MoorandClaude Opus 4.8 695042b2af feat: Batch RPC endpoint (#12820)
* batch RPC endpoint

* Clamp batch socket timeout between 15s and 25s

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-28 02:39:30 -04:00
Cassiano Vailati 34907e1500 fix: Add WWW-Authenticate header to /mcp 401 responses (#12834)
* fix: Add WWW-Authenticate header to /mcp 401 responses

RFC 9728 and the MCP authorization spec require protected resources to
include a WWW-Authenticate header on 401 responses so clients can
discover the authorization server via the resource metadata document.

* fix: Preserve existing WWW-Authenticate and guard against non-object errors

Avoid overwriting an upstream WWW-Authenticate header if one is already
present on the error (case-insensitive lookup), and only attempt to
attach headers when the thrown value is a non-null object.
2026-06-25 21:21:15 -04:00
Cassiano Vailati 4845da08ac fix: Make client_name optional on /oauth/register (#12836)
RFC 7591 §2 marks every client metadata field as OPTIONAL. Outline's
schema currently treats client_name as required, which rejects MCP
clients that omit it during dynamic registration. The field becomes
optional and a generic 'Untitled application' label is used when the
caller doesn't supply one.
2026-06-25 20:49:41 -04:00
Tom MoorandClaude Opus 4.8 7b809ab48c fix: Avoid SequelizeEmptyResultError when team is missing in CollectionsProcessor (#12837)
Drop rejectOnEmpty so a deleted team yields null and the existing optional
chaining guard short-circuits the no-op transaction.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 20:49:09 -04:00
Tom MoorandClaude Opus 4.8 6a81426181 fix: Avoid SequelizeEmptyResultError in AvatarProcessor (#12838)
The team or user can be deleted before the async processor runs, so
gracefully skip the avatar upload instead of throwing.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 20:49:05 -04:00
Tom MoorandClaude Opus 4.8 e237e6df47 fix: Handle deleted user or team in UserCreatedProcessor (#12839)
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 20:49:02 -04:00
Yinhao HuangandClaude Opus 4.8 6286d08171 feat: support presigned PUT uploads for S3-compatible storage (#12748)
* feat: support presigned PUT uploads for S3-compatible storage

Add `AWS_S3_UPLOAD_METHOD` config ("post" default / "put") so providers
that do not implement presigned POST (e.g. Cloudflare R2) can use
presigned PUT instead.

- BaseStorage.getPresignedPut() returns undefined by default; S3Storage
  overrides with PutObjectCommand + getSignedUrl.
- Content-Length is signed into the presigned PUT URL so S3 rejects
  uploads that do not match the declared size.
- API route and MCP tool branch on the config: only one upload method
  is returned per request.
- Frontend uses existing presignedPutUrl presence check — unchanged.
- When put is configured but unsupported (e.g. LocalStorage), a clear
  InvalidRequestError is returned.

Defaults to "post" — zero behavior change for existing deployments.

* refactor: return explicit upload mode instead of inferring from fields

Address review feedback from @tommoor: the client should not need to
infer the upload method from the presence of presigned-PUT-specific
fields. The API now returns an explicit `mode` ("put" | "post"), and the
PUT branch uses generic `url` / `headers` fields so the client has no
special knowledge of "presigned puts".

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* refactor: use this.getBucket() in presigned post/put methods

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 21:05:16 -04:00
Tom Moor c3669a1f1a fix: Guard against orphaned jobs in queue (#12819) 2026-06-24 17:54:08 -04:00
Tom Moor 5f236935bc fix: CleanupDemotedUserTask throws on deleted user (#12818)
closes #12815
2026-06-24 17:54:01 -04:00