Commit Graph
2576 Commits
Author SHA1 Message Date
Tom Moor 6bc80720c9 fix: Allow user account lookup with mismatching email capitalization (#9929) 2025-08-14 08:01:51 -04:00
Tom Moor 23106bfce8 fix: Use safeEqual in VerificationCode verify method (#9915) 2025-08-13 22:45:11 -04:00
Tom Moor ba8ade0244 chore: Add some additional debugging around auth failures (#9924) 2025-08-13 22:44:53 -04:00
codegen-sh[bot]andTom Moor 4fc6ac1f15 Add in-app reaction notifications (#9893)
* Add ReactionsCreate notification event type

- Add ReactionsCreate to NotificationEventType enum and defaults
- Add notification settings UI with SmileyIcon and proper labels
- Create ReactionsCreateNotificationsTask to handle comment reactions
- Update NotificationsProcessor to handle comments.add_reaction events
- Add eventText and path handling in client Notification model
- Notifications are enabled by default but never send emails

* Applied automatic fixes

* Show the actual emoji in the notification

* Cleanup notifications if reaction is removed

* PR feedback

---------

Co-authored-by: codegen-sh[bot] <131295404+codegen-sh[bot]@users.noreply.github.com>
Co-authored-by: Tom Moor <tom@getoutline.com>
2025-08-11 18:54:43 -04:00
codegen-sh[bot]andTom Moor c3f93a3e9d Add relationships API endpoints (#9402)
* Migrate Backlink model to generic Relationship model

- Create new Relationship model with type field to support different relationship types
- Add database migration to create relationships table and migrate existing backlinks
- Update Backlink model to delegate to Relationship model for backward compatibility
- Update BacklinksProcessor to use Relationship model with backlink type
- Update API routes to use new Relationship model
- Update test files to use Relationship model
- Maintain backward compatibility through database view and model delegation

Fixes #9366

* Update migration to rename table instead of creating new one

- Rename existing backlinks table to relationships instead of creating new table
- Add type column with default value to existing table
- Update existing rows to have type='backlink'
- Avoid expensive data migration by keeping existing data in place
- Maintain backward compatibility with database view
- Update rollback to reverse table rename and column addition

This approach is much more efficient for large datasets as it avoids copying millions of rows.

* Remove unnecessary UPDATE statement from migration

The UPDATE statement is not needed since defaultValue automatically
applies to existing rows when adding a column with a default value.

Thanks @tommoor for catching this!

* Wrap up migration in transaction

- Wrap all migration operations in a transaction for atomicity
- Add transaction parameter to all queryInterface calls
- Follow the same pattern as other migrations in the codebase
- Ensures all operations succeed or fail together

* Remove Backlink class entirely and use Relationship everywhere

- Delete server/models/Backlink.ts
- Remove Backlink export from server/models/index.ts
- Remove Backlink import and association from Document model
- All functionality now uses Relationship model with RelationshipType.Backlink
- Maintains same API through Relationship model methods
- Cleaner architecture with single relationship model

* Update documents.test.ts to use RelationshipType enum instead of string

- Import RelationshipType from Relationship model
- Replace type: "backlink" with type: RelationshipType.Backlink
- Improves type safety and consistency with enum usage

* Address code review feedback

- Add transaction wrapper to migration down method for safer rollback
- Remove unused findByTypeForUser method from Relationship model
- Method wasn't used and won't work for all relationship types (e.g., user mentions)
- Clean up code structure and improve safety

* Restore imports

* Add relationships API endpoints

- Create relationships API following stars pattern
- Add CRUD operations: create, list, delete
- Include proper validation, authentication, and authorization
- Support filtering by relationship type and document IDs
- Add relationship presenter and policies
- Register routes in main API router

* Remove relationships.create and relationships.delete endpoints

- Keep only relationships.list endpoint as requested
- Remove create and delete schemas from validation
- Update policies to only allow read operations
- Relationships will be managed internally, not via external API

* Add relationships.info endpoint

- Use Document.findByPk for authorization as requested
- Find relationship by ID and verify user has access to related document
- Return relationship details with accessible documents
- Include proper validation schema for UUID parameter

* Update 20250601223331-migrate-backlink-to-relationship.js

* Update Relationship.ts

* wip

* test

* Final tweaks

---------

Co-authored-by: codegen-sh[bot] <131295404+codegen-sh[bot]@users.noreply.github.com>
Co-authored-by: Tom Moor <tom@getoutline.com>
2025-08-10 15:24:01 -04:00
Tom Moor c5cd4d9335 fix: Remove nullable on teams.name column (#9890)
* fix: Remove nullable on teams.name column

* Add test
2025-08-10 14:02:01 -04:00
Tom Moor cda503e7af fix: Correct transaction usage through team creation process (#9878)
* fix: Correct transaction usage through team creation process

* refactor
2025-08-09 07:47:39 -04:00
Tom Moor 93cda9327a fix: Admins unable to revoke workspace API keys created by other users (#9865)
* fix: Admins unable to revoke workspace API keys created by other users

closes #9864

* fix policy
2025-08-07 22:49:23 -04:00
HemachandarandTom Moor 888add7920 Use shareLoader for loading public docs in documents.info endpoint (#9822)
* Use `shareLoader` for loading public docs in `documents.info` endpoint

* cleanup sharedCache in documents store

* remove shareId path param for authenticated routes

* require auth in document loader

---------

Co-authored-by: Tom Moor <tom@getoutline.com>
2025-08-07 22:41:04 -04:00
Hemachandar d5510f4454 fix: Allow users to revoke a collection share (#9870) 2025-08-08 00:07:04 +05:30
Hemachandar 04c3d81b1f chore: Setup missing oxlint configs (#9862)
* shared

* server

* app

* remove vestigial eslintrc files

* update comment directives
2025-08-06 19:54:22 -04:00
Tom Moor a97908518a fix: Various issues with JSON import and UTF8 or very long filenames (#9850) 2025-08-05 21:15:45 -04:00
Tom Moor 84f45b7fb7 fix: refresh token rotation is broken in OAuth provider implementation (#9847)
* fix: Incorrect clientId used in getAccessToken response

* fix: getRefreshToken as well
2025-08-05 18:34:52 -04:00
Hemachandar ca2258ecc7 Ensure auth when loading non-public share info (#9840) 2025-08-05 09:01:56 -04:00
Hemachandar b4757dfc6c Allow disconnecting analytics integrations (#9823)
* Allow disconnecting analytic integrations

* review
2025-08-05 07:36:48 -04:00
Tom Moor 8dc6bcba22 fix: Add option as to whether state cookie is considered for team context (#9831)
* fix: Do not consider host in cookies state unless its a workspace subdomain

* fix: Add option as to whether state cookie is considered in team context
2025-08-04 19:50:32 -04:00
Hemachandar 129f8f0520 fix: Generate sitemap for shares with custom slugs (#9820)
* fix: Generate sitemap for shares with custom slugs

* throw 400 when teamId is not present
2025-08-04 09:21:58 -04:00
Tom Moor 34059ce0ef chore: More missing transactions (#9811)
* fix: Missing transaction in notifications.update_all

* lint
2025-08-03 21:52:10 -04:00
Tom Moor 08a0b72706 fix: Unable to load share from custom slug (#9808)
* fix: Unable to load share from custom slug

closes #9807
regressed in #9529

* fix: Incorrect share ID passed through with custom slug
2025-08-03 18:52:20 -04:00
codegen-sh[bot] 6c2313919b Improve webhook disabling heuristic with time-based analysis (#9800)
* Improve webhook disabling heuristic with time-based analysis

- Add WEBHOOK_FAILURE_TIME_WINDOW environment variable (default: 24 hours)
- Add WEBHOOK_FAILURE_RATE_THRESHOLD environment variable (default: 80%)
- Replace simple count-based logic with time-window failure rate analysis
- Require minimum 5 deliveries in time window before disabling
- Add comprehensive logging for webhook failure analysis
- Update email template to reflect new time-based approach

Addresses GitHub issue #9788 by making webhook disabling smarter and
considering time factors instead of just consecutive failure counts.

* Fix Logger.warn type error

Remove extra 'task' parameter from Logger.warn call to match the correct
signature: Logger.warn(message: string, extra?: Extra)

* Update WEBHOOK_FAILURE_TIME_WINDOW to use seconds instead of hours

- Change default value from 24 (hours) to 86400 (seconds)
- Update time conversion logic from hours*60*60*1000 to seconds*1000
- Rename timeWindowHours variable to timeWindowSeconds for clarity
- Update documentation comments to reflect seconds-based configuration

This provides more granular control while maintaining the same default
behavior (24 hours = 86400 seconds).

* Improve webhook failure logging and analysis threshold

- Only log webhook failure analysis when failedDeliveries.length > 0
- Extract hardcoded minimum deliveries threshold to constant
- Update minimum deliveries threshold from 5 to 10 for more reliable analysis

This reduces log noise when there are no failures and requires more data
points before considering webhook disabling.

---------

Co-authored-by: codegen-sh[bot] <131295404+codegen-sh[bot]@users.noreply.github.com>
2025-08-03 15:39:04 -04:00
Tom Moor 73f079f32b fix: Missing transaction in UploadAttachmentFromUrlTask (#9803) 2025-08-03 13:43:47 -04:00
HemachandarandTom Moor d3eb3db7ba feat: Public sharing of collections (#9529)
* shares.info, collections.info, documents.info

* shares.list, shares.create, shares.update

* shares.sitemap

* parity with existing document shared screen

* collection share popover

* parent share and table

* collection scene

* collection link in sidebar

* sidebar and breadcrumb collection link click

* collection link click in editor

* meta

* more meta + 404 page

* map internal link, remove showLastUpdated option

* fix shares.list pagination

* show last updated

* shareLoader tests

* lint

* sidebar context for collection link

* badge in shares table

* fix existing tests

* tsc

* update failing test snapshot

* env

* signed url for collection attachments

* include collection content in SSR for screen readers

* search

* drafts can be shared

* review

* tsc, remove old shared-doc scene

* tweaks

* DRY

* refactor loader

* Remove share/collection urls

* fix: Collection overview should not be editable when viewing shared link and logged in

* Tweak public breadcrumb

* fix: Deleted documents should never be exposed through share

* empty sharedTree array where includeChildDocuments is false

* revert includeChildDocs guard for logical correctness + SSR bug fix

* fix: check document is part of share

---------

Co-authored-by: Tom Moor <tom@getoutline.com>
2025-08-03 13:07:39 -04:00
dependabot[bot]andTom Moor f7826c7d91 chore(deps): bump koa from 2.16.1 to 3.0.1 (#9766)
* chore(deps): bump koa from 2.16.1 to 3.0.1

Bumps [koa](https://github.com/koajs/koa) from 2.16.1 to 3.0.1.
- [Release notes](https://github.com/koajs/koa/releases)
- [Changelog](https://github.com/koajs/koa/blob/master/History.md)
- [Commits](https://github.com/koajs/koa/compare/v2.16.1...v3.0.1)

---
updated-dependencies:
- dependency-name: koa
  dependency-version: 3.0.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update ctx.throw usage

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Moor <tom@getoutline.com>
2025-08-02 19:31:23 -04:00
Tom Moor 09e835d935 fix: Mutation endpoints missing transactions (#9799) 2025-08-02 11:14:32 -04:00
Tom Moor a139d599b7 fix: Nested lists flatten in confluence import (#9797)
Towards #9789
2025-08-02 09:04:26 -04:00
Tom Moor 114e240958 fix: Remove revision data from events as it is immutable anyway (#9796) 2025-08-02 08:17:24 -04:00
Tom Moor a0308cf809 fix: Allow <br> tags to represent breaks in API markdown input (#9794)
* fix: Allow <br> tags to represent breaks in API markdown input

* tests
2025-08-02 07:17:29 -04:00
Tom Moor 1d0c2225d0 fix: Col/row selection on table with merged cells (#9786)
* fix: Col/row selection on table with merged cells

* skip unrelated tests
2025-07-31 22:07:57 -04:00
Tom Moor da86f38e6f chore: Include stack traces with warnings and sample at 10% (#9784) 2025-07-31 18:16:46 -04:00
Tom Moor 737e7ba4b4 fix: Improve importer to be more resilient to hidden directories (#9762) 2025-07-28 20:36:45 -04:00
Tom Moor 520a2e363e fix: emails parameter on users.list should be case insensitive (#9755) 2025-07-28 07:14:41 -04:00
Tom Moor 64550ae790 fix: Base model logic (#9749) 2025-07-27 17:57:29 -04:00
Tom Moor cdd4cc56c2 fix: Special case actorId for user creation from SSO signup (#9747) 2025-07-27 21:13:12 +00:00
Tom Moor cc591ebc66 Conversion of User to event system (#9741)
* Conversion of User to event system

* fix

* warning

* fixes

* Skip lastActiveAt in changeset

* fix: Skip count in view changeset

* refactor: Remove userDestroyer

* refactor: Remove userSuspender

* refactor: Remove userUnsuspender

* tests
2025-07-27 13:15:21 -04:00
Tom Moor c678701bd0 fix: Documents accessible only through group memberships do not appear in search results (#9738)
* first pass

* Add falsy test case coverage
2025-07-26 12:31:11 -04:00
Tom Moor 46ae6d8e6d Double timeout on Notion imports to 24h (#9723) 2025-07-24 01:46:53 +00:00
Tom Moor 877073b538 chore: Alternative solution for Redis mock race (#9719)
* chore: Alternative solution for redis mock race

* docs
2025-07-23 20:42:57 -04:00
Tom Moor cf2f13193f chore: Fix Redis mock not used consistently in tests (#9716) 2025-07-23 09:38:24 -04:00
Tom Moor b4836cd922 fix: Title content after period sometimes stripped in import (#9712)
closes #9694
2025-07-22 13:00:23 +00:00
Cameron bdf89e5de8 chore(linter): improve oxlint setup (#9695) 2025-07-21 06:57:00 -04:00
Tom Moor f23559d1b8 chore: Integration to event backend (#9688) 2025-07-20 13:13:27 -04:00
codegen-sh[bot] d188b7b53b Fix foreign key constraint error in teamPermanentDeleter (#9685) 2025-07-19 18:54:25 -04:00
Tom Moor 6e33b90f62 chore: Convert View to event backend (#9683) 2025-07-19 15:01:25 -04:00
Hemachandar 5db3df35f5 chore: Move Collection event writing to model layer (#9663)
* collections.create, collections.update, collections.delete API

* collections.archive, collections.restore

* collections.move

* file imports

* remove collectionDestroyer

* remove data field

* remove data field for collections.move

* remove data field for import flow

* use hook for permission_changed event

* simplify event type

* tiny
2025-07-19 13:38:22 -04:00
Tom Moor 41df837435 chore: Add exponential backoff / retry for deadlocks (#9671)
* chore: Add exponential backoff / retry for deadlocks

* feedback
2025-07-18 20:19:18 -04:00
Tom Moor a83adc4ecf feat: Allow horizontal scaling of collaboration service (#9625)
* stash

* Horizontal scaling of collaboration service
2025-07-17 08:53:52 -04:00
Hemachandar d78b0440df fix: Skip overwriting non-transaction fields in firstCollectionForTeam query (#9662) 2025-07-17 08:22:09 -04:00
Hemachandar c7231ffd8b chore: Move Revision event writing to model layer (#9650) 2025-07-16 17:28:29 -04:00
Tom Moor bf447ec72a Convert team to model events (#9628) 2025-07-16 07:06:59 -04:00
Hemachandar 7d315288dd Listen to GitHub webhooks to update issueSources cache (#9414)
* Listen to GitHub webhooks to update issue-sources cache

* Add `GitHubWebhookTask`

* review
2025-07-15 23:07:14 -04:00