* fix: Crash when two mermaid diagrams are adjacent
A diagram's widget decoration sits at the end of its code block, which is
also the start position of the following block. When the next block is also
a mermaid diagram and has no decoration of its own yet, it adopted the
preceding diagram's renderer — and so its single DOM element — leaving two
widget decorations sharing one node and crashing prosemirror-view.
Co-Authored-By: Claude <noreply@anthropic.com>
* fix: Enter with mermaid selection deletes node
---------
Co-authored-by: Claude <noreply@anthropic.com>
* wip
* generalize
* refactor
* Extract SearchResultIcon for command bar results
Both search action builders rendered the same document icon inline. Move it
into a shared component alongside the other command bar pieces, forwarding
size so the command bar can continue to size icons via cloneElement.
Also drop the redundant charAt(0).toUpperCase() on the initial, as the Icon
component already normalizes it.
Co-Authored-By: Claude <noreply@anthropic.com>
* PR feedback
Prevent same doc showing twice in cmd k
Improve result ordering in main app command bar
Refactor to flattenTree
* Upgrade Fuse to 7.5.0, use workers
* fix: Re-register search actions when index is enriched
Include result contexts in the command bar registration key so that
snippets refresh when the same documents are enriched, and only mark a
server search as cached once its results are actually fed to the index.
Co-Authored-By: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
* fix: preserve diagrams.net source through API markdown round-trip
Images with source: "diagrams.net" (draw.io embeds) lost their editability
when updated through the API (documents.create/update with text). The
markdown serializer/deserializer had no slot for the source attribute, so
every round-trip through markdown stripped it, downgrading editable diagrams
to static images.
Encode source as a "source=<value>" token in the markdown title attribute,
which already carries layoutClass and size. The token is extracted on parse
and emitted on serialize, surviving the full API round-trip.
* fix: address image source review feedback
Authored-by: Terminus (AI Assistant) <raisalpwardana+terminus@gmail.com>
* fix: narrow image test node attributes
Authored-by: Terminus (AI Assistant) <raisalpwardana+terminus@gmail.com>
* fix: narrow image test attributes
Authored-by: Terminus (AI Assistant) <raisalpwardana+terminus@gmail.com>
---------
Co-authored-by: Raisal P Wardana <IEatCodeDaily@users.noreply.github.com>
* chore: Audit and move inline actions to definitions
* fix: Reuse existing smart-quote translation key in emoji delete dialog
Co-Authored-By: Claude <noreply@anthropic.com>
* Remove two usages of 'Link copied' translation
---------
Co-authored-by: Claude <noreply@anthropic.com>
collections.memberships and collections.group_memberships both authorize
with read permission, but methodToScope was missing entries for
"memberships" and "group_memberships", causing them to default to
Scope.Write. Read-scoped tokens could not list collection members.
Adds the ability to open a second route alongside the current one:
- The secondary route is stored in a `split` query string parameter so
that reloading the page hydrates both panes.
- The secondary pane runs in its own in-memory router kept in sync with
the query parameter, so links followed inside the pane navigate the
pane rather than the primary route.
- Navigation while a split is open preserves the split, is directed to
the focused pane, and routes that cannot render in a pane (such as
settings) close the split.
- The focused pane is shown with an accent outline, updated as panes are
clicked or focused, and keyboard shortcuts only apply to the focused
pane.
- "Open in split view" added to document and collection menus and the
command bar.
* feat: Add onNotice callback to decouple shared editor from toast library
Shared editor code called sonner's toast directly. Introduce an onNotice
callback (defaulting to a toast) so the shared editor stays agnostic of the
host app's notification library.
* Add lint rule to prevent regression
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* Reduce server memory usage and add container memory best practices
Profiling a full-service boot showed ~300MB RSS per service process, much
of it client-only dependencies pulled into the server module graph, and no
heap limits applied in containers:
- Import date-fns locales individually rather than via the locale index,
which loaded all ~90 locales into every process
- Load @sentry/react dynamically in insertFiles so the browser Sentry SDK
stays out of the server-side editor graph
- Replace class-validator isHexColor with the existing validateColorHex
in the Highlight mark
- Extract icon names into a standalone IconNames module so server-side
schema validation no longer imports Font Awesome icon packs, with a
test to keep it in sync with IconLibrary
- Require S3Storage lazily so the AWS SDK and native CRT binding are only
loaded when S3 file storage is configured
- Default each forked service process to a V8 heap limit derived from the
cgroup memory constraint, preventing several processes from together
committing more memory than the container allows
- Cap glibc malloc arenas in the Docker image to reduce resident memory
fragmentation in multi-threaded processes
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa
* Require both file storage backends lazily for consistency
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa
* Load AWS SDK via dynamic imports compatible with test environment
Requiring the storage TypeScript modules lazily broke under Vitest, which
cannot resolve require() of source files and does not apply vi.mock to
bare requires. Move the laziness into S3Storage instead: the module is
imported statically, and the AWS SDK packages are loaded with dynamic
imports on first use, including deferred creation of the S3 client.
Also address review feedback: handle rejection of the dynamic Sentry
import, and warn when the minimum per-process heap limit exceeds the
memory budget of the container.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa
* Consolidate S3 SDK loading into a single lazy accessor
The commands are loaded together with the client in getS3() rather than
as separate dynamic imports per method. The global S3Client test mock is
now a class, as a mock function is not constructable when reached through
a dynamic import.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016YMX5ReGHyxrR4ZE5ZbaXa
---------
Co-authored-by: Claude <noreply@anthropic.com>
* perf: Keep vendor-prosemirror out of the eager authenticated bundle
Split the data-only helpers `getEmpty` and `isEmpty` out of
`ProsemirrorHelper` into a new prosemirror-free `ProsemirrorDataHelper`
module, and point the sidebar, DocumentNew, and other lightweight
callers at it. This removes the static edge from the authenticated entry
graph to `prosemirror-model`, deferring the ~653 KB vendor-prosemirror
chunk until an editor surface is actually opened.
Fixes#13005
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* Use non-optional collection.data in defined branch
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* Harden shared tree utilities and add test coverage
- Fix ancestors() throwing a TypeError when a node's parent is undefined
rather than null, which is the case for nodes that haven't been
annotated by useCollectionTrees (e.g. shared trees from the server).
- Guard against malformed parent cycles in ancestors() so a bad tree can
no longer hang the client.
- Compute descendants() depth limits relative to the given node during
traversal instead of relying on optional absolute depth annotations,
which silently returned an empty list when they were missing.
- Tolerate nodes without a children array in traversal.
- Remove type assertions, add JSDoc, and add collocated unit tests.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vt5wWLYomgKZjfgPNk8wN4
* Address review: exclude node from own ancestors on parent cycles
- Seed the cycle guard with the starting node so a malformed parent
cycle can never include the node in its own ancestor list.
- Widen flattenTree's parameter to accept nullish roots so the runtime
guard and the type contract agree.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vt5wWLYomgKZjfgPNk8wN4
---------
Co-authored-by: Claude <noreply@anthropic.com>
classDiagram, erDiagram, and requirementDiagram render node labels using
<foreignObject> elements. Browsers skip layout of <foreignObject> content
inside visibility:hidden SVGs, causing mermaid's layout engine to measure
zero-size labels and produce inflated viewBox dimensions (thousands of
pixels for a small diagram).
Switching the render container from visibility:hidden to opacity:0 keeps
the element in the render tree and fully laid out — preserving correct
getBBox() results for both regular SVG elements and foreignObject content —
without making the rendering visible to the user.
The cache prefix is bumped to v3 so previously mis-sized diagrams cached
under v2 are discarded and re-rendered correctly.
* Add Slab importer backed by the Markdown import pipeline
Slab exports a zip of Markdown documents that is structurally identical to
the Outline Markdown export, with one difference: images are referenced as
remote signed URLs rather than files inside the archive.
Rather than build a parallel importer, this reuses the Markdown task and
processor and teaches the shared import pipeline to download remote images:
- Enable per-page attachment upload for the Markdown task. The base
APIImportTask already downloads remote image/video/attachment URLs and
rewrites them to internal redirect URLs; the Markdown task previously
opted out because its attachments live in the zip.
- Make the base upload step skip URLs that are already internal, so local
zip attachments (resolved to redirect URLs during rewriteMarkdown and
uploaded from the archive in onAllTasksCompleted) pass through untouched
while remote URLs are fetched and re-hosted. Also guards the URL rewrite
against nodes not present in the download map.
- Introduce IntegrationService.Slab as a distinct, importable service that
routes through the Markdown task/processor, so imports are tracked and
labelled as "Slab" with no duplicated import logic.
- Wire the create API (schema + route), the import settings UI (Slab card
and dialog), and a placeholder logo asset.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o
* Add shell SlabAPIImportTask as a Slab-specific seam
Slab imports previously ran through MarkdownAPIImportTask directly. Introduce
a thin SlabAPIImportTask subclass so Slab gets its own task name (for
scheduling, tracing, and retries) and a dedicated place to override
behavior as Slab exports diverge from the generic Markdown shape.
The subclass inherits all conversion/attachment/persistence logic and only
overrides scheduleNextTask to keep the whole import chain on the Slab class.
MarkdownImportsProcessor now selects the task implementation by the import's
service when scheduling the first task.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o
* Unwrap single root "slab" directory in Slab imports
Slab exports wrap the entire workspace in a single top-level directory named
"slab". Without handling this, the import produces one "slab" collection
containing everything, instead of mapping each workspace area to its own
collection.
Add a `resolveCollectionRootNodes` seam on the Markdown bootstrap phase
(default: pass entries through unchanged) and override it in SlabAPIImportTask
to descend into a lone, case-insensitive "slab" root directory so its child
directories become collections. Paths are left intact, so the attachment
manifest, completion re-walk, and internal-link resolution stay consistent.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o
* Use the filename, not the first heading, as the title for Slab imports
In Slab a document's leading heading is real content, not its title — the
filename is authoritative. Add an `extractTitle` option to
DocumentConverter.convert (default true, preserving existing callers) that,
when false, skips lifting a leading H1 into the title and leaves it in the
body. Expose it through a `shouldExtractTitleFromHeading` seam on the
Markdown task and override it in SlabAPIImportTask. With no extracted title,
the page falls back to the filename-derived title.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o
* Update logo
* Narrow MarkdownAPIImportTask generic back to Markdown
Slab imports now run through SlabAPIImportTask, so the base Markdown task no
longer handles the Slab service directly and its generic can return to
Markdown-only. SlabAPIImportTask keeps a Markdown | Slab union on its
scheduleNextTask override, which is required so the override stays a valid
(contravariant) override of the base's Markdown-typed parameter.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o
* Optimised images with calibre/image-actions
* reorder
* Move Slab importer into its own plugin
Restructure the Slab importer to live in plugins/slab, mirroring the Notion
plugin, instead of being threaded through the core Markdown importer.
- plugins/slab/server registers SlabImportsProcessor (Hook.Processor) and
SlabAPIImportTask (Hook.Task). The processor extends MarkdownImportsProcessor
to claim the Slab service and schedule the Slab task; the task keeps its
Slab-specific overrides (remote image download, root "slab" dir unwrap,
filename-as-title).
- plugins/slab/client registers the Slab import card (Hook.Imports) and owns
the import dialog.
- Revert MarkdownImportsProcessor to Markdown-only and drop the hardcoded Slab
card from the Import settings screen.
The Slab service enum, import schema, and create route remain in core, as the
Notion plugin's equivalents do.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o
* Generalize DropToImport to accept an importable service
DropToImport previously branched on `format` to map MarkdownZip/JSON/Slab
to specific imports.create calls, with a dead collections.import fallback.
Replace this with a single `service` prop and one generic imports.create
call. Core no longer hardcodes any service name (notably the Slab plugin
service), and the Markdown, JSON, and Slab dialogs each pass their service.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AC5Ho2SHBjNpxEAMr5uL6o
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Images with a stored pixel width (e.g. from paste) set an inline
style="width: 1920px" on the image-wrapper and img elements. In tables
without explicit colwidth attributes the browser uses table-layout: auto,
which lets cells expand to the element's preferred width. The existing
max-width: 100% in the ImageWrapper styled-component cannot constrain
the wrapper because 100% of the already-expanded cell is also 1920px.
Changing to width: min(Npx, 100%) breaks the expansion: during auto
table layout the browser resolves 100% against the table's available
width rather than the cell's inflated size, so the element's
min-content contribution stays bounded and the cell no longer grows
beyond its share of the table width.
Fixes#12866
Co-authored-by: tsushanth <t.sushanth@gmail.com>
* feat: Allow matching block input rules after soft-break
* fix PR feedback, math block handling
* perf: stop soft-break scan at the cursor position
Replace parent.forEach with a manual loop that breaks once past the
cursor, avoiding unnecessary per-keystroke iteration over inline nodes
after the cursor in large blocks.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* Allow setting cell alignment from the table row menu
Add an "Align" submenu to the table row selection toolbar, mirroring the
existing column alignment menu. A new setRowAttr command applies the chosen
alignment to every cell in the selected row(s).
Note that per-cell (row) alignment cannot be represented in the markdown
serialization of a table, which only supports per-column alignment, so it is
preserved in the collaborative document only.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014ntSQZRBPPzERhRqmRCU6h
* Remove setRowAttr tests
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014ntSQZRBPPzERhRqmRCU6h
* reorder
---------
Co-authored-by: Claude <noreply@anthropic.com>
getFileNameFromUrl returned the raw URL path segment, so attachments
created from a URL were stored with encoded names (e.g. "My%20File.pdf").
Decode the filename, falling back to the raw value on malformed encoding.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* fix: Various unlabelled and undescribed interactable elements
* fix: guard sort keydown against key repeat and label remaining help button
Prevent held Space from repeatedly toggling table sort, and add an
accessible name to the "Email subscriptions" help button.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* feat(editor): support image corner drag resizing with aspect ratio lock
- Implement circular corner drag handles (ResizeTopLeft, ResizeTopRight, ResizeBottomLeft, ResizeBottomRight) using theme selection color.
- Update useDragResize hook to track coordinates as {x,y} object and handle aspect-ratio locked sizing for corner drags.
- Set overflow: visible on ImageWrapper to prevent corner handles from being clipped, and fade them in on hover.
* refactor(editor): simplify ResizeCorner styles by removing background and shadow properties
* fix(editor): fix corner resize speed and sync inputs in real-time
* fix(editor): improve corner resize cursor tracking and drag cursors
Project corner drag deltas onto the aspect-ratio vector so resizing
follows the pointer at 1x speed. Add a body class and global cursor
styles during image/media resize drags.
* refactor(editor): use relative import path inside shared directory
* fix(editor): resolve typescript type mismatch on dragging property in PDF component