Commit Graph
419 Commits
Author SHA1 Message Date
Tom Moor 9fe0c7ba2b fix: Preserve existing values when optional update fields are omitted (#14344)
* fix: Preserve existing values when optional update fields are omitted

* chore: Rename setDefined to fill

* chore: Use fill in users.update and teamUpdater
2026-10-26 17:29:17 -04:00
Tom Moor 9aad5a4bb7 feat: Add Gitea / Forgejo integration (#14336)
* feat: Add Gitea integration for issue, pull request, and repository previews

* fix: Gitea repository previews and request deadlines

Refresh the token before repository discovery, keep repository previews when
the issue tracker is disabled, and keep the request timeout active while the
response body is read.

* chore: Use the shared fetch timeout for Gitea requests

* chore: Mention Forgejo in Gitea copy and reuse the callback URL helper

* Remove service specific getters in IntegrationsStore
2026-10-25 18:04:04 -04:00
Tom Moor 71af4d6901 fix: Require GitHub account ownership when connecting an installation (#14323) 2026-10-24 18:52:43 -04:00
Tom Moor 0d13c183fd chore: Add lint rules for test conventions (#14318) 2026-10-24 14:09:36 -04:00
Tom Moor b72f11b01e chore: Enforce more codebase conventions with lint rules (#14310)
* chore: Enforce more codebase conventions with lint rules

Add lint rules for request.origin, deferred useLocation reads, # private
members, lodash and date-fns subpath imports, and button types. Fix the
existing violations.

* fix: Only flag useLocation reads in event handlers and useCallback

* test: Use a fixed member name in users.list name query test
2026-10-24 13:23:25 -04:00
Tom Moor f43614713e perf: Replace keyspace SCAN with single-key cache deletes after commit (#14279)
* perf: Use single-key cache deletes after commit and add afterCommit helper

* fix: Await notification event scheduling without a transaction
2026-10-24 09:07:19 -04:00
Tom Moor 647963d507 fix: Tighten user matching in Slack hooks (#14272)
* fix: Tighten user matching in Slack hooks

* test: Cover linked account lookup in Slack hooks

* test: Fix linked account fixture type
2026-10-24 03:03:22 +00:00
Tom Moor eb290040a1 fix: Make email matching across sign-in providers opt-in (#14270) 2026-10-23 22:21:12 -04:00
Tom Moor cfdb04e3e2 test: Stay under webhook limit in webhookSubscriptions.list test (#14259) 2026-10-22 23:44:31 -04:00
Tom Moor a471da36f2 feat: Name desktop app passkeys by platform with matching icon (#14242)
* feat: Name desktop app passkeys by platform with matching icon

* fix: Only apply desktop passkey name to platform authenticators
2026-10-22 18:31:55 -04:00
Tom Moor 0454badbf6 fix: Scope linked account settings in integration presenter to the owner (#14233) 2026-10-22 08:02:23 -04:00
Tom Moor cf578accf9 chore: Consistent policy checks in integration callbacks (#14221) 2026-10-22 07:27:12 -04:00
Tom Moor f92be38e7b chore: Replace deprecated @octokit/webhooks-types with @octokit/openapi-webhooks-types (#14203) 2026-10-21 18:19:10 -04:00
Tom Moor 1b4171b4de perf: Wait for summary in SlackProcessor only after cheap checks pass (#14188) 2026-10-20 23:24:22 -04:00
Tom Moor e0db189e53 feat: Run passkey login inside the desktop app (#14180)
* Run passkey login inside the desktop app when supported

Desktop apps that configure a platform authenticator expose
isPasskeySupported on the bridge. When available, the WebAuthn ceremony
runs in the app instead of the system browser. If it fails, the user can
still use a passkey from their browser.

* Name passkeys registered in the desktop app

The Chromium Touch ID authenticator reports the same AAGUID as any
Chromium browser, so passkeys from the desktop app were named
"Chromium Browser".

* Allow more than one passkey from the Chromium authenticator

The Chromium Touch ID authenticator reports the same AAGUID on every
device, so users could not register the desktop app on a second Mac.

* Disable adding passkeys in desktop apps without passkey support
2026-10-20 22:57:37 -04:00
Tom Moor 4e52850527 feat: Include collectionId in comment webhook payloads (#14176) 2026-10-20 18:04:14 -04:00
Tom Moor 2f68f32b40 fix: Polish UI copy, casing, and punctuation (#14144)
* fix: Polish UI copy, casing, and punctuation across the app

* fix: Remove duplicate period in API key scope hint
2026-10-19 09:05:24 -04:00
Tom Moor d97c4baad2 perf: Cache permanent Iframely errors for an hour (#14134)
* perf: Cache permanent Iframely errors for an hour

* perf: Cache permanent Iframely errors for a day
2026-10-18 23:57:19 +00:00
Tom Moor 84e8d9e70c chore: Name unfurl plugins for tracing (#14136) 2026-10-18 18:28:20 -04:00
Tom MoorandClaude Opus 5.5 5647621224 chore: Prune redundant comments and type suppressions (#14124)
* chore: Prune redundant comments and normalize lint directives

Removes comments that restate the following line and stale TODOs, drops
the passive event listener feature check now that all supported browsers
support it, and renames eslint directives to oxlint.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BehTjuZwKbN5csMCp3H4QH

* fix: Evaluate restricted team domains at validation time

The restricted email provider list was captured when the model loaded, so
it could not follow the hosting environment and the tests that covered it
never reached the model.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BehTjuZwKbN5csMCp3H4QH

* chore: Replace type suppressions with accurate types

Adds a Concrete helper type for registries of abstract classes, declares
missing Sequelize and refractor typings, uses public ProseMirror APIs, a
typed mock context helper in middleware tests, and a StaticLink component
for sidebar rows being edited.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BehTjuZwKbN5csMCp3H4QH

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-10-17 17:07:39 -04:00
Tom Moor dc6e05aab1 Tidy settings sidebar and AI settings page (#14111)
* chore: Tidy settings sidebar and AI settings page

* fix: Accessible names for theme select and MCP switch
2026-10-17 08:43:44 -04:00
Tom Moor be75e8e0a8 fix: Resolve Slab cross-links and import Slab-hosted attachments (#14109)
* fix: Resolve Slab cross-links and import Slab-hosted attachments

Slab exports links between posts as absolute URLs and file attachments as
signed links, so both stayed pointing at Slab after import. Post links are
now matched to imported documents by slug (or by label for id-only mention
links) and Slab-hosted file links become attachments that are re-hosted.

Also fixes concurrent mention transforms assigning different ids to the
same not-yet-imported document.

* fix: Address review feedback on Slab link and file conversion

Prefer exact slug matches and leave ambiguous slugs unresolved, convert
file links in headings, and keep a toggle's leading text block so its
attachments are still converted.
2026-10-16 17:23:13 -04:00
Tom Moor a717cb0645 fix: Retry Postgres search as a quoted query when there are no results (#14104)
* fix: Retry Postgres search as a quoted query when there are no results

* fix: Keep urls, length and stop words correct in quoted search retry
2026-10-15 23:07:59 -04:00
Tom Moor eceba73a14 chore: Upgrade koa-helmet to v9 and koa-body to v8 (#14046)
* chore: Upgrade koa-helmet to v9 and koa-body to v8

* fix: Keep decimal parsing for pagination limit and offset
2026-10-16 02:11:11 +00:00
Tom Moor 51e4b5864d fix: Resolve Slack user for Post to Channel action (#14095) 2026-10-15 21:14:14 -04:00
Tom MoorandClaude Opus 5.5 9e2565184e chore: Prune stale comments, TODOs, and type suppressions (#14092)
* chore: Remove unused lint disable directives

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Replace TODO type suppressions with typed code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Remove obsolete workaround comments in tests and MediaDimension

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Remove Tippy compatibility props from Tooltip

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Decouple DropdownMenu props from Tooltip and clarify sharing styles

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Remove stale retention TODOs from cleanup tasks

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Register relations synchronously and clarify workaround comments

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Replace Notion import TODOs with descriptive comments

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-10-15 08:54:37 -04:00
Tom Moor 316e4a47d8 fix: Use the slash command token for Slack link previews (#14090)
* fix: Use the slash command token for Slack link previews

* test: Cover newest Slack command integration selection
2026-10-13 23:08:56 -04:00
Tom Moor dccd9fcfe9 chore: Rename titleWithDefault to displayTitle (#14063) 2026-10-13 11:59:44 +00:00
Tom Moor c46fbc6375 fix: Search terms inside dot-separated identifiers (#14072)
* fix: Search terms inside dot-separated identifiers

* fix: Strip leading join operator from search tsquery
2026-10-13 07:56:51 -04:00
Tom Moor f8496ea2f7 feat: Personal collections (#14062)
* feat: Personal collections backend

Adds an owner to collections. A personal collection is private, one per user
per team, created lazily through collections.personal, and only its owner can
see or manage it. Admin bypasses in policies, lists, exports, events, webhooks
and file operations exclude the personal collections of other users. Turning
off the PersonalDocs preference makes the collection read-only.

* test: Access matrix for personal collections

Checks that collection and document endpoints, list and search results, MCP
tools, collaboration and websocket rooms agree with the read policy for the
owner, collaborators, members, admins, guests and other teams.

* feat: Personal collection in the sidebar

Adds a Personal sidebar section that renders the personal collection with the
collection document tree, creates the collection on the first new document,
and keeps it out of the Collections section. Adds the workspace setting, the
personal sidebar context, and hides collection sharing and membership UI for
personal collections.

* fix: Drag and drop in shared with me trees

Anchors the reorder drop cursor inside the row, and prefetches documents on
hover so that nested rows that were never opened can be dragged.

* feat: Personal collection owner for collaborators, no collection page

Presents the owner of the personal collection on documents, so that
collaborators see the owner in the share popover. Root rows in the Personal
section show the default document icon. A personal collection has no page:
the scene shows not found, and the breadcrumb, command bar and delete redirect
no longer link to it.

* fix: Personal sidebar indent and breadcrumb items without a link

Children of rows at depth 0 skip a level so that they start beyond the row
icon. Breadcrumb items without a destination, such as the personal and deleted
collection, are shown as plain text.

* test: Reduce personal collection tests to list paths

Endpoints that authorize a single model are already covered by the policy
tests. Keeps the lists and searches, which filter in queries, and the
presenter.

* test: Move personal collection list tests into collections tests

* feat: Create documents in the personal collection by alias

documents.create, documents.import and the MCP create_document tool accept
the collectionId "personal", which refers to the personal collection of the
user and creates it when it does not exist yet.

* refactor: Remove collections.personal route

The sidebar creates its first personal document with the personal
collectionId alias, so documents.create is the only path that creates the
personal collection.

* feat: Personal collection name, starring, templates and default

Personal collections cannot be starred, renamed or hold templates, and the
PersonalDocs preference is on by default. The app shows collections through a
displayName getter, which is the translated "Personal" for a personal
collection.

* fix: Use the same policy for starring and unstarring collections

* fix: No pins or viewer insights for personal documents

* revert: Show personal collection events in the audit log

Admins with audit access should see events in personal collections, even when
they cannot open the documents.

* fix: Load collection owner in share scopes

* fix: Keep personal collections out of workspace exports and webhooks

Workspace exports skip all personal collections, while an explicit export of
a personal collection stays available to its owner. Events in personal
collections, including attachments and documents moved after queueing, are
never delivered to workspace webhooks. Personal collections cannot be
renamed or made public through any path, cannot hold pins, and are not
offered as mentions.

* Change icon to avatar

* fix: Personal documents cannot be unpublished

* feat: Personal collection context for MCP

Collections are presented with an isPersonal flag, the server instructions
explain the personal collection, and move_document and update_document accept
the personal collectionId alias.

* fix: Keep moved personal exports private and remove pins on move

Document exports record the owner of the personal collection they came from,
so they stay private after the document moves. Moving documents into a
personal collection removes their pins, including pins to home.

* fix: Only create the personal collection in MCP when it is used
2026-10-13 07:53:06 -04:00
Tom Moor 086bd9e9e4 chore: Replace deprecated koa-router with @koa/router v15 (#14042)
* chore: Replace deprecated koa-router with @koa/router v15

* fix: Run optional authentication on all auth provider routes
2026-10-11 16:47:26 -04:00
Tom Moor e571208871 fix: Spelling, grammar, punctuation, and translation string errors (#14017)
* fix: Spelling, grammar, punctuation, and translation string errors

* fix: Remove duplicate period and comma splice from review feedback
2026-10-11 09:07:07 -04:00
Tom Moor b3e0780752 fix: Unhandled rejection when Zapier stylesheet fails to load (#13981)
Fixes OUTLINE-CLOUD-5SK
2026-10-07 03:25:12 +00:00
Tom Moor 45925be395 Restrict account settings routes to session authentication (#13980) 2026-10-06 22:38:03 -04:00
fedbf28a6a fix(storage): destroy attachment row on failed upload in files.create (#13914)
* fix(storage): destroy attachment row on failed upload in files.create

Three throwing paths in files.create (auth failure, size validation,
writeFile error) left the pre-created Attachment row in the database.
The @BeforeDestroy hook already handles storage cleanup safely, so call
attachment.destroy() before throwing in each of those branches.

Fixes #13824

* Potential fix for pull request finding 'Prevent unauthorized deletion of another user's attachment'

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Tom Moor <tom.moor@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-10-05 21:56:04 -04:00
Tom MoorandClaude Opus 5.5 50a7e61d83 chore: Upgrade @linear/sdk to 97.0.0 (#13907)
* chore: Upgrade @linear/sdk to 97.0.0

The SDK is now ESM-only, so the client is loaded via dynamic import to
match other ESM-only server dependencies. Nullable fields are now typed
as null, so the workspace logoUrl is normalised.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B2bXhKp3SJU1EJjv4uoue7

* chore: Require Node 20.19 or newer for native require of ESM packages

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-10-02 09:46:00 -04:00
Tom Moor 0e704e6ed2 perf: Load templates on demand, add fetchAllIfNeeded to stores (#13895)
* perf: Load templates on demand and cache fetchAll results

fetchAll on the base store now returns the first result for repeat calls
with the same params, with a force option for callers that need fresh
data. Templates load when the command bar, document header, or block
menu needs them instead of on every page load.

* Make fetchAll caching opt-in via fetchAllIfNeeded

fetchAll always fetches again. fetchAllIfNeeded returns the previous
result for the same params until a model is added to or removed from
the store. Mount-effect callers for reference lists use it.
2026-09-26 13:41:58 -04:00
Tom Moor bc992fb22a refactor: Add jobId hook to BaseTask for deduplicating queued jobs (#13890)
* refactor: Add jobId hook to BaseTask for deduplicating queued jobs

* fix: Drop jobId from APIImportTask, it re-schedules itself while active
2026-09-25 23:44:16 +00:00
Tom Moor 9562738335 Refine Azure email verification handling (#13883) 2026-09-24 22:59:23 -04:00
Tom MoorandClaude Opus 5 4b4c7d3281 chore: React 19 upgrade (#13562)
* React 19 upgrade

Bumps react and react-dom to 19.2.8, with the dependency changes React 19
requires: react-is 19, @types/react 19, @types/react-dom 19,
react-helmet-async 3 and react-avatar-editor 15 (which now ships its own
types). framer-motion moves to 13 — its v6 types reference React.ReactHTML,
removed from @types/react 19.

The type changes fall into a few classes:

- The global JSX namespace is gone, so JSX.Element becomes React.JSX.Element
  and the custom element declarations move into a module augmentation.
- useRef() now requires an initial value.
- A ref created with a null initial value is typed nullable, so consumers
  that accept one are widened to RefObject<T | null>.
- React.ReactChild was removed; tooltips take React.ReactNode.
- Ref callbacks may only return a cleanup function. react-dnd connectors
  return the connected node, so useDragRef and useDropRef wrap useDrag and
  useDrop and hand back a ref callback.

react-i18next stays on v12: i18next 23 drops compatibilityJSON "v3", which
would rewrite all 64 _plural keys across every locale.

outline-icons, oy-vey and react-waypoint have no release that lists React 19
as a peer. All three render correctly under it; the install reports them as
unmet peers.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Remove react-helmet and forwardRef

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-18 22:22:50 -04:00
Tom Moor 35fe31e56f test: Use unique subdomains in test factories to prevent sporadic collisions (#13765) 2026-09-16 22:39:25 -04:00
Tom Moor 85deb8934b Fix GitLab webhook integration updates (#13764)
* fix GitLab webhook integration updates

* support shared GitLab webhook credentials
2026-09-16 22:11:24 -04:00
Tom Moor ca9317f4cc fix: Clarify missing OAuth state errors (#13734) 2026-09-13 15:53:34 -04:00
Tom Moor 110c332727 fix: Byte range handling for media in Safari (#13695)
* fix: Byte range handling for media in Safari

Safari loads video and audio with byte range requests. Several forms of
Range header were mishandled by files.get: a suffix range fell through to
a full 200 response, a single byte request served the whole file, a range
past the end of the file produced an invalid Content-Range and a truncated
body, and a range starting past the end returned 400 rather than 416.

Also stop the service worker intercepting these requests. Partial
responses cannot be stored by the Cache API, so the route only produced
failed writes, and serving media through a service worker prevents
playback in Safari.

* Refactor to ByteRangeHelper
2026-09-07 20:18:36 -04:00
Tom MoorandClaude Fable 5.1 90f7091316 fix: Signed file downloads rejected when an API key lacks scope for the route (#13681)
* fix: Signed file downloads rejected when an API key lacks scope for the route

Adds a skip option to the auth middleware so routes authorized by other means can ignore credentials on the request, and applies it to signed file requests. Also maps the get method to the read scope.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Restrict skip option to optional authentication

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-06 04:05:12 -04:00
Tom Moor 0319ab170e fix: Missing transaction in GitLabIssueProvider (#13646) 2026-09-04 13:06:05 +00:00
Tom Moor 5669f9ff1d Update SlackListItem.tsx (#13626) 2026-09-03 00:59:45 +00:00
Tom Moor 1eee828f73 fix: Allow null webhook subscription secrets (#13622) 2026-09-02 23:09:14 +00:00
Tom Moor 2dfc26f14b fix: Provision OIDC users with locale claim (#13601) 2026-09-01 02:36:21 -04:00
Tom MoorandClaude Opus 5 f49b047648 feat: Convert @ prefixed Markdown links to mentions on server writes (#13403)
* checkpoint

* feat: Convert @ prefixed links to mentions on server Markdown writes

A Markdown link preceded by "@" now becomes a mention when brought in
through the documents API, MCP, or an import, so an exported mention
survives a round trip instead of degrading to a plain link.

The editor rule creates a generic mention carrying the href, and the
type of resource it points at is resolved by the plugin that recognizes
the URL through a new MentionProvider hook. Mentions of external
resources also serialize to their real URL rather than a mention:// URI,
so the reference resolves outside of Outline.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix: Escape values interpolated into rendered mention HTML

markdown-it leaves markup in a link label intact when html is disabled,
so the label and attributes are escaped before being written into the
tag.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-27 17:42:28 -04:00