Commit Graph
216 Commits
Author SHA1 Message Date
Tom Moor 0d13c183fd chore: Add lint rules for test conventions (#14318) 2026-10-24 14:09:36 -04:00
Tom Moor 4e807ca6fc perf: Copy only the patched path when recreating transforms (#14250)
* perf: Copy only the patched path when recreating transforms

recreateTransform deep copied the whole document for each patch
operation, and diffArrays compared elements with a generic isEqual. Copy
only the containers on the operation path and compare with a JSON-only
equality check. Revision changesets are about 6x faster.

* Use fast-deep-equal in place of a custom JSON equality check

* Restore isJSONEqual, fast-deep-equal throws on null-prototype attrs
2026-10-22 20:33:22 -04:00
Tom Moor 0995a8e36b perf: Reduce traversals and skip unneeded work in ProsemirrorHelper (#14243)
* perf: Reduce traversals and skip unneeded work in ProsemirrorHelper

* fix: Coerce leaf text to a string when checking for text
2026-10-22 18:33:16 -04:00
Tom Moor 3e5de4b1f5 chore: Upgrade refractor from 3 to 5 (#14195)
* chore: Upgrade refractor from 3 to 5

* Revert unrelated tsconfig formatting
2026-10-21 22:56:53 -04:00
Tom Moor 4f4fd88278 chore: Upgrade pako to 3 and remove @types/pako stub (#14199) 2026-10-21 08:36:51 -04:00
Tom Moor 94276a743c fix: Prevent duplicate heading anchor IDs (#14162)
A heading whose text ends in a number could get the same slug as a
numbered duplicate. Heading slugs now come from one HeadingSlugger that
skips taken IDs, and the server section lookup counts nested headings
like the editor does.
2026-10-20 08:28:54 -04:00
Tom Moor 2f68f32b40 fix: Polish UI copy, casing, and punctuation (#14144)
* fix: Polish UI copy, casing, and punctuation across the app

* fix: Remove duplicate period in API key scope hint
2026-10-19 09:05:24 -04:00
Tom Moor e14dfcfcb4 perf: Stop restyling the document on every frame of the sidebar animation (#14132)
The document container and editor exposed their measured widths as inherited
CSS variables, so each frame of a width animation restyled every element in
the document. Full width blocks now use a container unit, and media resizing
measures the editor content width when it is needed.
2026-10-18 17:52:20 -04:00
Tom Moor 97cc147726 feat: Render Mermaid diagrams with Pele (#14126)
* feat: Render Mermaid diagrams with Pele

* fix: Translate empty diagram label

* fix: Prevent diagram flash when editors swap on load
2026-10-18 08:11:41 -04:00
Tom MoorandClaude Opus 5.5 5647621224 chore: Prune redundant comments and type suppressions (#14124)
* chore: Prune redundant comments and normalize lint directives

Removes comments that restate the following line and stale TODOs, drops
the passive event listener feature check now that all supported browsers
support it, and renames eslint directives to oxlint.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BehTjuZwKbN5csMCp3H4QH

* fix: Evaluate restricted team domains at validation time

The restricted email provider list was captured when the model loaded, so
it could not follow the hosting environment and the tests that covered it
never reached the model.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BehTjuZwKbN5csMCp3H4QH

* chore: Replace type suppressions with accurate types

Adds a Concrete helper type for registries of abstract classes, declares
missing Sequelize and refractor typings, uses public ProseMirror APIs, a
typed mock context helper in middleware tests, and a StaticLink component
for sidebar rows being edited.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BehTjuZwKbN5csMCp3H4QH

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-10-17 17:07:39 -04:00
Tom Moor 128c240405 Render uploads with the same component as the uploaded node (#14117)
* feat: Render uploading images and videos with their node component

* fix: Insert uploaded block nodes next to the paragraph instead of inside it

* fix: Insert dropped block nodes on the nearest side of the paragraph

* feat: Fade in uploaded images and videos from their placeholder

* feat: Preview the new image while it replaces an existing one

* fix: Keep the placeholder size and preload pasted images after upload

* fix: Move the selection off an image while an upload replaces it

* feat: Play uploaded videos from the local file in the uploading editor

* feat: Display uploaded images from the local file in the uploading editor

* feat: Soften image and video corners, round them fully when selected

* feat: Render uploading attachments with the attachment component

* feat: Show the file size of an attachment while it uploads

* feat: Show upload progress on the placeholder instead of a toast

* fix: Fade the content of an uploading file but not its progress bar

* fix: Keep the local file of an upload when its placeholder is mapped away

* chore: Simplify upload placeholder state and remove unused progress callback

* Remove test

* fix: Address review feedback on upload placeholders

Expose upload progress to assistive technology outside the inert placeholder, free local files when the editor state is replaced, reuse the fadeIn animation and move the video wrapper class to EditorStyleHelper.

* chore: Move image and PDF wrapper class names to EditorStyleHelper

* feat: Scale in an upload placeholder when it appears

* chore: Make the upload placeholder scale-in more subtle
2026-10-17 12:12:25 -04:00
Tom Moor d7711ee96f perf: Render editor UI from observable state instead of forceUpdate (#14073)
* perf: Coalesce editor React renders into an animation frame

dispatchTransaction ran calculateDir and forceUpdate synchronously on every
transaction, adding a style read and a React render to each keystroke. These
now run in an animation frame, at most once every 50ms.

Refs #14069

* fix: Reset the pending render frame on unmount

StrictMode remounts the same instance, and a stale handle would stop all later renders.

* perf: Render editor UI from observable state instead of forceUpdate

Replace the coalesced animation frame render with an observable editorState.
The editor no longer re-renders its widget tree on every transaction; the
selection toolbar observes the state only while it is active, so updates stay
synchronous and typing with a collapsed caret renders nothing. The floating
toolbar no longer measures the selection while hidden.

Refs #14069
2026-10-17 11:11:46 -04:00
Tom MoorandClaude Opus 5.5 9e2565184e chore: Prune stale comments, TODOs, and type suppressions (#14092)
* chore: Remove unused lint disable directives

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Replace TODO type suppressions with typed code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Remove obsolete workaround comments in tests and MediaDimension

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Remove Tippy compatibility props from Tooltip

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Decouple DropdownMenu props from Tooltip and clarify sharing styles

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Remove stale retention TODOs from cleanup tasks

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Register relations synchronously and clarify workaround comments

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

* chore: Replace Notion import TODOs with descriptive comments

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WJegM4QsoYSKrBKb6eB4CH

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-10-15 08:54:37 -04:00
Tom Moor 22ab9ff592 fix: Do not escape periods inside numbers at the start of a line (#14085) 2026-10-13 18:20:28 -04:00
Tom Moor ee0f099439 fix: Dropped videos without a content type insert as attachments (#14086) 2026-10-13 18:20:24 -04:00
Tom Moor 19d0b337b9 fix: Backspace does not delete RTL text in table cells (#14054)
Table grip and insert widgets at the start of a cell made ProseMirror treat the
grip as the first block of the cell, so RTL deletion was always blocked. The
add row and column controls now also show above the grips while hovered.
2026-10-12 09:40:34 -04:00
Tom Moor d6c0fe71df fix: Repair table cells with invalid spans (#14028)
* fix: Repair table cells with invalid spans

Fixes OUTLINE-CLOUD-AG8
Fixes OUTLINE-CLOUD-D9J

* fix: Check every table on the first edit, lowercase JSDoc params
2026-10-11 10:53:25 -04:00
Tom Moor e571208871 fix: Spelling, grammar, punctuation, and translation string errors (#14017)
* fix: Spelling, grammar, punctuation, and translation string errors

* fix: Remove duplicate period and comma splice from review feedback
2026-10-11 09:07:07 -04:00
Tom Moor 3014a86b99 fix: Preserve lists in table cells on Markdown round-trip (#13978)
* fix: Preserve lists in table cells on Markdown round-trip

* fix: Rebuild alpha lists and lists after a paragraph in table cells
2026-10-06 23:24:34 -04:00
Tom Moor 179d7dd7be fix: Improve table controls around merged cells (#13897)
* wip

* fix: Position grips in merged cells from the rendered layout

* fix: Only merge row and column selections that cover whole rows or columns

* perf: Find merged cell spans without scanning the table map

* refactor: Extract helpers for cells starting in a row or column
2026-09-27 13:10:43 -04:00
Tom Moor 6763206927 fix: Preserve line breaks in Markdown table cells (#13866) 2026-09-24 21:27:32 -04:00
Tom Moor 7e94a38cf6 fix: Editor crash when placeholder targets a position with no node (#13658)
Returning the plugin state instead of undefined keeps the decoration set valid on subsequent transactions.
2026-09-05 00:19:18 +00:00
Tom Moor 2f78b54f30 fix: allow manual sizing of embedded PDFs (#13645) 2026-09-04 09:00:33 -04:00
Donghoon Yoo 24f36dae7e fix: Prevent overlapping nested list markers (#13584) 2026-09-04 07:55:04 -04:00
Tom MoorandClaude Fable 5 b17f2611bf chore: React 18 upgrade (#13559)
* React 18 upgrade

* fix: Force synchronous React rendering in server HTML export

React 18 can defer a legacy ReactDOM.render commit when sync work is
queued, leaving exported component nodes empty. Wrap the render in
flushSync, and flush unmount-scheduled passive effects before global
env cleanup so React never runs without a window.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor: Move server ComponentView to createRoot

ReactDOM.render and unmountComponentAtNode are removed in React 19.
flushSync around root.render keeps the mount synchronous for the
HTML-export path, which reads the DOM immediately after.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Enable CI

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-09-03 01:43:47 -04:00
Tom Moor 92af44f4b6 fix: preserve quoted tables during document patches (#13604) 2026-09-01 03:23:52 -04:00
Tom MoorandClaude Opus 5 84c40c8392 fix: Revision diff mismatching node closing tokens (#13537)
The changeset token encoder cached node type ids in an object created
with a null prototype, but tested for a cache miss with `=== null`. The
miss reads as undefined, so the cache was never filled and every node
end encoded to undefined — making the closing token of any node compare
equal to that of any other.

As a result revision diffs could omit a node's closing token when its
type changed, and attribute an inserted wrapper's closing token to the
node it wraps.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-23 16:29:21 -04:00
Tom Moor b5118fd4f2 Refactor multiplayer facade to spec (#13534) 2026-08-23 13:07:20 -04:00
Tom MoorandClaude Opus 5 f6ad3cb6e1 Improvements to mobile formatting toolbar (#13533)
* fix: Selection toolbar not displaying on mobile

The mobile branch of FloatingToolbar rendered nothing until `position.visible`
was true, but `usePosition` only reports a visible position once the menu
element has been measured through `menuRef`. On desktop the wrapper is always
mounted (it animates in via opacity) so the ref is populated on first render,
while on mobile the toolbar is the only thing that mounts the ref — leaving it
permanently null and the bar never displayed.

Gate the mobile bar on there being toolbar content instead. Position is
irrelevant on mobile: the bar is fixed to the bottom of the viewport and its
vertical offset is owned by useKeyboardStickyOffset.

Also size the bar with border-box and center its content vertically, so the
declared 60px is the height of the bar rather than 60px of content plus
padding with the buttons pinned to the top.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GhGyxA663bMFZ1NxBhLAoF

* fix: Keep the mobile selection toolbar visible while editing

On mobile the toolbar is a bar docked above the on-screen keyboard rather than
a floating menu anchored to the selection, but it was only rendered while
something was selected — so it appeared and vanished as the selection came and
went while typing.

The formatting menu was already written for this: `canFormatBlock` shows
headings, quotes, toggles and list indent/outdent precisely when the selection
is empty on mobile, mirroring `canFormatInline` for selected text. That branch
was unreachable, as an empty selection always resolved the toolbar to nothing.

Show the menu whenever the editor is focused on mobile, so the bar carries
block formatting for a bare cursor and swaps to inline formatting on selection.
Visibility is derived at render rather than folded into `activeToolbar` so that
focus moving into the link editor's input cannot tear down a toolbar the user
opened. Focus is threaded to widgets through WidgetProps.

Tapping the bar now also prevents the default action of mousedown, keeping
focus (and the keyboard) in the editor. Without it a tap would blur the editor
and unmount the bar before the tap became a click; fields inside the bar are
excluded so the link editor still takes focus.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GhGyxA663bMFZ1NxBhLAoF

* fix: Mobile toolbar is not visible

* Update mobile toolbar styling
fix: Does not account for stored marks

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-08-23 11:20:30 -04:00
Tom Moor 5ee3f1a5d9 perf: Refactor y-prosemirror loading (#13521)
* wip

* perf: Refactor y-prosemirror loading
2026-08-21 20:49:29 -04:00
Tom Moor 8421c2b482 fix: RangeError restoring editor selection after focus (#13487)
Focusing the editor can flush pending DOM changes, so the selection
captured before the focus call may no longer point at the current
document. Only restore it when the document is unchanged.

Fixes OUTLINE-CLOUD-CP6
2026-08-19 08:06:38 -04:00
Tom MoorandClaude Opus 5 0b44338a16 fix: Uncaught error handling messages from the diagram editor (#13483)
* fix: Uncaught error handling messages from the diagram editor

The diagram editor also posts plain text messages, such as "ready", which
were passed straight to JSON.parse and threw from the window listener.

- Ignore any message that is not a JSON object.
- Ignore messages when the editor window is not open. A blocked popup left
  the window null, which matched the null source of unrelated messages.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix: Validate messages from the diagram editor against a schema

Replaces the message interface with a zod schema, so arrays and known
fields with unexpected types are rejected rather than trusted.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-18 19:55:57 -04:00
Tom MoorandClaude Opus 5 eaad1a71dc React SSR editor nodes (#13113)
* Render React node views in server-side HTML export

Passes nodeViews to the headless EditorView used for export so that nodes
with a React component render with it, matching the editor, and falling
back to toDOM when a component cannot render server-side.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Let nodes opt out of component rendering in static HTML

Replaces the hardcoded set of node names in the server nodeViews factory with
an allowComponentInStaticHTML getter on Extension, so a node declares the
behavior alongside its own definition rather than in a server file that does
not know about it.

Mention opts out: its component requires stores and a router, so it always
threw and fell back to toDOM, at the cost of a React render, an exception and
a log line per node. A document with 100 mentions now exports in ~12ms rather
than ~25ms and emits no warnings.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Yield one less macrotask turn when flushing React effects

Only two turns are needed: the first flushes passive effects, the second fires
Frame's own setTimeout(0) whose setState commits the iframe. The third turn
absorbed nothing that the components produce.

Each turn is roughly a millisecond of idle time held inside the render lock, on
every export — including plain documents, share page SSR and notification
emails — so dropping it takes a small export from ~6ms to ~4ms.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-16 16:36:13 -04:00
Tom Moor df8f8848ef fix: Crash when pasting a single block into the document title (#13451)
Removing the first node from the pasted slice kept the original open
depths, which are no longer valid for the remaining content. When the
clipboard held a single top-level node the content became empty while
openEnd stayed above zero, and ProseMirror walked into a null child.

Fixes OUTLINE-CLOUD-51V
2026-08-15 20:23:16 -04:00
Tom MoorandClaude Opus 5 60089edac8 fix: Pasting a table from Google Sheets does not create a table (#13443)
* fix: Pasting a table from Google Sheets does not create a table

Spreadsheet cells containing currency amounts caused isMarkdown to
misread the tab-separated plain text flavour of the clipboard as inline
LaTeX, so the paste handler discarded the HTML table and reparsed the
text as Markdown.

Tighten the LaTeX heuristic to require delimiters that hug their content
and a closing delimiter not followed by a digit, and always prefer the
HTML parser when the clipboard HTML contains a table.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Remove lookbehind in regex

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-15 16:29:17 -04:00
Tom MoorandClaude Fable 5 7764c95e80 perf: Skip revision diff when too expensive to compute (#13432)
* fix: Skip revision diff when too expensive to compute

Recreating steps from a JSON patch copies and validates the full document
once per operation, so a structure collapse on a very large document could
block the worker event loop for minutes. Skip the changeset when the
product of operation count and document size exceeds a bound, and send
notification emails without the inline preview in that case.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* perf: Apply complexity guard to every patch computation

Centralize patch creation and the maxComplexity check in recalculateOps
so the recomputed patch in addSetNodeMarkup is bounded as well.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-14 17:56:16 -04:00
Tom Moor 63486f29b8 fix: Code fence markdown serialization is not round-trip stable (#13434)
- Serialize code fences longer than any backtick run in the content, so
  content lines cannot terminate the fence early on reparse
- Reduce the fence info string and language attribute to a single safe
  token when parsing and serializing
- Share the markdown parser and serializer through the editor test helper
2026-08-14 17:56:05 -04:00
Tom Moor 1276ce277f feat: Allow language shortcut when creating code block with backticks (#13400)
* feat: Trigger code block on space after backticks, allow language shortcut

* fix: Use own-property check for language lookup
2026-08-12 22:12:53 -04:00
Tom MoorandClaude Opus 5 5a6182c0dc fix: Table cell background pasted as a text highlight (#13307)
* fix: Table cell background pasted as text highlight

A background color styled on a table cell by an external application was
dropped, while the matching background on the span inside the cell became a
highlight on the text – rendered yellow, as the color did not match a preset.

Cell backgrounds are now read from pasted HTML onto the cell, and only a
background that matches a highlight preset creates a highlight mark.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix: Skip unpainted ancestors when comparing backgrounds

An ancestor with a transparent or unparseable background ended the search, so
shading painted higher up – such as on a table cell – was missed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-05 19:03:45 -04:00
Tom MoorandClaude Fable 5 73f960a544 fix: Invalid sort comparator for frequently used items (#13258)
* fix: Invalid sort comparator for frequently used items (#13241)

Extracts frequency tracking for icons, emojis, and code languages into a
shared FrequencyTracker with a spec-compliant, stable sort.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Snapshot frequently used icons while picker is open

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Sync frequent custom emojis to tracked ids, preserving order

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-02 08:43:28 -04:00
Tom Moor 17accab55a fix: Strip comments for diffing (#13212)
* fix: Strip comments for diffing

* feedback
2026-07-31 08:03:16 -04:00
Tom MoorandClaude 82419bbb0f fix: Don't report failed dimension loading to Sentry (#13185)
Image and video dimension loading failures now warn and resolve undefined
rather than rejecting, which surfaced as unhandled errors in Sentry.

Co-authored-by: Claude <noreply@anthropic.com>
2026-07-28 17:59:18 -04:00
Tom Moor 9884e0379f perf: Memory usage fixes (#13101)
* fix: Module level cache in headingToSlug

* fix: Remove retained full User and Team model on every ws connection

* feedback
2026-07-23 08:14:35 -04:00
Tom Moor aa02544eaf fix: Mermaid appears twice in language picker (#13000) 2026-07-13 20:59:28 -04:00
Tom MoorandClaude Opus 4.8 46b6fcfe9c feat: Allow matching block input rules after soft-break (#12925)
* feat: Allow matching block input rules after soft-break

* fix PR feedback, math block handling

* perf: stop soft-break scan at the cursor position

Replace parent.forEach with a manual loop that breaks once past the
cursor, avoiding unnecessary per-keystroke iteration over inline nodes
after the cursor in large blocks.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-08 08:30:30 -04:00
Tom MoorandClaude Opus 4.8 7cff0911cd fix: Notion import crash on empty table ("Index 0 out of range") (#12775)
An empty Notion table was converted to a schema-invalid table node with
no rows. Node.fromJSON accepts it, but Markdown serialization then crashed
in renderTable's node.child(0), surfacing only "Index 0 out of range for <>".

Drop empty tables in the Notion converter, and guard renderTable against
tables with no rows so any source is handled safely.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-22 18:34:23 -04:00
Tom Moor bd013dbfa5 fix: Remove quote flattening on markdown serialization (#12774)
* fix: Remove quote flattening on markdown serialization

closes #12773

* PR feedback
2026-06-21 18:36:00 -04:00
Tom Moor 3d9789e8cf chore: Switch prettier -> oxfmt (#12771) 2026-06-21 09:29:52 -04:00
Tom Moor b7df005ad3 Remove heading folding (#12729) 2026-06-20 11:26:32 -04:00
Tom Moor 0ba430e111 fix: Newlines in block fences in table cells (#12740)
* fix: Newlines in block fences in table cells

closes #12736

* refactor
2026-06-18 18:21:50 -04:00