mirror of
https://github.com/outline/outline.git
synced 2026-11-21 13:34:02 +03:00
* Update Switch component onChange handler to use boolean callback - Remove synthetic event handling from Switch component - Update onChange signature to (checked: boolean) => void - Update all call points across the codebase: - PublicAccess.tsx: Updated handlers for indexing, showLastModified, and published switches - Security.tsx: Created individual handlers for all security preferences - Preferences.tsx: Created individual handlers for user preferences - CollectionForm.tsx: Added createSwitchRegister helper for react-hook-form compatibility - TemplatizeDialog: Updated publish handler - DocumentMenu.tsx: Added handlers for embeds and full-width toggles - Search.tsx: Updated SearchTitlesFilter handler - Application.tsx: Added createSwitchRegister helper - Details.tsx: Updated public branding handler - Features.tsx: Created individual handlers for seamless edit and commenting - OAuthClientForm.tsx: Added createSwitchRegister helper - Maintained backward compatibility with react-hook-form - Improved type safety and code clarity * Fix ESLint floating promise errors - Add void operator to onChange call in CollectionForm.tsx - Add void operator to document.save call in DocumentMenu.tsx These changes fix the @typescript-eslint/no-floating-promises errors while maintaining the existing functionality. * Fix Switch component onChange handlers in remaining files - Updated DocumentCopy.tsx handlers to use boolean parameter - Updated Notifications.tsx to use closure pattern for event types - Updated SlackListItem.tsx to use closure pattern for event names - All TypeScript errors resolved * Refactor createSwitchRegister into utils/forms - Created shared utility function in app/utils/forms.ts - Removed duplicate implementations from CollectionForm, Application, and OAuthClientForm - Updated all usage points to use the shared utility - Improved TypeScript typing with Record<string, unknown> - Fixed imports and removed unused variables - Maintained existing functionality while reducing code duplication * Fix TypeScript errors in createSwitchRegister utility - Updated generic constraint from Record<string, unknown> to FieldValues - Added Path import from react-hook-form for proper type safety - Fixed parameter type from keyof TFormData to Path<TFormData> - Improved type compatibility with react-hook-form's UseFormRegister Resolves TypeScript compilation errors in CI pipeline. * Remove unnecessary handlePublishChange callbacks - Removed handlePublishChange wrapper in DocumentCopy.tsx - Removed handlePublishChange wrapper in TemplatizeDialog/index.tsx - Updated Switch components to use setPublish directly - Simplified code by leveraging boolean callback from Switch component Since Switch now passes boolean directly, no need for intermediate callbacks. * Address review feedback: simplify callbacks and fix fullWidth behavior 1. DocumentCopy.tsx: - Remove handleRecursiveChange callback wrapper - Use setRecursive directly with Switch component 2. DocumentMenu.tsx: - Add void user.save() to persist user preference - Add document.fullWidth = checked for optimistic update behavior Both changes leverage the boolean callback from Switch component properly. * Update Security.tsx * i18n --------- Co-authored-by: codegen-sh[bot] <131295404+codegen-sh[bot]@users.noreply.github.com> Co-authored-by: Tom Moor <tom@getoutline.com>
144 lines
4.0 KiB
TypeScript
144 lines
4.0 KiB
TypeScript
import { observer } from "mobx-react";
|
|
import { useEffect } from "react";
|
|
import { Controller, useForm } from "react-hook-form";
|
|
import { useTranslation } from "react-i18next";
|
|
import { OAuthClientValidation } from "@shared/validations";
|
|
import OAuthClient from "~/models/oauth/OAuthClient";
|
|
import ImageInput from "~/scenes/Settings/components/ImageInput";
|
|
import Button from "~/components/Button";
|
|
import Flex from "~/components/Flex";
|
|
import Input, { LabelText } from "~/components/Input";
|
|
import { createSwitchRegister } from "~/utils/forms";
|
|
import isCloudHosted from "~/utils/isCloudHosted";
|
|
import Switch from "../Switch";
|
|
|
|
export interface FormData {
|
|
name: string;
|
|
developerName: string;
|
|
developerUrl: string;
|
|
description: string;
|
|
avatarUrl: string;
|
|
redirectUris: string[];
|
|
published: boolean;
|
|
}
|
|
|
|
export const OAuthClientForm = observer(function OAuthClientForm_({
|
|
handleSubmit,
|
|
oauthClient,
|
|
}: {
|
|
handleSubmit: (data: FormData) => void;
|
|
oauthClient?: OAuthClient;
|
|
}) {
|
|
const { t } = useTranslation();
|
|
|
|
const {
|
|
register,
|
|
handleSubmit: formHandleSubmit,
|
|
formState,
|
|
getValues,
|
|
setFocus,
|
|
setError,
|
|
control,
|
|
} = useForm<FormData>({
|
|
mode: "all",
|
|
defaultValues: {
|
|
name: oauthClient?.name ?? "",
|
|
description: oauthClient?.description ?? "",
|
|
avatarUrl: oauthClient?.avatarUrl ?? "",
|
|
redirectUris: oauthClient?.redirectUris ?? [],
|
|
published: oauthClient?.published ?? false,
|
|
},
|
|
});
|
|
|
|
useEffect(() => {
|
|
setTimeout(() => setFocus("name", { shouldSelect: true }), 100);
|
|
}, [setFocus]);
|
|
|
|
return (
|
|
<form onSubmit={formHandleSubmit(handleSubmit)}>
|
|
<>
|
|
<label style={{ marginBottom: "1em" }}>
|
|
<LabelText>{t("Icon")}</LabelText>
|
|
<Controller
|
|
control={control}
|
|
name="avatarUrl"
|
|
render={({ field }) => (
|
|
<ImageInput
|
|
onSuccess={(url) => field.onChange(url)}
|
|
onError={(err) => setError("avatarUrl", { message: err })}
|
|
model={{
|
|
id: oauthClient?.id,
|
|
avatarUrl: field.value,
|
|
initial: getValues().name[0],
|
|
}}
|
|
borderRadius={0}
|
|
/>
|
|
)}
|
|
/>
|
|
</label>
|
|
<Input
|
|
type="text"
|
|
label={t("Name")}
|
|
placeholder={t("My App")}
|
|
{...register("name", {
|
|
required: true,
|
|
maxLength: OAuthClientValidation.maxNameLength,
|
|
})}
|
|
autoComplete="off"
|
|
autoFocus
|
|
flex
|
|
/>
|
|
<Input
|
|
type="text"
|
|
label={t("Tagline")}
|
|
placeholder={t("A short description")}
|
|
{...register("description", {
|
|
maxLength: OAuthClientValidation.maxDescriptionLength,
|
|
})}
|
|
flex
|
|
/>
|
|
<Controller
|
|
control={control}
|
|
name="redirectUris"
|
|
render={({ field }) => (
|
|
<Input
|
|
type="textarea"
|
|
label={t("Callback URLs")}
|
|
placeholder="https://example.com/callback"
|
|
ref={field.ref}
|
|
value={field.value.join("\n")}
|
|
rows={Math.max(2, field.value.length + 1)}
|
|
onChange={(event) => {
|
|
field.onChange(event.target.value.split("\n"));
|
|
}}
|
|
required
|
|
/>
|
|
)}
|
|
/>
|
|
{isCloudHosted && (
|
|
<Switch
|
|
{...createSwitchRegister(register, "published")}
|
|
label={t("Published")}
|
|
note={t("Allow this app to be installed by other workspaces")}
|
|
/>
|
|
)}
|
|
</>
|
|
|
|
<Flex justify="flex-end">
|
|
<Button
|
|
type="submit"
|
|
disabled={formState.isSubmitting || !formState.isValid}
|
|
>
|
|
{oauthClient
|
|
? formState.isSubmitting
|
|
? `${t("Saving")}…`
|
|
: t("Save")
|
|
: formState.isSubmitting
|
|
? `${t("Creating")}…`
|
|
: t("Create")}
|
|
</Button>
|
|
</Flex>
|
|
</form>
|
|
);
|
|
});
|