mirror of
https://github.com/outline/outline.git
synced 2026-11-21 13:34:02 +03:00
* Update Switch component onChange handler to use boolean callback - Remove synthetic event handling from Switch component - Update onChange signature to (checked: boolean) => void - Update all call points across the codebase: - PublicAccess.tsx: Updated handlers for indexing, showLastModified, and published switches - Security.tsx: Created individual handlers for all security preferences - Preferences.tsx: Created individual handlers for user preferences - CollectionForm.tsx: Added createSwitchRegister helper for react-hook-form compatibility - TemplatizeDialog: Updated publish handler - DocumentMenu.tsx: Added handlers for embeds and full-width toggles - Search.tsx: Updated SearchTitlesFilter handler - Application.tsx: Added createSwitchRegister helper - Details.tsx: Updated public branding handler - Features.tsx: Created individual handlers for seamless edit and commenting - OAuthClientForm.tsx: Added createSwitchRegister helper - Maintained backward compatibility with react-hook-form - Improved type safety and code clarity * Fix ESLint floating promise errors - Add void operator to onChange call in CollectionForm.tsx - Add void operator to document.save call in DocumentMenu.tsx These changes fix the @typescript-eslint/no-floating-promises errors while maintaining the existing functionality. * Fix Switch component onChange handlers in remaining files - Updated DocumentCopy.tsx handlers to use boolean parameter - Updated Notifications.tsx to use closure pattern for event types - Updated SlackListItem.tsx to use closure pattern for event names - All TypeScript errors resolved * Refactor createSwitchRegister into utils/forms - Created shared utility function in app/utils/forms.ts - Removed duplicate implementations from CollectionForm, Application, and OAuthClientForm - Updated all usage points to use the shared utility - Improved TypeScript typing with Record<string, unknown> - Fixed imports and removed unused variables - Maintained existing functionality while reducing code duplication * Fix TypeScript errors in createSwitchRegister utility - Updated generic constraint from Record<string, unknown> to FieldValues - Added Path import from react-hook-form for proper type safety - Fixed parameter type from keyof TFormData to Path<TFormData> - Improved type compatibility with react-hook-form's UseFormRegister Resolves TypeScript compilation errors in CI pipeline. * Remove unnecessary handlePublishChange callbacks - Removed handlePublishChange wrapper in DocumentCopy.tsx - Removed handlePublishChange wrapper in TemplatizeDialog/index.tsx - Updated Switch components to use setPublish directly - Simplified code by leveraging boolean callback from Switch component Since Switch now passes boolean directly, no need for intermediate callbacks. * Address review feedback: simplify callbacks and fix fullWidth behavior 1. DocumentCopy.tsx: - Remove handleRecursiveChange callback wrapper - Use setRecursive directly with Switch component 2. DocumentMenu.tsx: - Add void user.save() to persist user preference - Add document.fullWidth = checked for optimistic update behavior Both changes leverage the boolean callback from Switch component properly. * Update Security.tsx * i18n --------- Co-authored-by: codegen-sh[bot] <131295404+codegen-sh[bot]@users.noreply.github.com> Co-authored-by: Tom Moor <tom@getoutline.com>
136 lines
4.0 KiB
TypeScript
136 lines
4.0 KiB
TypeScript
import flatten from "lodash/flatten";
|
||
import { observer } from "mobx-react";
|
||
import * as React from "react";
|
||
import { Trans, useTranslation } from "react-i18next";
|
||
import { toast } from "sonner";
|
||
import styled from "styled-components";
|
||
import { NavigationNode } from "@shared/types";
|
||
import Document from "~/models/Document";
|
||
import { FlexContainer, Footer, StyledText } from "~/scenes/DocumentMove";
|
||
import Button from "~/components/Button";
|
||
import DocumentExplorer from "~/components/DocumentExplorer";
|
||
import useCollectionTrees from "~/hooks/useCollectionTrees";
|
||
import useStores from "~/hooks/useStores";
|
||
import { flattenTree } from "~/utils/tree";
|
||
import Switch from "./Switch";
|
||
import Text from "./Text";
|
||
|
||
type Props = {
|
||
/** The original document to duplicate */
|
||
document: Document;
|
||
onSubmit: (documents: Document[]) => void;
|
||
};
|
||
|
||
function DocumentCopy({ document, onSubmit }: Props) {
|
||
const { t } = useTranslation();
|
||
const { policies } = useStores();
|
||
const collectionTrees = useCollectionTrees();
|
||
const [publish, setPublish] = React.useState<boolean>(!!document.publishedAt);
|
||
const [recursive, setRecursive] = React.useState<boolean>(true);
|
||
const [selectedPath, selectPath] = React.useState<NavigationNode | null>(
|
||
null
|
||
);
|
||
|
||
const items = React.useMemo(() => {
|
||
const nodes = flatten(collectionTrees.map(flattenTree)).filter((node) =>
|
||
node.collectionId
|
||
? policies.get(node.collectionId)?.abilities.createDocument
|
||
: true
|
||
);
|
||
|
||
if (document.isTemplate) {
|
||
return nodes
|
||
.filter((node) => node.type === "collection")
|
||
.map((node) => ({ ...node, children: [] }));
|
||
}
|
||
return nodes;
|
||
}, [policies, collectionTrees, document.isTemplate]);
|
||
|
||
const copy = async () => {
|
||
if (!selectedPath) {
|
||
toast.message(t("Select a location to copy"));
|
||
return;
|
||
}
|
||
|
||
try {
|
||
const result = await document.duplicate({
|
||
publish,
|
||
recursive,
|
||
title: document.title,
|
||
collectionId: selectedPath.collectionId,
|
||
...(selectedPath.type === "document"
|
||
? { parentDocumentId: selectedPath.id }
|
||
: {}),
|
||
});
|
||
|
||
toast.success(t("Document copied"));
|
||
onSubmit(result);
|
||
} catch (_err) {
|
||
toast.error(t("Couldn’t copy the document, try again?"));
|
||
}
|
||
};
|
||
|
||
return (
|
||
<FlexContainer column>
|
||
<DocumentExplorer
|
||
items={items}
|
||
onSubmit={copy}
|
||
onSelect={selectPath}
|
||
defaultValue={document.parentDocumentId || document.collectionId || ""}
|
||
/>
|
||
<OptionsContainer>
|
||
{!document.isTemplate && (
|
||
<>
|
||
{document.collectionId && (
|
||
<Text size="small">
|
||
<Switch
|
||
name="publish"
|
||
label={t("Publish")}
|
||
labelPosition="right"
|
||
checked={publish}
|
||
onChange={setPublish}
|
||
/>
|
||
</Text>
|
||
)}
|
||
{document.publishedAt && document.childDocuments.length > 0 && (
|
||
<Text size="small">
|
||
<Switch
|
||
name="recursive"
|
||
label={t("Include nested documents")}
|
||
labelPosition="right"
|
||
checked={recursive}
|
||
onChange={setRecursive}
|
||
/>
|
||
</Text>
|
||
)}
|
||
</>
|
||
)}
|
||
</OptionsContainer>
|
||
<Footer justify="space-between" align="center" gap={8}>
|
||
<StyledText type="secondary">
|
||
{selectedPath ? (
|
||
<Trans
|
||
defaults="Copy to <em>{{ location }}</em>"
|
||
values={{ location: selectedPath.title }}
|
||
components={{ em: <strong /> }}
|
||
/>
|
||
) : (
|
||
t("Select a location to copy")
|
||
)}
|
||
</StyledText>
|
||
<Button disabled={!selectedPath} onClick={copy}>
|
||
{t("Copy")}
|
||
</Button>
|
||
</Footer>
|
||
</FlexContainer>
|
||
);
|
||
}
|
||
|
||
const OptionsContainer = styled.div`
|
||
margin: 16px 0 8px 0;
|
||
padding-left: 24px;
|
||
padding-right: 24px;
|
||
`;
|
||
|
||
export default observer(DocumentCopy);
|