Files
Tom MoorandClaude Opus 5.5 5647621224 chore: Prune redundant comments and type suppressions (#14124)
* chore: Prune redundant comments and normalize lint directives

Removes comments that restate the following line and stale TODOs, drops
the passive event listener feature check now that all supported browsers
support it, and renames eslint directives to oxlint.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BehTjuZwKbN5csMCp3H4QH

* fix: Evaluate restricted team domains at validation time

The restricted email provider list was captured when the model loaded, so
it could not follow the hosting environment and the tests that covered it
never reached the model.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BehTjuZwKbN5csMCp3H4QH

* chore: Replace type suppressions with accurate types

Adds a Concrete helper type for registries of abstract classes, declares
missing Sequelize and refractor typings, uses public ProseMirror APIs, a
typed mock context helper in middleware tests, and a StaticLink component
for sidebar rows being edited.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BehTjuZwKbN5csMCp3H4QH

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-10-17 17:07:39 -04:00

99 lines
2.3 KiB
TypeScript

import emailProviders from "email-providers";
import type {
InferAttributes,
InferCreationAttributes,
SaveOptions,
} from "sequelize";
import {
Column,
DataType,
Table,
BelongsTo,
ForeignKey,
Is,
NotEmpty,
BeforeValidate,
BeforeCreate,
} from "sequelize-typescript";
import { TeamValidation } from "@shared/validations";
import env from "@server/env";
import { ValidationError } from "@server/errors";
import { LockHelper } from "@server/storage/LockHelper";
import Team from "./Team";
import User from "./User";
import IdModel from "./base/IdModel";
import IsFQDN from "./validators/IsFQDN";
import Length from "./validators/Length";
@Table({ tableName: "team_domains", modelName: "team_domain" })
class TeamDomain extends IdModel<
InferAttributes<TeamDomain>,
Partial<InferCreationAttributes<TeamDomain>>
> {
@Is("notRestricted", (value: string) => {
if (env.isCloudHosted && emailProviders.includes(value)) {
throw new Error("You chose a restricted domain, please try another.");
}
})
@NotEmpty
@Length({
max: TeamValidation.maxDomainLength,
msg: `name must be ${TeamValidation.maxDomainLength} characters or less`,
})
@IsFQDN
@Column(DataType.STRING)
name: string;
// associations
@BelongsTo(() => Team, "teamId")
team: Team;
@ForeignKey(() => Team)
@Column(DataType.UUID)
teamId: string;
@BelongsTo(() => User, "createdById")
createdBy: User;
@ForeignKey(() => User)
@Column(DataType.UUID)
createdById: string;
// hooks
@BeforeValidate
static async cleanupDomain(model: TeamDomain) {
model.name = model.name.toLowerCase().trim();
}
@BeforeCreate
static async checkLimit(model: TeamDomain, options: SaveOptions) {
if (!env.isCloudHosted) {
return;
}
const { transaction } = options;
// Serialize concurrent creation for the team, otherwise every request can
// read the same count and pass the check.
await LockHelper.acquire(
model.sequelize,
`teamDomains:${model.teamId}`,
transaction
);
const count = await this.count({
where: { teamId: model.teamId },
transaction,
});
if (count >= TeamValidation.maxDomains) {
throw ValidationError(
`You have reached the limit of ${TeamValidation.maxDomains} domains`
);
}
}
}
export default TeamDomain;