Files
Tom MoorandClaude Opus 4.8 0ffe077f6e fix: Various checkbox fixes (#12679)
* fix: Checkbox list item margin click and nested "Hide completed"

Clicking the margin beside a checkbox now places the cursor at the start
of the list item instead of being a dead zone, and shows a text cursor.

The "Hide completed" toggle no longer appears on a parent checkbox list
when completed items live in a checkbox list nested via a regular list
(checkbox -> list -> checkbox); those inner lists manage their own toggle.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Checkbox improvements

* fix: Address PR review on checkbox NodeView

- Remove the checkbox click listener in CheckboxItemView.destroy() to
  avoid leaks when items are deleted/replaced.
- Globally escape "#" in the SSR fallback data URIs (replace all, not
  just the first occurrence).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-13 13:37:49 -04:00

127 lines
2.9 KiB
TypeScript

import type Token from "markdown-it/lib/token.mjs";
import type {
NodeSpec,
Node as ProsemirrorNode,
NodeType,
} from "prosemirror-model";
import {
splitListItem,
sinkListItem,
liftListItem,
} from "prosemirror-schema-list";
import { Plugin } from "prosemirror-state";
import { toggleCheckboxItems } from "../commands/toggleCheckboxItems";
import type { MarkdownSerializerState } from "../lib/markdown/serializer";
import checkboxRule from "../rules/checkboxes";
import { CheckboxItemView } from "./CheckboxItemView";
import Node from "./Node";
export default class CheckboxItem extends Node {
get name() {
return "checkbox_item";
}
get schema(): NodeSpec {
return {
attrs: {
checked: {
default: false,
},
},
content: "block+",
defining: true,
draggable: true,
parseDOM: [
{
tag: `li[data-type="${this.name}"]`,
getAttrs: (dom: HTMLLIElement) => ({
checked: dom.className.includes("checked"),
}),
},
],
// Rendering and interaction are handled by CheckboxItemView; this spec is
// only used for serialization (e.g. clipboard, HTML export).
toDOM: (node) => [
"li",
{
"data-type": this.name,
class: node.attrs.checked ? "checked" : undefined,
},
[
"span",
{ contentEditable: "false" },
[
"span",
{
class: "checkbox",
role: "checkbox",
"aria-checked": node.attrs.checked ? "true" : "false",
},
],
],
["div", 0],
],
};
}
get rulePlugins() {
return [checkboxRule];
}
get plugins() {
return [
new Plugin({
props: {
nodeViews: {
[this.name]: (node, view, getPos) =>
new CheckboxItemView(node, view, getPos),
},
},
}),
];
}
commands({ type }: { type: NodeType }) {
return {
indentCheckboxList: () => sinkListItem(type),
outdentCheckboxList: () => liftListItem(type),
};
}
keys({ type }: { type: NodeType }) {
return {
Enter: splitListItem(type, {
checked: false,
}),
Tab: sinkListItem(type),
"Mod-Enter": toggleCheckboxItems(type),
"Shift-Tab": liftListItem(type),
"Mod-]": sinkListItem(type),
"Mod-[": liftListItem(type),
};
}
toMarkdown(state: MarkdownSerializerState, node: ProsemirrorNode) {
state.append(node.attrs.checked ? "[x] " : "[ ] ");
if (state.inTable) {
node.forEach((block, _, i) => {
if (i > 0) {
state.append(" ");
}
state.renderInline(block);
});
return;
}
state.renderContent(node);
}
parseMarkdown() {
return {
block: "checkbox_item",
getAttrs: (tok: Token) => ({
checked: tok.attrGet("checked") ? true : undefined,
}),
};
}
}