Files
Tom Moor a374ce9b46 fix: Viewers attributed as editors when their editor repairs remote changes (#14424)
* fix: Viewers attributed as editors when their editor repairs remote changes

* fix: Rescan after remote changes and assign block ids when parsing markdown

* chore: Import uuid as generateUuid in ToggleBlock

* refactor: Add RepairPlugin to repair only on local changes, checking remote changes for pending repairs

* fix: Assign block ids on the server so patches keep existing ids, keep unchanged mention ids

* fix: Store API edits in the editor's trailing node form
2026-10-30 22:27:31 -04:00

92 lines
2.6 KiB
TypeScript

import type { Node } from "prosemirror-model";
import type { EditorState, Transaction } from "prosemirror-state";
import { TableMap } from "prosemirror-tables";
import { isValidCellSpan } from "../lib/table";
import { RepairPlugin } from "./RepairPlugin";
/**
* A ProseMirror plugin that fixes various ways that tables can end up in an incorrect state:
*
* - The last column in a table should fill the remaining width
* - Header cells should only exist in the first row or column
* - Cells should span at least one row and column
*/
export class FixTablesPlugin extends RepairPlugin {
constructor() {
super({
needsRepair: (node, pos, state) => {
if (node.type.spec.tableRole !== "table") {
return false;
}
const tr = state.tr;
fixTable(state, node, pos, tr);
return tr.docChanged;
},
repair: (state, tables) => {
const tr = state.tr;
tables.forEach(({ node, pos }) => fixTable(state, node, pos, tr));
return tr.docChanged ? tr : null;
},
});
}
}
function fixTable(
state: EditorState,
table: Node,
pos: number,
tr: Transaction
) {
const map = TableMap.get(table);
// If the table has only one column, remove the colwidth attribute on all cells
if (map.width === 1) {
const cells = map.cellsInRect({
left: 0,
top: 0,
right: 1,
bottom: map.height,
});
cells.forEach((offset) => {
const cellPos = pos + 1 + offset;
const node = state.doc.nodeAt(cellPos);
if (node?.attrs.colwidth) {
tr.setNodeMarkup(cellPos, undefined, {
...node?.attrs,
colwidth: null,
});
}
});
}
// If the table has header cells that are not in the first row or column
// then convert them to regular cells
const cellPositions = map.cellsInRect({
left: 1,
top: 1,
right: map.width,
bottom: map.height,
});
for (let i = 0; i < cellPositions.length; i++) {
const cellPos = cellPositions[i];
const cell = table.nodeAt(cellPos);
if (cell && cell.type === state.schema.nodes.th) {
tr.setNodeMarkup(cellPos + pos + 1, state.schema.nodes.td, cell.attrs);
}
}
// Cells with an invalid span are left out of the table map, so reset them
// to a single row and column.
table.forEach((row, rowOffset) => {
row.forEach((cell, cellOffset) => {
const cellPos = pos + 1 + rowOffset + 1 + cellOffset;
for (const name of ["colspan", "rowspan"]) {
if (!isValidCellSpan(cell.attrs[name])) {
tr.setNodeAttribute(cellPos, name, 1);
}
}
});
});
}