mirror of
https://github.com/outline/outline.git
synced 2026-11-22 05:51:43 +03:00
* fix: Consume OAuth authorization codes and refresh tokens atomically The exchange of an authorization code, and the rotation of a refresh token, read the credential and deleted it in two steps. Concurrent requests with the same credential could both pass the read and each receive a token. Claim the credential with a single conditional statement instead, so that only one of a set of concurrent requests continues to token issuance. * fix: Move OAuthAuthentications delete to predicate-scoped destroy.
52 lines
1.6 KiB
TypeScript
52 lines
1.6 KiB
TypeScript
import crypto from "node:crypto";
|
|
import { Scope } from "@shared/types";
|
|
import { OAuthAuthorizationCode } from "@server/models";
|
|
import { buildOAuthClient, buildUser } from "@server/test/factories";
|
|
import { hash } from "@server/utils/crypto";
|
|
|
|
const buildCode = async () => {
|
|
const user = await buildUser();
|
|
const client = await buildOAuthClient({ teamId: user.teamId });
|
|
const code = crypto.randomBytes(32).toString("hex");
|
|
|
|
await OAuthAuthorizationCode.create({
|
|
authorizationCodeHash: hash(code),
|
|
scope: [Scope.Read],
|
|
redirectUri: client.redirectUris[0],
|
|
oauthClientId: client.id,
|
|
userId: user.id,
|
|
expiresAt: new Date(Date.now() + 10000),
|
|
grantId: crypto.randomUUID(),
|
|
});
|
|
|
|
return code;
|
|
};
|
|
|
|
describe("OAuthAuthorizationCode", () => {
|
|
describe("consume", () => {
|
|
it("should consume the code once", async () => {
|
|
const code = await buildCode();
|
|
|
|
expect(await OAuthAuthorizationCode.consume(code)).toBe(true);
|
|
expect(await OAuthAuthorizationCode.consume(code)).toBe(false);
|
|
expect(await OAuthAuthorizationCode.findByCode(code)).toBeNull();
|
|
});
|
|
|
|
it("should succeed for a single caller when consumed concurrently", async () => {
|
|
const code = await buildCode();
|
|
|
|
const consumed = await Promise.all([
|
|
OAuthAuthorizationCode.consume(code),
|
|
OAuthAuthorizationCode.consume(code),
|
|
OAuthAuthorizationCode.consume(code),
|
|
]);
|
|
|
|
expect(consumed.filter(Boolean).length).toBe(1);
|
|
});
|
|
|
|
it("should not consume an unknown code", async () => {
|
|
expect(await OAuthAuthorizationCode.consume("unknown")).toBe(false);
|
|
});
|
|
});
|
|
});
|