mirror of
https://github.com/outline/outline.git
synced 2026-11-21 21:44:30 +03:00
* feat: Support OAuth Client ID Metadata Documents for MCP clients MCP clients can send an https URL as their client_id. The server fetches the metadata document at that URL and caches one team-less client row per URL, so MCP works on the root domain without dynamic registration. Closes #14010 * fix: Address review findings for client ID metadata documents - Only count unexpired tokens when cleaning up metadata document clients - Reject backslashes, whitespace and trailing host dots in client_id URLs - Strip trailing dots before installation host comparisons - Type clientSecret as nullable * fix: Keep OAuth clients with pending authorization codes during cleanup * refactor: Simplify client ID metadata document handling - Gate metadata document fetches on the MCP preference inside the helper - Add isMCPClient getter and a shared client ID prefix constant - Enforce the team/metadata document CHECK in both directions - Index oauthClientId on OAuth token and code tables - Reuse parseDomain, clamp and time helpers * revert: Remove pending authorization code check from OAuth client cleanup * fix: Block all special-use addresses when fetching client metadata documents ALLOWED_PRIVATE_IP_ADDRESSES no longer applies to client ID metadata document requests (draft -02 section 8.6). The fetch wrapper takes an allowIPAddressList option to override the environment list. * fix: Reject empty userinfo in client metadata document URLs https://@host and https://:@host have a userinfo component that the URL parser drops, so check the raw authority (draft -02 section 3). * fix: Accept a root path in client metadata document URLs Draft -02 section 3 marks a root path as NOT RECOMMENDED, not invalid, so https://example.com/ is a valid client_id. A URL with no path is still rejected. * fix: Reject client metadata documents with private key material A jwks key with private or symmetric members (d, p, q, dp, dq, qi, oth, k) makes the document invalid, so it is not cached (draft -02 section 4.1). Public keys are still ignored. * fix: Respect no-cache, no-store and Age for client metadata documents no-store and no-cache now expire the cached document at once, so it is fetched again before the next authorization. Freshness from max-age or Expires (measured from Date) is reduced by Age before clamping (draft -02 section 5.2). * feat: Copy DCR and CIMD client logos to file storage in the background logo_uri was rendered directly on the consent screen, which lets the logo host track users and change the image at any time (draft -02 sections 8.8 and 9.2). A background task now fetches the logo with the strict fetch rules, accepts only PNG, JPEG, GIF and WebP by their leading bytes, and stores it content addressed in the public bucket. Requests never wait for the upload. * fix: Match loopback redirect URIs on any port Native apps such as Claude Code register http://localhost/callback and then listen on a free port, so an exact match rejected them. Loopback redirect URIs now match on any port (RFC 8252 section 7.3); the scheme, host and path must still match, and other URIs still match exactly. * fix: Only break the redirect URL mid-word on the consent screen break-all on the whole notice split words such as "continue" in the loopback warning. It now applies only to the redirect URL. * chore: Shorten the loopback warning on the consent screen * fix: Show the punycode host of client metadata documents on the consent screen A lookalike Unicode host was shown as written. Hostnames now come from a shared getHostname helper that returns the punycode form. * refactor: Move image type detection to ImageHelper and use it for avatars Avatars and integration logos copied from a URL are now stored only if they are PNG, JPEG, GIF or WebP, with the content type detected from the file data rather than the remote host. * fix: Address review findings for OAuth client logos and metadata caching - Count the time since the Date header as age when caching metadata documents, so a document is not cached past its Expires time - Log logo scheduling failures instead of failing registration requests - Run dynamic client registration in a transaction - Delete copied logos from storage when no client uses them * fix: Store one logo per OAuth client and return a distinct metadata document error - Logos are stored per client, so a file is only deleted when its own client stops using it. This removes the reference count and its race. - A metadata document that cannot be fetched or is invalid now returns invalid_client_metadata with the reason, not a 404. Network errors are only logged. - Move scheduleOptional to BaseTask so that any task can use it.
226 lines
5.8 KiB
TypeScript
226 lines
5.8 KiB
TypeScript
export const AttachmentValidation = {
|
|
/** The limited allowable mime-types for user and team avatars */
|
|
avatarContentTypes: ["image/jpg", "image/jpeg", "image/png"],
|
|
|
|
/**
|
|
* The mime-types and file extensions offered by the avatar file picker. HEIC
|
|
* and HEIF images are converted to a type in `avatarContentTypes` by the
|
|
* client before they are uploaded. Extensions are included because some
|
|
* platforms report an empty mime-type for these files.
|
|
*/
|
|
avatarInputContentTypes: [
|
|
"image/jpg",
|
|
"image/jpeg",
|
|
"image/png",
|
|
"image/heic",
|
|
"image/heif",
|
|
".heic",
|
|
".heif",
|
|
],
|
|
|
|
/** The most widely supported mime-types across modern browsers */
|
|
emojiContentTypes: [
|
|
"image/png",
|
|
"image/webp",
|
|
"image/gif",
|
|
"image/jpeg",
|
|
"image/jpg",
|
|
],
|
|
|
|
/** The maximum file size for emoji uploads */
|
|
emojiMaxFileSize: 1 * 1000 * 1000,
|
|
|
|
/** Image mime-types commonly supported by modern browsers */
|
|
imageContentTypes: [
|
|
"image/jpg",
|
|
"image/jpeg",
|
|
"image/pjpeg",
|
|
"image/png",
|
|
"image/apng",
|
|
"image/avif",
|
|
"image/gif",
|
|
"image/webp",
|
|
"image/svg",
|
|
"image/svg+xml",
|
|
"image/bmp",
|
|
"image/tiff",
|
|
"image/heic",
|
|
],
|
|
};
|
|
|
|
export const ApiKeyValidation = {
|
|
/** The minimum length of the API key name */
|
|
minNameLength: 3,
|
|
/** The maximum length of the API key name */
|
|
maxNameLength: 255,
|
|
};
|
|
|
|
export const CollectionValidation = {
|
|
/** The maximum length of the collection description */
|
|
maxDescriptionLength: 100 * 1000,
|
|
|
|
/** The maximum length of the collection name */
|
|
maxNameLength: 100,
|
|
};
|
|
|
|
export const CommentValidation = {
|
|
/** The maximum length of a comment */
|
|
maxLength: 10_000,
|
|
};
|
|
|
|
export const DeprecationValidation = {
|
|
/** The maximum length of an archive or deletion reason. */
|
|
maxReasonLength: 2000,
|
|
};
|
|
|
|
export const DocumentValidation = {
|
|
/** The maximum length of the document title */
|
|
maxTitleLength: 100,
|
|
|
|
/** The maximum length of the document summary */
|
|
maxSummaryLength: 1000,
|
|
|
|
/** The maximum size of the collaborative document state */
|
|
maxStateLength: 1500 * 1024,
|
|
|
|
/** The maximum recommended size of the document content */
|
|
maxRecommendedLength: 250000,
|
|
|
|
/** The maximum length of the document text content */
|
|
maxLength: 1500 * 1024,
|
|
};
|
|
|
|
export const GroupValidation = {
|
|
/** The maximum length of the group name */
|
|
maxNameLength: 255,
|
|
/** The maximum length of the group description */
|
|
maxDescriptionLength: 2000,
|
|
};
|
|
|
|
export const ImportValidation = {
|
|
/** The maximum length of the import name */
|
|
maxNameLength: 100,
|
|
};
|
|
|
|
export const OAuthClientValidation = {
|
|
/** The maximum length of the OAuth client name */
|
|
maxNameLength: 100,
|
|
|
|
/** The maximum length of the OAuth client description */
|
|
maxDescriptionLength: 255,
|
|
|
|
/** The maximum length of the OAuth client developer name */
|
|
maxDeveloperNameLength: 100,
|
|
|
|
/** The maximum length of the OAuth client developer URL */
|
|
maxDeveloperUrlLength: 1024,
|
|
|
|
/** The maximum length of the OAuth client avatar URL */
|
|
maxAvatarUrlLength: 1024,
|
|
|
|
/** The maximum length of an OAuth client redirect URI */
|
|
maxRedirectUriLength: 1024,
|
|
|
|
/** The maximum length of an OAuth client ID, which can be a metadata document URL */
|
|
maxClientIdLength: 1024,
|
|
|
|
/** The prefix of client IDs that are the URL of a client ID metadata document */
|
|
metadataDocumentClientIdPrefix: "https://",
|
|
|
|
/** The maximum number of redirect URIs for an OAuth client */
|
|
maxRedirectUris: 20,
|
|
|
|
/** The allowed OAuth client types */
|
|
clientTypes: ["confidential", "public"] as const,
|
|
};
|
|
|
|
export const ShareValidation = {
|
|
/** The maximum length of the share title */
|
|
maxTitleLength: 255,
|
|
|
|
/** The maximum length of the share iconUrl */
|
|
maxIconUrlLength: 4096,
|
|
};
|
|
|
|
export const RevisionValidation = {
|
|
minNameLength: 1,
|
|
maxNameLength: 255,
|
|
};
|
|
|
|
export const UserPasskeyValidation = {
|
|
minNameLength: 1,
|
|
maxNameLength: 255,
|
|
};
|
|
|
|
export const PinValidation = {
|
|
/** The maximum number of pinned documents on an individual collection or home screen */
|
|
max: 8,
|
|
};
|
|
|
|
export const TeamValidation = {
|
|
/** The maximum number of domains per team on cloud hosted */
|
|
maxDomains: 10,
|
|
|
|
/** The maximum length of the team name */
|
|
maxNameLength: 255,
|
|
|
|
/** The maximum length of the team description */
|
|
maxDescriptionLength: 1000,
|
|
|
|
/** The minimum length of the team subdomain */
|
|
minSubdomainLength: 2,
|
|
|
|
/** The maximum length of the team subdomain for cloud */
|
|
maxSubdomainLength: 32,
|
|
|
|
/** The maximum length of the team subdomain for self-hosted */
|
|
maxSubdomainSelfHostedLength: 255,
|
|
|
|
/** The maximum length of a team domain */
|
|
maxDomainLength: 255,
|
|
|
|
/** The maximum length of MCP workspace guidance */
|
|
maxGuidanceMCPLength: 10000,
|
|
|
|
/** The recommended length of MCP workspace guidance, beyond which a warning is shown */
|
|
warnGuidanceMCPLength: 2000,
|
|
};
|
|
|
|
export const UserValidation = {
|
|
/** The maximum number of invites per request */
|
|
maxInvitesPerRequest: 20,
|
|
|
|
/** The maximum length of the user name */
|
|
maxNameLength: 255,
|
|
|
|
/** The maximum length of the user email */
|
|
maxEmailLength: 255,
|
|
};
|
|
|
|
export const WebhookSubscriptionValidation = {
|
|
/** The maximum number of webhooks per team */
|
|
maxSubscriptions: 10,
|
|
/** The maximum length of the webhook name */
|
|
maxNameLength: 255,
|
|
/** The maximum length of the webhook url */
|
|
maxUrlLength: 1024,
|
|
};
|
|
|
|
export const FilterValidation = {
|
|
/** The maximum nesting depth of a filter expression */
|
|
maxDepth: 5,
|
|
|
|
/** The maximum number of values in an `in` / `notIn` array */
|
|
maxInValues: 100,
|
|
|
|
/** The maximum number of conditions and groups a filter may contain */
|
|
maxNodes: 50,
|
|
};
|
|
|
|
export const EmojiValidation = {
|
|
/** The maximum length of the emoji name */
|
|
maxNameLength: 25,
|
|
/* the characters allowed in the name */
|
|
allowedNameCharacters: /^[a-z0-9_]*$/,
|
|
};
|