mirror of
https://github.com/outline/outline.git
synced 2026-11-20 21:23:06 +03:00
Session tokens were accepted from the request body and query string, unlike the other credential types parsed by the same middleware. They are now only read from the cookie or the Authorization header. Short-lived single-use transfer tokens are unaffected, so the subdomain and desktop sign-in hand-offs continue to work. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
49 lines
1.5 KiB
TypeScript
49 lines
1.5 KiB
TypeScript
import { buildUser } from "@server/test/factories";
|
|
import { getTestServer } from "@server/test/support";
|
|
import { SetupAction } from "./schema";
|
|
|
|
const server = getTestServer();
|
|
|
|
describe("#github.callback", () => {
|
|
it("should reject callback when state nonce does not match cookie", async () => {
|
|
const user = await buildUser();
|
|
const state = JSON.stringify({
|
|
teamId: user.teamId,
|
|
nonce: "attacker-nonce",
|
|
});
|
|
const res = await server.get(
|
|
`/api/github.callback?state=${encodeURIComponent(
|
|
state
|
|
)}&code=123&setup_action=${SetupAction.install}&installation_id=1`,
|
|
user,
|
|
{ redirect: "manual" }
|
|
);
|
|
const body = await res.json();
|
|
expect(res.status).toEqual(400);
|
|
expect(body.error).toEqual("state_mismatch");
|
|
});
|
|
|
|
it("should reject callback when nonce is missing from state", async () => {
|
|
const user = await buildUser();
|
|
const state = JSON.stringify({ teamId: user.teamId });
|
|
const res = await server.get(
|
|
`/api/github.callback?state=${encodeURIComponent(
|
|
state
|
|
)}&code=123&setup_action=${SetupAction.install}&installation_id=1`,
|
|
user,
|
|
{ redirect: "manual" }
|
|
);
|
|
expect(res.status).toEqual(400);
|
|
});
|
|
|
|
it("should fail when state is not valid JSON", async () => {
|
|
const user = await buildUser();
|
|
const res = await server.get(
|
|
`/api/github.callback?state=bad&code=123&setup_action=${SetupAction.install}&installation_id=1`,
|
|
user,
|
|
{ redirect: "manual" }
|
|
);
|
|
expect(res.status).toEqual(400);
|
|
});
|
|
});
|