Commit Graph
797 Commits
Author SHA1 Message Date
Joe Wilm be2c2922fe Syslog panics - gotta catch'm all!
Previously, panics only were printed when run from a shell. Now, on all
systems (so this is tots broken outside linux), panic reports are
shipped to the syslog with a backtrace.
2018-05-04 14:50:27 -07:00
Christian Duerr 0853fafe48 Remove push from Storage
Since every line is allocated at startup anyways, the `push` method on
`Storage` has been removed and instead of pushing to the vector the
initialization has been moved to the `with_capacity` method.

This has the advantage that we don't need to keep track of the `len` in
push (like adding one), but we just need to worry about
growing/shrinking the visible area.
2018-05-01 20:07:59 +02:00
Christian Duerr 946ef1e306 Improve the resizing implementation
Until now the resizing implementation with scrollback has been really
inefficient because it made use of APIs like `Vec::insert`. This has
been rewored with this commit.

A `len` property has been added to the `Storage` struct which keeps
track of the actual length of the raw buffer. This has changed both
shrinking and growing implementations.

With shrinking, no more lines are removed, only the `len` property is
updated to set all lines shrunk to an "invisible" state which cannot be
accessed from the outside, this effectively changes it to a O(1)
operation. The only issue with this would be memory consumption, but
since the maximum shrinkage is the number of lines on one screen, it
should be a rather small impacte (probabl <100 lines usually). If
desired it would be possible to change this to shrink the raw inner
buffer whenever there are more than X lines hidden.

Growing now works in a similar way to shrinking, if the "invisible"
lines are enough, no new lines are inserted but rather the invisible
buffer is made visible again. Otherwise the amount of lines that still
needs to be inserted is added to the raw buffer, but instead of the
inefficient `Vec::insert`, the `Vec::push` API is used now.

This fixes #1271.
2018-04-30 00:41:21 +02:00
Christian Duerr cf23f56999 Reset grid when running reset
In the current scrollback PR the `reset` command does not affect the
scrollback history. To make sure the terminal is properly reset, it
should clear the scrollback history.

To make resetting efficient, instead of resetting the history,
the scrollback history is hidden by setting `grid.scroll_limit` to `0`.
This will not clear the history but instead just make it inaccessible,
which should have the same effect.

The visible area is reset by the shell itself, so in combination this
clears the complete terminal grid from a user perspective.

This fixes #1242.
2018-04-28 14:14:45 +00:00
Christian Duerr 88305677f5 Fix bright characters in first column
This bug was introduced by the commit which fixed the invisible cursor
in the first column (54b21b66ec). To
resolve this the alternative implementation by @jwilm has been applied
which seems to work out.

This fixes #1259.
2018-04-24 10:01:33 -07:00
Christian Duerr 2b3ef5f664 Revert "Fix cursor not showing in first column"
This reverts commit 54b21b66ec.
2018-04-24 10:01:33 -07:00
Joe Wilm adf4b625e4 Compile on stable 2018-04-24 09:59:52 -07:00
Christian Duerr 298c5694a3 Fix order of lines after resize
There was an issue where the lines would be messed up when the terminal
was resized, this was because lines were just added/removed at the end
of the buffer instead of the actual end of the terminal (since the end
of the terminal might be in the middle of the buffer).

This has been fixed by relying on `self.zero` to determine the position
of the start of the terminal and then calculating where lines have to be
inserted/removed.

Some tests have also been added with documentation that should make it
a little easier to understand how the process works and how the raw
buffer is layed out.

This should all work no matter how big the scrollback history and even
when the currenty viewport is not at the bottom of the terminal output.
2018-04-24 09:59:52 -07:00
Christian Duerr e99e40059d Fix scrollback history size 0 bug
There was an issue where alacritty would panic whenever the scrollback
history size is set to 0, this fixes that issue.

The panic was caused by a substraction with unsigned integers which was
underflowing, this has been fixed to use `saturating_sub`.

After that was fixed there was still a bug where scrollback would not
behave correctly because the number of lines in the grid was decided at
startup.
This has been adapted so whenever the size of the terminal changes, the
scrollback history and grid adapts to make sure the number of lines in
the terminal is always the number of visible lines plus the amount of
scrollback lines configured in the config file.

This fixes #1150.
2018-04-24 09:59:52 -07:00
Christian Duerr 0d56818076 Add documentation to explain the process 2018-04-02 14:25:10 -07:00
Christian Duerr 54b21b66ec Fix cursor not showing in first column
There was a bug in the display iterator where the first column was never
reached after the top line because it was instantly incremented to 1
after it was reset when iterator column reached the end of the terminal
width.

This has been fixed by making sure that the column is never incremented
when the column is reset due to a change in terminal line.

This fixes #1198.
2018-04-02 14:25:10 -07:00
Joe Wilm 99a5007358 Fix BCE ref tests
BCE was broken in attempt to optimize row clearing. The fix is to revert
to passing in the current cursor state when clearing.
2018-04-02 10:10:22 -07:00
Christian Duerr 5b8553ba40 Fix selection tests
The latest selection changes broke a few tests, these have been
corrected.

Two of these tests were broken because they assumed different span
types, the test have been changed here because the result was correct.

One test did actually catch a bug where selection of two cells from
right to left would incorrectly mark the cells as selected even though
they should not have been, this has been fixed in the `simple_span`
method.
2018-04-02 10:10:22 -07:00
Joe Wilm 187e120156 Fix grid scroll tests 2018-04-02 10:10:22 -07:00
Joe Wilm 98a1f7f508 Make tests compile again
Some tests are still not passing, though.

A migration script was added to migrate serialized grids from
pre-scrollback to the current format. The script is included with this
commit for completeness, posterity, and as an example to be used in the
future.

A few tests in grid/tests.rs were removed due to becoming irrelevant.
2018-04-02 10:10:22 -07:00
Christian Duerr 9ee1cf2455 Rework auto-scrolling options
This changes two things, the first thing it does is that now whenever a
keybinding sends an escape sequence, the viewport is automatically
scrolled to the bottom.
This is enabled by default and fixes #1187.

The second thing is automatic scrolling when a command writes to the
terminal. So when running a command like `sleep 3; ls -lah`, alacritty
will scroll to the bottom once the output is sent, even if the viewport
is currently not at the bottom of the scrollback.
Because this can have an impact on performance, and is not enabled by
default in terminals like iTerm or Termite (VTE), it is an opt-in
setting in the config.
2018-03-23 10:47:38 -07:00
Joe Wilm 14a76ec5c7 Fix regression with scrolling regions
Resolves #1154
2018-03-20 10:04:22 -07:00
Christian Duerr 55ba60441f Refactor span_simple selection
The current `span_simple` selection is everything but simple. This
version should have the same functionality as the current `span_simple`
with the difference that a lot of complexity has been removed.

Not only is this code shorter, it should also be significantly easier to
understand with no "magic" to it. This will hopefully prevent us from
having an unmaintainable blob of off-by-one guessing in the repo.

Also removed the `out` file which I used in the original PR because
scrollback is not implemented yet. :)
2018-03-15 17:30:47 -07:00
Christian Duerr 70324fc6fc Replace scrolling methods with enum
The different scrolling methods added a bunch of boilerplate where the
call was just forwarded to the next struct, this has been removed by
making the scroll amount into a struct.

Now everything is called through one method and the parameter decides
how far the viewport should be scrolled.
2018-03-15 12:27:12 -07:00
Christian Duerr e7a32b589f Add scrollback hotkeys
This offers a few additional hotkeys that can be used in combination
with scrollback. None of these are used by default yet.

This implements the following bindings:
 - ScrollPageUp: Scroll exactly one screen height up
 - ScrollPageDown: Scroll exactly one screen height down
 - ScrollToTop: Scroll as far up as possible
 - ScrollToBottom: Scroll as far down as possible

This fixes #1151.
2018-03-15 12:27:12 -07:00
Christian Duerr d9be2d2d88 Fix selection starting in first cell
When selecting to the top and starting in the first cell, alacritty
would crash. These cases have been fixed and now selection should be
completely working.
2018-03-13 16:58:15 -07:00
Christian Duerr c1acbe47e6 Fix buggy selection when scrolling down
When scrolling down with a selection on screen the first line was not
properly selected. This has been fixed by making sure the selection
always starts in the first cell when it is only partially visible.
2018-03-13 16:58:15 -07:00
Christian Duerr 6173603677 Fix multi-line selection with single cell end
When the user selected multiple lines, dragging the selection downwards,
and then leaves the cursor to the left side of the first cell, the first
cell was still incorrectly selected. This has been fixed.

The selection also did not update if the mouse was outside of the
window, now all movement events are accpeted even when the mouse is
outside of the window. This allows updating the selection when the user
is dragging the cursor too far.

Mouse movement and click events outside of the window are not
propagated, these are only used for updating the selection.
2018-03-13 16:58:15 -07:00
Christian Duerr f8e36d1663 Fix selection in scrollback
There were a few issues with selection in scrollback that were mainly
off-by-one errors. This aims at fixing these issues.

This also fixes a bug that currently exists in master where the last
cell is not selected when the mouse leaves the window to the right.
2018-03-13 16:58:15 -07:00
Christian Duerr a741193bc0 Fix linux config default value 2018-03-13 14:52:14 -07:00
Christian Duerr c1e831dab0 Merge branch #1095
Because there was some overlap with branch #1095, these two PRs have
been added together and the config has been restructured to make use of
a `scrolling` section.

The default faux scrolling amount has also been changed to `3` because
this simplifies the code and falls in line with what most other terminal
emulators do.

There should be no additional test failures due to this.
2018-03-13 14:52:14 -07:00
Christian Duerr 290e2cfb17 Change config file to display the correct default 2018-03-13 14:52:14 -07:00
Christian Duerr 5dbe6e58b9 Make normal scrolling line amount configurable
It is now possible to configure the amount of lines the viewport should
scroll when using the normal scrolling mode.

This fixes #1160.
2018-03-13 14:52:14 -07:00
Christian Duerr fce67e6f3f Fix crash when selection leaves viewport
There was an issue where alacritty tries to convert the lines in a
selection to the on-screen lines even when the selection is not on the
screen. This results in a crash.

To prevent this from happening the selection now is not shown if it is
off the screen.

There currently still is a bug that when the selection is at the top of
the screen but still half visible, it will not show the top line as
selected but start in the second line.
This bug should be resolved with
https://github.com/jwilm/alacritty/pull/1171.

This fixes #1148.
2018-03-12 23:00:15 -07:00
Christian Duerr 8dd6f5c791 Disable faux scrolling when shift is pressed
To make it possible to access the native scrollback buffer in the
alternate screen without having to disable faux scrolling, faux
scrolling is now disabled when the `shift` key is held down.

This should allow alacritty to have the best of both worlds, a native
scrollback buffer in the alternate screen buffer and faux scrolling.
2018-03-12 22:55:57 -07:00
Christian Duerr f8c833ea66 Add faux_scrolling back to scrollback 2018-03-12 22:55:57 -07:00
Christian Duerr e472aa0cb4 Provide correct default for scroll_history
When implementing fallback to the default value with an u32 you will get
0 as the default value.

However the default scrollback value is 10_000. A custom deserializer
has been implemented which automatically falls back to the correct
default value.
2018-03-09 09:47:21 -08:00
Christian Duerr 52ebf3e6ec Add failure_default deserializer to scroll_history 2018-03-09 09:47:21 -08:00
Joe Wilm ec49105203 Fix 4+ line copying 2018-03-08 20:12:48 -08:00
Joe Wilm 80f46cc59f Disable LTO
It's nice to be able to use incremental compilation for release builds.

TODO quantify performance impact.
2018-03-08 20:12:22 -08:00
Joe Wilm 8520a280f7 Add SCROLL_MULTIPLIER
Scroll wheel needs some scaling so it feels like urxvt and friends.
2018-03-07 09:56:19 -08:00
Joe Wilm 143c28953c Support selections with scrolling buffer
Selections now *mostly* work. They move as the buffer scrolls, copying
works as it should, and it looks like the different selection modes
behave properly as well.

The new Selection implementation uses buffer coordinates instead of
screen coordinates. This leads to doing a transform from mouse input to
update the selection, and back to screen coordinates when displaying the
selection. Scrolling the selection is fast because the grid is already
operating in buffer coordinates.

There are several bugs to address:

* A _partially_ visible selection will lead to a crash since the drawing
  routine converts selection coordinates to screen coordinates. The
  solution will be to clip the coordinates at draw time.
* A selection scrolling off the buffer in either direction leads to
  indexing out-of-bounds. The solution again is to clip, but this needs
  to be done within Selection::rotate by passing a max limit. It may
  also need a return type to indicate that the selection is no longer
  visible and should be discarded.
* A selection scrolling out of a logical scrolling region is not
  clipped. A temporary and robust workaround is to simply discard the
  selection in the case of scrolling in a region.

wip selections

fix issue with line selection

selection mostly working

need to support selection not being on the screen at draw time

Fix selection_to_string

Uncomment tests
2018-03-07 09:51:51 -08:00
Joe Wilm 2cfdd595f1 Move selection into Grid
Supporting selections with scrollback has two major components:

1. Grid needs access to Selection so that it may update the scroll
   position as the terminal text changes.
2. Selection needs to be implemented in terms of buffer offsets -- NOT
   lines -- and be updated when Storage is rotated.

This commit implements the first part.
2018-03-07 09:51:06 -08:00
Joe Wilm 69f533d19e Style cleanup 2018-03-07 09:50:46 -08:00
Joe Wilm 40298c50e2 Fix scrolling backwards in tmux 2018-03-07 09:47:21 -08:00
Joe Wilm 5c648a34aa Make number of scrollback lines configurable 2018-03-07 09:47:21 -08:00
Joe Wilm 001b780dda Scroll to bottom on character received 2018-03-07 09:47:21 -08:00
Joe Wilm 96da93efd6 wip fix scroll_down 2018-03-07 09:47:21 -08:00
Joe Wilm 8854124ff0 Fir cursor not scrolling 2018-03-07 09:47:21 -08:00
Joe Wilm 751ef349b8 Add scrolling limit and update on grow lines 2018-03-07 09:47:21 -08:00
Joe Wilm cfc4ebfd6a checkpoint: very basic scrolling works
Things that do not work

- Limiting how far back in the buffer it's possible to scroll
- Selections (need to transform to buffer offsets)
2018-03-07 09:47:21 -08:00
Joe Wilm 6d1d41f8c7 wip scrollback 2018-03-07 09:46:18 -08:00
Joe Wilm 7af765502f Remove some unused impls 2018-03-07 09:46:18 -08:00
Joe Wilm debf6003b5 Minor improvements 2018-03-07 09:46:18 -08:00
Joe Wilm be89dbf30b WIP optimize scroll in region
This intends to optimize the case where the top of the scrolling region
is the top of the screen. In theory, scrolling in this case can be
optimized to shifting the start/end of the visible region, and then
rearranging any lines that were not supposed to be scrolled (at the
bottom of the region). However, this didn't produce quite the speedup I
expected.
2018-03-07 09:46:18 -08:00