This commit is contained in:
Tom Moor committed 2025-10-18 23:47:41 -04:00
1 parent 33fd46bb71
commit 452db6cc30
5 files changed
+13 -15

No files matched your search

+1 -1
View File
@@ -74,7 +74,7 @@ function Notifications() {
{
event: NotificationEventType.GroupMentionedInDocument,
icon: <GroupIcon />,
title: t("Group Mentions"),
title: t("Group mentions"),
description: t(
"Receive a notification when someone mentions a group you are a member of in a document or comment"
),
@@ -99,12 +99,12 @@ export default class GroupCommentMentionedEmail extends BaseEmail<
return;
}
protected subject({ document }: Props) {
return `Your group was mentioned in “${document.titleWithDefault}”`;
protected subject({ document, groupName }: Props) {
return `The ${groupName} group was mentioned in “${document.titleWithDefault}”`;
}
protected preview({ actorName, groupName }: Props): string {
return `${actorName} mentioned your group, "${groupName}", in a thread`;
return `${actorName} mentioned the "${groupName}" group in a thread`;
}
protected fromName({ actorName }: Props): string {
@@ -120,7 +120,7 @@ export default class GroupCommentMentionedEmail extends BaseEmail<
groupName,
}: Props): string {
return `
${actorName} mentioned your group, "${groupName}", in a comment on "${document.titleWithDefault}"${
${actorName} mentioned the "${groupName}" group in a comment on "${document.titleWithDefault}"${
collection.name ? ` in the ${collection.name} collection` : ""
}.
@@ -151,7 +151,7 @@ Open Thread: ${teamUrl}${document.url}?commentId=${commentId}
<Body>
<Heading>{document.titleWithDefault}</Heading>
<p>
{actorName} mentioned your group, "{groupName}", in a comment on{" "}
{actorName} mentioned the "{groupName}" group in a comment on{" "}
<a href={threadLink}>{document.titleWithDefault}</a>{" "}
{collection.name ? ` in the ${collection.name} collection` : ""}.
</p>
@@ -97,12 +97,12 @@ export default class GroupDocumentMentionedEmail extends BaseEmail<
return { document, body, groupName: group.name };
}
protected subject({ document }: Props) {
return `Your group was mentioned in “${document.titleWithDefault}”`;
protected subject({ document, groupName }: Props) {
return `The ${groupName} group was mentioned in “${document.titleWithDefault}”`;
}
protected preview({ actorName, groupName }: Props): string {
return `${actorName} mentioned your group, "${groupName}"`;
return `${actorName} mentioned the "${groupName}" group`;
}
protected fromName({ actorName }: Props) {
@@ -125,9 +125,7 @@ export default class GroupDocumentMentionedEmail extends BaseEmail<
groupName,
}: Props): string {
return `
Your group was mentioned.
${actorName} mentioned your group, “${groupName}”, in the document “${document.titleWithDefault}”.
${actorName} mentioned the “${groupName}” group in the document “${document.titleWithDefault}”.
Open Document: ${teamUrl}${document.url}
`;
@@ -147,7 +145,7 @@ Open Document: ${teamUrl}${document.url}
<Body>
<Heading>Your group was mentioned</Heading>
<p>
{actorName} mentioned your group, "{groupName}", in the document{" "}
{actorName} mentioned the "{groupName}" group in the document{" "}
<a href={documentLink}>{document.titleWithDefault}</a>.
</p>
{body && (
+1 -1
View File
@@ -49,7 +49,7 @@ describe("Notification", () => {
});
});
describe.only("should return mention reference", () => {
describe("should return mention reference", () => {
it("mentioned in document", async () => {
const document = await buildDocument();
const notification = await buildNotification({
+1 -1
View File
@@ -1104,7 +1104,7 @@
"Receive a notification when a document you are subscribed to or a thread you participated in receives a comment": "Receive a notification when a document you are subscribed to or a thread you participated in receives a comment",
"Mentioned": "Mentioned",
"Receive a notification when someone mentions you in a document or comment": "Receive a notification when someone mentions you in a document or comment",
"Group Mentions": "Group Mentions",
"Group mentions": "Group mentions",
"Receive a notification when someone mentions a group you are a member of in a document or comment": "Receive a notification when someone mentions a group you are a member of in a document or comment",
"Receive a notification when a comment thread you were involved in is resolved": "Receive a notification when a comment thread you were involved in is resolved",
"Reaction added": "Reaction added",