Check document access before creating @mention notification

This commit is contained in:
Tom Moor committed 2024-09-15 21:27:07 -04:00
1 parent 23b3b8aa54
commit e032bb5ab8
1 file changed
+15 -1
@@ -8,6 +8,7 @@ import Logger from "@server/logging/Logger";
import { Document, Revision, Notification, User, View } from "@server/models";
import { DocumentHelper } from "@server/models/helpers/DocumentHelper";
import NotificationHelper from "@server/models/helpers/NotificationHelper";
import { authorize } from "@server/policies";
import { RevisionEvent } from "@server/types";
import BaseTask, { TaskPriority } from "./BaseTask";
@@ -52,7 +53,8 @@ export default class RevisionCreatedNotificationsTask extends BaseTask<RevisionE
recipient.id !== mention.actorId &&
recipient.subscribedToEventType(
NotificationEventType.MentionedInDocument
)
) &&
(await this.canAccess(recipient, document))
) {
await Notification.create({
event: NotificationEventType.MentionedInDocument,
@@ -149,6 +151,18 @@ export default class RevisionCreatedNotificationsTask extends BaseTask<RevisionE
return true;
};
private canAccess = async (user: User, model: Document) => {
try {
const document = await Document.findByPk(model.id, {
userId: user.id,
});
authorize(user, "read", document);
return true;
} catch (err) {
return false;
}
};
public get options() {
return {
priority: TaskPriority.Background,